Re: [PATCH v2 1/2] USB: check port changes before hub runtime suspend for some bug device

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Ming Lei wrote: > >> + pm_wakeup_event(&hdev->dev, 2000); > >> + return -EBUSY; > >> + } > >> + } > > > > The !PMSG_IS_AUTO case should not return -EBUSY, because > > usb_suspend_both() will ignore the return valu

Re: [PATCH v2 1/2] USB: check port changes before hub runtime suspend for some bug device

2012-09-27 Thread Ming Lei
On Thu, Sep 27, 2012 at 10:31 PM, Alan Stern wrote: > On Thu, 27 Sep 2012, Ming Lei wrote: > >> From: Ming Lei >> >> The hub status endpoint has a long 'bInterval', which is 255ms >> for FS/LS device and 256ms for HS device according to USB 2.0 spec, >> so the device connection change may be repo

Re: [PATCH v2 1/2] USB: check port changes before hub runtime suspend for some bug device

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Ming Lei wrote: > From: Ming Lei > > The hub status endpoint has a long 'bInterval', which is 255ms > for FS/LS device and 256ms for HS device according to USB 2.0 spec, > so the device connection change may be reported later more than 255ms > via status pipe. > > The conne

[PATCH v2 1/2] USB: check port changes before hub runtime suspend for some bug device

2012-09-26 Thread Ming Lei
From: Ming Lei The hub status endpoint has a long 'bInterval', which is 255ms for FS/LS device and 256ms for HS device according to USB 2.0 spec, so the device connection change may be reported later more than 255ms via status pipe. The connection change in hub may have been happened already on