At commit 925aa46ba963a4da6d8ee6ab1d04a02ffa8db62b, Richard Zhao
adds the phy notification callback
when port change occurs. In fact, this phy notification should
be added according to below rules:
1. Only set HW_USBPHY_CTRL.ENHOSTDISCONDETECT
during high speed host mode.
2. Do not set HW_USBPHY_
On Mon, 8 Oct 2012, Peter Chen wrote:
> At commit 925aa46ba963a4da6d8ee6ab1d04a02ffa8db62b, Richard Zhao
> adds the phy notification callback
> when port change occurs. In fact, this phy notification should
> be added according to below rules:
>
> 1. Only set HW_USBPHY_CTRL.ENHOSTDISCONDETECT
>
>
> Simply reading this patch shows that it contains at least two errors.
Thanks for review.
>
> > @@ -4187,6 +4190,10 @@ static void hub_port_connect_change(struct
> usb_hub *hub, int port1,
> > }
> > }
> >
> > + if (hcd->phy && !hdev->parent &&
> > + !(portstatus
On Tue, 9 Oct 2012, Chen Peter-B29397 wrote:
> > > @@ -4187,6 +4190,10 @@ static void hub_port_connect_change(struct
> > usb_hub *hub, int port1,
> > > }
> > > }
> > >
> > > + if (hcd->phy && !hdev->parent &&
> > > + !(portstatus & USB_PORT_STAT_CONNECTION))
> > > +
On Tue, Oct 09, 2012 at 10:25:21AM -0400, Alan Stern wrote:
> On Tue, 9 Oct 2012, Chen Peter-B29397 wrote:
>
> > > > @@ -4187,6 +4190,10 @@ static void hub_port_connect_change(struct
> > > usb_hub *hub, int port1,
> > > > }
> > > > }
> > > >
> > > > + if (hcd->phy &&
On Wed, 10 Oct 2012, Peter Chen wrote:
> > That means the first patch breaks the code. People running "git
> > bisect" might happen to hit a commit in between the two patches, and
> > their kernels won't compile. That's not acceptable.
>
> So, a good practice is merging .h (changed API) and .
