Re: [PATCH v3] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-03-10 Thread Felipe Balbi
On Tue, Mar 10, 2015 at 06:22:17PM -0300, Fabio Estevam wrote: > On Tue, Mar 10, 2015 at 6:20 PM, Felipe Balbi wrote: > > On Tue, Feb 03, 2015 at 07:18:17PM -0200, Fabio Estevam wrote: > >> From: Fabio Estevam > >> > >> Commit 9eb0797722895f4309b4 ("usb: phy: generic: fix the gpios to be > >> op

Re: [PATCH v3] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-03-10 Thread Fabio Estevam
On Tue, Mar 10, 2015 at 6:20 PM, Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 07:18:17PM -0200, Fabio Estevam wrote: >> From: Fabio Estevam >> >> Commit 9eb0797722895f4309b4 ("usb: phy: generic: fix the gpios to be >> optional") >> calls gpiod_direction_output() in the probe function, so there

Re: [PATCH v3] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-03-10 Thread Felipe Balbi
On Tue, Feb 03, 2015 at 07:18:17PM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > Commit 9eb0797722895f4309b4 ("usb: phy: generic: fix the gpios to be > optional") > calls gpiod_direction_output() in the probe function, so there is no need to > call it again, as we can simply call gpiod_s

[PATCH v3] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-02-03 Thread Fabio Estevam
From: Fabio Estevam Commit 9eb0797722895f4309b4 ("usb: phy: generic: fix the gpios to be optional") calls gpiod_direction_output() in the probe function, so there is no need to call it again, as we can simply call gpiod_set_value() directly. Also, in usb_gen_phy_shutdown() we can simply put the