RE: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-15 Thread 林政易
, 2013 3:55 AM To: Johan Hovold Cc: Andrew Lunn; linux-usb@vger.kernel.org; Danny Lin (林政易); Ray Chen (陳松昱) Subject: Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver On Wed, Oct 09, 2013 at 07:27:42PM +0200, Johan Hovold wrote: On Wed, Oct 09, 2013 at 12:57:45PM +0200, Johan Hovold wrote

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-15 Thread Andrew Lunn
On Tue, Oct 15, 2013 at 08:30:51AM +, Danny Lin (林政易) wrote: Hi Andrew, We can do the interface testing but I want to know how to get the latest source. We need about 5 days to do the testing for all models and give you a testing report. Hi Danny Thanks for the offer of testing.

RE: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-15 Thread 林政易
: Tuesday, October 15, 2013 4:40 PM To: Danny Lin (林政易) Cc: Andrew Lunn; linux-usb@vger.kernel.org; Johan Hovold; Ray Chen (陳松昱) Subject: Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver On Tue, Oct 15, 2013 at 08:30:51AM +, Danny Lin (林政易) wrote: Hi Andrew, We can do the interface

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-12 Thread Johan Hovold
On Wed, Oct 09, 2013 at 12:57:45PM +0200, Johan Hovold wrote: On Wed, Sep 25, 2013 at 11:53:00AM +0200, Andrew Lunn wrote: TODO Custom resume function You have to implement a custom resume function as usb-serial will use the incompatible generic one otherwise. Model it after the generic

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-10 Thread Johan Hovold
On Wed, Oct 09, 2013 at 09:54:54PM +0200, Andrew Lunn wrote: On Wed, Oct 09, 2013 at 07:27:42PM +0200, Johan Hovold wrote: This should probably remain a device-specific parameter. We already have the MOXA mxser-driver with similar configuration options. This one uses a custom ioctl to set

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-09 Thread Johan Hovold
On Wed, Oct 09, 2013 at 12:57:45PM +0200, Johan Hovold wrote: On Wed, Sep 25, 2013 at 11:53:00AM +0200, Andrew Lunn wrote: [...] +#define MX_INT_RS232 0 +#define MX_INT_2W_RS4851 +#define MX_INT_RS422 2 +#define MX_INT_4W_RS485

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-09 Thread Andrew Lunn
On Wed, Oct 09, 2013 at 07:27:42PM +0200, Johan Hovold wrote: On Wed, Oct 09, 2013 at 12:57:45PM +0200, Johan Hovold wrote: On Wed, Sep 25, 2013 at 11:53:00AM +0200, Andrew Lunn wrote: [...] +#define MX_INT_RS232 0 +#define MX_INT_2W_RS485 1 +#define

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-01 Thread Johan Hovold
On Wed, Sep 25, 2013 at 11:53 AM, Andrew Lunn and...@lunn.ch wrote: Add a driver which supports the following Moxa USB to serial converters I have not had time to review v3 yet, but I should be able to look at it by the end of the week. Thanks, Johan -- To unsubscribe from this list: send the

[PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-09-25 Thread Andrew Lunn
Add a driver which supports the following Moxa USB to serial converters: * 2 ports : UPort 1250, UPort 1250I * 4 ports : UPort 1410, UPort 1450, UPort 1450I * 8 ports : UPort 1610-8, UPort 1650-8 * 16 ports : UPort 1610-16, UPort 1650-16 The UPORT devices don't directy fit

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-09-25 Thread Greg KH
Not a comment on the code, just your text: On Wed, Sep 25, 2013 at 11:53:00AM +0200, Andrew Lunn wrote: Add a driver which supports the following Moxa USB to serial converters: * 2 ports : UPort 1250, UPort 1250I * 4 ports : UPort 1410, UPort 1450, UPort 1450I * 8 ports :