Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-11 Thread wlf
Dear Doug, 在 2018年05月11日 04:59, Doug Anderson 写道: Hi, On Wed, May 9, 2018 at 1:55 AM, wlf wrote: + } else if (hsotg->params.host_dma) { Are you sure this is "else if"? Can't you have descriptor DMA enabled in the controller and still need to do a normal DMA

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-10 Thread Doug Anderson
Hi, On Wed, May 9, 2018 at 1:55 AM, wlf wrote: > + } else if (hsotg->params.host_dma) { Are you sure this is "else if"? Can't you have descriptor DMA enabled in the controller and still need to do a normal DMA transfer if you plug in a hub?

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-09 Thread wlf
Dear Doug, 在 2018年05月08日 23:29, Doug Anderson 写道: Hi, On Tue, May 8, 2018 at 12:43 AM, wlf wrote: Dear Doug, 在 2018年05月08日 13:11, Doug Anderson 写道: Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: +static int

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-08 Thread Doug Anderson
Hi, On Tue, May 8, 2018 at 12:43 AM, wlf wrote: > Dear Doug, > > 在 2018年05月08日 13:11, Doug Anderson 写道: >> >> Hi, >> >> On Mon, May 7, 2018 at 8:07 PM, William Wu >> wrote: >>> >>> +static int dwc2_alloc_split_dma_aligned_buf(struct dwc2_hsotg

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-08 Thread wlf
Dear Doug, 在 2018年05月08日 13:11, Doug Anderson 写道: Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: +static int dwc2_alloc_split_dma_aligned_buf(struct dwc2_hsotg *hsotg, + struct dwc2_qh *qh, +

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-07 Thread Doug Anderson
Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: > +static int dwc2_alloc_split_dma_aligned_buf(struct dwc2_hsotg *hsotg, > + struct dwc2_qh *qh, > + struct dwc2_host_chan *chan) >

[PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-07 Thread William Wu
The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more supported way") rips out a lot of code to simply the allocation of aligned DMA. However, it also introduces a new issue when use isoc split in transfer. In my test case, I connect the dwc2 controller with an usb hs Hub