Re: [PATCH v3 10/11] usb: otg: Add dual-role device (DRD) support

2015-07-27 Thread Roger Quadros
On 20/07/15 04:23, Peter Chen wrote: On Fri, Jul 17, 2015 at 01:47:12PM +0300, Roger Quadros wrote: + * DRD mode hardware Inputs + * + * @id: TRUE for B-device, FALSE for A-device. + * @vbus: VBUS voltage in regulation. + * * OTG hardware Inputs * *Common inputs

Re: [PATCH v3 10/11] usb: otg: Add dual-role device (DRD) support

2015-07-19 Thread Peter Chen
On Fri, Jul 17, 2015 at 01:47:12PM +0300, Roger Quadros wrote: + * DRD mode hardware Inputs + * + * @id: TRUE for B-device, FALSE for A-device. + * @vbus: VBUS voltage in regulation. + * * OTG hardware Inputs * *Common inputs for A and B device @@ -122,7

Re: [PATCH v3 10/11] usb: otg: Add dual-role device (DRD) support

2015-07-17 Thread Li Jun
Hi, On Wed, Jul 08, 2015 at 01:19:36PM +0300, Roger Quadros wrote: DRD mode is a reduced functionality OTG mode. In this mode we don't support SRP, HNP and dynamic role-swap. In DRD operation, the controller mode (Host or Peripheral) is decided based on the ID pin status. Once a cable plug

Re: [PATCH v3 10/11] usb: otg: Add dual-role device (DRD) support

2015-07-17 Thread Roger Quadros
On 17/07/15 12:02, Li Jun wrote: On Wed, Jul 08, 2015 at 01:19:36PM +0300, Roger Quadros wrote: [...] struct otg_fsm *usb_otg_register(struct device *parent_dev, - struct otg_fsm_ops *fsm_ops) + struct otg_fsm_ops *fsm_ops, +

Re: [PATCH v3 10/11] usb: otg: Add dual-role device (DRD) support

2015-07-17 Thread Li Jun
On Wed, Jul 08, 2015 at 01:19:36PM +0300, Roger Quadros wrote: [...] struct otg_fsm *usb_otg_register(struct device *parent_dev, - struct otg_fsm_ops *fsm_ops) + struct otg_fsm_ops *fsm_ops, + bool

Re: [PATCH v3 10/11] usb: otg: Add dual-role device (DRD) support

2015-07-17 Thread Roger Quadros
On 17/07/15 11:14, Li Jun wrote: Hi, On Wed, Jul 08, 2015 at 01:19:36PM +0300, Roger Quadros wrote: DRD mode is a reduced functionality OTG mode. In this mode we don't support SRP, HNP and dynamic role-swap. In DRD operation, the controller mode (Host or Peripheral) is decided based on

[PATCH v3 10/11] usb: otg: Add dual-role device (DRD) support

2015-07-08 Thread Roger Quadros
DRD mode is a reduced functionality OTG mode. In this mode we don't support SRP, HNP and dynamic role-swap. In DRD operation, the controller mode (Host or Peripheral) is decided based on the ID pin status. Once a cable plug (Type-A or Type-B) is attached the controller selects the state and