Re: [PATCH v3 7/9] rcar-phy: add platform data

2013-04-10 Thread Sergei Shtylyov
On 04/10/2013 10:40 PM, Felipe Balbi wrote: Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since this register contains board-specific USB ports configuration and so its value should be somehow passed via the platform data. Add file with the USBPCTRL0 bit #define's and

Re: [PATCH v3 7/9] rcar-phy: add platform data

2013-04-10 Thread Felipe Balbi
Hi, On Wed, Apr 10, 2013 at 09:44:33PM +0400, Sergei Shtylyov wrote: > Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong > since this > register contains board-specific USB ports configuration and so its value > should > be somehow passed via the platform

Re: [PATCH v3 7/9] rcar-phy: add platform data

2013-04-10 Thread Sergei Shtylyov
Hello. On 04/10/2013 09:16 PM, Felipe Balbi wrote: Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since this register contains board-specific USB ports configuration and so its value should be somehow passed via the platform data. Add file with the USBPCTRL0 bit #define

Re: [PATCH v3 7/9] rcar-phy: add platform data

2013-04-10 Thread Felipe Balbi
Hi, On Wed, Apr 10, 2013 at 06:03:49PM +0400, Sergei Shtylyov wrote: > On 10-04-2013 13:00, Felipe Balbi wrote: > > >>Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since > >>this > >>register contains board-specific USB ports configuration and so its value > >>should > >

Re: [PATCH v3 7/9] rcar-phy: add platform data

2013-04-10 Thread Sergei Shtylyov
On 10-04-2013 13:00, Felipe Balbi wrote: Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since this register contains board-specific USB ports configuration and so its value should be somehow passed via the platform data. Add file with the USBPCTRL0 bit #define's and 'str

Re: [PATCH v3 7/9] rcar-phy: add platform data

2013-04-10 Thread Felipe Balbi
Hi, On Wed, Apr 10, 2013 at 02:37:49AM +0400, Sergei Shtylyov wrote: > Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since > this > register contains board-specific USB ports configuration and so its value > should > be somehow passed via the platform data. Add file wit

[PATCH v3 7/9] rcar-phy: add platform data

2013-04-09 Thread Sergei Shtylyov
Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since this register contains board-specific USB ports configuration and so its value should be somehow passed via the platform data. Add file with the USBPCTRL0 bit #define's and 'struct rcar_phy_platform_data' containing the v