Re: [PATCH v6 02/10] usb: dwc3: omap: Make the wrapper interrupt shared

2016-04-11 Thread Felipe Balbi
Hi, Roger Quadros writes: > On 11/04/16 15:58, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: > diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c > index 22e9606..51ca098 100644 > --- a/drivers/usb/dwc3/dwc3-omap.c > +++ b/drivers/usb/dwc3/dwc

Re: [PATCH v6 02/10] usb: dwc3: omap: Make the wrapper interrupt shared

2016-04-11 Thread Roger Quadros
On 11/04/16 15:58, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index 22e9606..51ca098 100644 --- a/drivers/usb/dwc3/dwc3-omap.c +++ b/drivers/usb/dwc3/dwc3-omap.c @@ -274,19 +274,25 @@ sta

Re: [PATCH v6 02/10] usb: dwc3: omap: Make the wrapper interrupt shared

2016-04-11 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c >>> index 22e9606..51ca098 100644 >>> --- a/drivers/usb/dwc3/dwc3-omap.c >>> +++ b/drivers/usb/dwc3/dwc3-omap.c >>> @@ -274,19 +274,25 @@ static irqreturn_t dwc3_omap_interrupt(int irq, void >

Re: [PATCH v6 02/10] usb: dwc3: omap: Make the wrapper interrupt shared

2016-04-11 Thread Roger Quadros
On 11/04/16 15:13, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> The wrapper interrupt is shared with OTG core so mark it IRQF_SHARED. >> >> Use request_threaded_irq() to ensure that irqflags match for the >> shared interrupt handlers. If we don't use request_treaded_irq() then >> for

Re: [PATCH v6 02/10] usb: dwc3: omap: Make the wrapper interrupt shared

2016-04-11 Thread Felipe Balbi
Hi, Roger Quadros writes: > The wrapper interrupt is shared with OTG core so mark it IRQF_SHARED. > > Use request_threaded_irq() to ensure that irqflags match for the > shared interrupt handlers. If we don't use request_treaded_irq() then > forced threaded irq will set IRQF_ONESHOT and this won'

[PATCH v6 02/10] usb: dwc3: omap: Make the wrapper interrupt shared

2016-04-11 Thread Roger Quadros
The wrapper interrupt is shared with OTG core so mark it IRQF_SHARED. Use request_threaded_irq() to ensure that irqflags match for the shared interrupt handlers. If we don't use request_treaded_irq() then forced threaded irq will set IRQF_ONESHOT and this won't match with the OTG irq handler. Sig