Linus Walleij writes:
> On Thu, Sep 25, 2014 at 3:44 PM, wrote:
>
>> Could you also review patch 1/3 while at it ;) ?
>
> This is patch 1/3...
>
> I guess you mean the others.
Ah yeah, I meant patch 3/3, slipped on the keyboard.
A full review is always welcome, but patches 1/3 and 3/3 touch gp
Hi,
On Thu, Sep 25, 2014 at 03:44:34PM +0200, robert.jarz...@free.fr wrote:
> - Mail original -
> De: "Linus Walleij"
> À: "Robert Jarzmik"
> Cc: "Felipe Balbi" , linux-usb@vger.kernel.org
> Envoyé: Jeudi 25 Septembre 2014 15:10:16
>
On Thu, Sep 25, 2014 at 3:44 PM, wrote:
> Could you also review patch 1/3 while at it ;) ?
This is patch 1/3...
I guess you mean the others.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More
- Mail original -
De: "Linus Walleij"
À: "Robert Jarzmik"
Cc: "Felipe Balbi" , linux-usb@vger.kernel.org
Envoyé: Jeudi 25 Septembre 2014 15:10:16
Objet: Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare
device-tree support
In that case, that
On Thu, Sep 25, 2014 at 11:47 AM, wrote:
>> } else {
>> udv->gpiod = devm_gpiod_get(&pdev->dev, ...);
>> }
>> Here you can also use the flags.
>
> Yeah, but my problem is in the if statement, not in the else. The else is for
> the DT/ACPI cases, in which there is no problem.
Damned mailer s
On Thu, Sep 25, 2014 at 11:47 AM, wrote:
> De: "Linus Walleij"
>> @@ -2415,7 +2411,13 @@ static int pxa_udc_probe(struct platform_device *pdev)
>> {
>> struct resource *regs;
>> struct pxa_udc *udc = &memory;
>> - int retval = 0, gpio;
>> + struct pxa2xx_udc_mach_inf
- Mail original -
De: "Linus Walleij"
> @@ -2415,7 +2411,13 @@ static int pxa_udc_probe(struct platform_device *pdev)
> {
> struct resource *regs;
> struct pxa_udc *udc = &memory;
> - int retval = 0, gpio;
> + struct pxa2xx_udc_mach_info *mach = dev_get_platdat
On Wed, Sep 24, 2014 at 11:05 PM, Robert Jarzmik wrote:
> For this preparation, a preliminary cleanup is done :
> - convert the probing of pxa27x_udc to gpio_desc.
> The conversion is partial because :
> - the platform data still provides a gpio number, not a gpio desc
> - the "in
For this preparation, a preliminary cleanup is done :
- convert the probing of pxa27x_udc to gpio_desc.
The conversion is partial because :
- the platform data still provides a gpio number, not a gpio desc
- the "invert" attribute is lost, hence a loss in the translation
The drawba
