Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-05-03 Thread Lu Baolu
Hi, On 05/03/2016 07:49 PM, Mark Brown wrote: > On Tue, May 03, 2016 at 09:43:58AM +0800, Lu Baolu wrote: >> On 05/02/2016 07:00 PM, Mark Brown wrote: >>> On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); + if (IS_ERR(gpiod))

Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-05-03 Thread Mark Brown
On Tue, May 03, 2016 at 09:43:58AM +0800, Lu Baolu wrote: > On 05/02/2016 07:00 PM, Mark Brown wrote: > > On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: > >> + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); > >> + if (IS_ERR(gpiod)) > >> + return PTR_ERR(gpiod); > > This is

Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-05-02 Thread Lu Baolu
Hi, On 05/02/2016 07:00 PM, Mark Brown wrote: > On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: > >> +gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); >> +if (IS_ERR(gpiod)) >> +return PTR_ERR(gpiod); > This is clearly an inappropriate name for the signal in generic

Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-05-02 Thread Mark Brown
On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: > + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); > + if (IS_ERR(gpiod)) > + return PTR_ERR(gpiod); This is clearly an inappropriate name for the signal in generic code, it's specific to your use case. signature.asc

[PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-04-29 Thread Lu Baolu
Add support to retrieve fixed voltage configure information through ACPI interface. This is needed for Intel Bay Trail devices, where a GPIO is used to control the USB vbus. Signed-off-by: Lu Baolu --- drivers/regulator/fixed.c | 46