Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-13 Thread Robert Jarzmik
Paul Zimmerman paul.zimmer...@synopsys.com writes: The patch below fixes it. And it seems like the right thing to me, since GPIOs should be optional for a generic phy, I would think. But my device tree foo is very weak, so I'm not sure. CCing Robert, who touched the generic phy code last.

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-13 Thread Felipe Balbi
On Tue, Jan 13, 2015 at 10:35:52AM +0100, Robert Jarzmik wrote: Paul Zimmerman paul.zimmer...@synopsys.com writes: The patch below fixes it. And it seems like the right thing to me, since GPIOs should be optional for a generic phy, I would think. But my device tree foo is very weak, so I'm

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-12 Thread Paul Zimmerman
From: Paul Zimmerman Sent: Saturday, January 10, 2015 3:52 PM From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Saturday, January 10, 2015 8:07 AM 在 2015/1/9 10:15, Paul Zimmerman 写道: [...] /* - * Attempt to find a generic PHY, then look for an old style -

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Yunzhi Li
Hi paul: 在 2015/1/9 10:15, Paul Zimmerman 写道: [...] /* -* Attempt to find a generic PHY, then look for an old style -* USB PHY, finally fall back to pdata +* If platform probe couldn't find a generic PHY or an old style +* USB PHY, fall back to pdata

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Yunzhi Li
Hi Paul: On 2015/1/9 10:15, Paul Zimmerman wrote: /* -* Attempt to find a generic PHY, then look for an old style -* USB PHY, finally fall back to pdata +* If platform probe couldn't find a generic PHY or an old style +* USB PHY, fall back to pdata

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Paul Zimmerman
From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Saturday, January 10, 2015 8:07 AM 在 2015/1/9 10:15, Paul Zimmerman 写道: [...] /* - * Attempt to find a generic PHY, then look for an old style - * USB PHY, finally fall back to pdata + * If platform probe couldn't find a

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-08 Thread Paul Zimmerman
From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Friday, December 12, 2014 7:10 AM Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li l...@rock-chips.com Acked-by: Paul Zimmerman pa...@synopsys.com --- Changes in v7: None

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-15 Thread Doug Anderson
Yunzhi, On Fri, Dec 12, 2014 at 7:09 AM, Yunzhi Li l...@rock-chips.com wrote: Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li l...@rock-chips.com Acked-by: Paul Zimmerman pa...@synopsys.com --- Changes in v7: None Changes in v6:

[PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-12 Thread Yunzhi Li
Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li l...@rock-chips.com Acked-by: Paul Zimmerman pa...@synopsys.com --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Fix coding style: both