Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-10 Thread Felipe Balbi
Hi, Roger Quadros writes: > On 10/06/16 11:18, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: dwc->xhci_resource[1] = *res; >>> >>> Probably not as we don't want to change parent/child members. >> >> oh, you had already replied. Sorry. This is correct >> > np :). > > So w

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-10 Thread Roger Quadros
On 10/06/16 11:18, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> dwc->xhci_resource[1] = *res; >> >> Probably not as we don't want to change parent/child members. > > oh, you had already replied. Sorry. This is correct > np :). So what i'll do is get the irq via platform_get_i

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-10 Thread Felipe Balbi
Hi, Roger Quadros writes: >> dwc->xhci_resource[1] = *res; > > Probably not as we don't want to change parent/child members. oh, you had already replied. Sorry. This is correct -- balbi signature.asc Description: PGP signature

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-10 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Is it expected to have more than one IRQ here? >> >> if not - it will better to use platform_get_irq[_byname](). >> > > The reason I used platform_get_resource variant is that i'm passing the > resource directly to the XHCI platform device below. >> >>> + >>> +

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-10 Thread Roger Quadros
On 10/06/16 11:02, Roger Quadros wrote: > Grygorii, > > On 02/06/16 14:52, Grygorii Strashko wrote: >> On 06/01/2016 10:46 AM, Roger Quadros wrote: >>> Implementations might use different IRQs for >>> host, gadget and OTG so use named interrupt resources >>> to allow Device tree to specify the 3 i

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-10 Thread Roger Quadros
Grygorii, On 02/06/16 14:52, Grygorii Strashko wrote: > On 06/01/2016 10:46 AM, Roger Quadros wrote: >> Implementations might use different IRQs for >> host, gadget and OTG so use named interrupt resources >> to allow Device tree to specify the 3 interrupts. >> >> Following are the interrupt names

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-10 Thread Roger Quadros
On 07/06/16 14:49, Grygorii Strashko wrote: > On 06/07/2016 12:34 PM, Roger Quadros wrote: >> On 02/06/16 14:52, Grygorii Strashko wrote: >>> On 06/01/2016 10:46 AM, Roger Quadros wrote: Implementations might use different IRQs for host, gadget and OTG so use named interrupt resources >>>

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Roger Quadros
On 07/06/16 16:09, Felipe Balbi wrote: > > Hi, > > (guys, please make sure to break lines at 80-columns) > > Roger Quadros writes: >> @@ -2853,6 +2852,23 @@ static irqreturn_t dwc3_interrupt(int irq, void >> *_evt) >>int dwc3_gadget_init(struct dwc3 *dwc) >>{ >>

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Felipe Balbi
Hi, (guys, please make sure to break lines at 80-columns) Roger Quadros writes: > @@ -2853,6 +2852,23 @@ static irqreturn_t dwc3_interrupt(int irq, void > *_evt) >int dwc3_gadget_init(struct dwc3 *dwc) >{ >intret; > +struct resour

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Roger Quadros
On 07/06/16 14:49, Grygorii Strashko wrote: > On 06/07/2016 12:34 PM, Roger Quadros wrote: >> On 02/06/16 14:52, Grygorii Strashko wrote: >>> On 06/01/2016 10:46 AM, Roger Quadros wrote: Implementations might use different IRQs for host, gadget and OTG so use named interrupt resources >>>

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Grygorii Strashko
On 06/07/2016 12:34 PM, Roger Quadros wrote: > On 02/06/16 14:52, Grygorii Strashko wrote: >> On 06/01/2016 10:46 AM, Roger Quadros wrote: >>> Implementations might use different IRQs for >>> host, gadget and OTG so use named interrupt resources >>> to allow Device tree to specify the 3 interrupts.

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Roger Quadros
On 02/06/16 14:52, Grygorii Strashko wrote: > On 06/01/2016 10:46 AM, Roger Quadros wrote: >> Implementations might use different IRQs for >> host, gadget and OTG so use named interrupt resources >> to allow Device tree to specify the 3 interrupts. >> >> Following are the interrupt names >> >> Peri

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Roger Quadros
Felipe, On 01/06/16 11:06, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Implementations might use different IRQs for >> host, gadget and OTG so use named interrupt resources >> to allow Device tree to specify the 3 interrupts. >> >> Following are the interrupt names >> >> Peripheral

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-02 Thread Grygorii Strashko
On 06/01/2016 10:46 AM, Roger Quadros wrote: Implementations might use different IRQs for host, gadget and OTG so use named interrupt resources to allow Device tree to specify the 3 interrupts. Following are the interrupt names Peripheral Interrupt - peripheral HOST Interrupt - host OTG Interru

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-01 Thread Felipe Balbi
Hi, Roger Quadros writes: > Implementations might use different IRQs for > host, gadget and OTG so use named interrupt resources > to allow Device tree to specify the 3 interrupts. > > Following are the interrupt names > > Peripheral Interrupt - peripheral > HOST Interrupt - host > OTG Interrupt

[PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-01 Thread Roger Quadros
Implementations might use different IRQs for host, gadget and OTG so use named interrupt resources to allow Device tree to specify the 3 interrupts. Following are the interrupt names Peripheral Interrupt - peripheral HOST Interrupt - host OTG Interrupt - otg We still maintain backward compatibil