Hi,
Felipe Balbi writes:
> Mika Westerberg writes:
>> On Thu, Feb 18, 2016 at 01:31:33PM +0200, Heikki Krogerus wrote:
>>> On Thu, Feb 18, 2016 at 01:27:28PM +0200, Felipe Balbi wrote:
>>> > Heikki Krogerus writes:
>>> >
>>> > > On Wed, Feb 17, 2016 at 04:24:26PM +0200, Felipe Balbi wrote:
>>
On Thu, Feb 18, 2016 at 01:31:33PM +0200, Heikki Krogerus wrote:
> On Thu, Feb 18, 2016 at 01:27:28PM +0200, Felipe Balbi wrote:
> > Heikki Krogerus writes:
> >
> > > On Wed, Feb 17, 2016 at 04:24:26PM +0200, Felipe Balbi wrote:
> > >>
> > >> Hi,
> > >>
> > >> Heikki Krogerus writes:
> > >> >
On Thu, Feb 18, 2016 at 01:27:28PM +0200, Felipe Balbi wrote:
> Heikki Krogerus writes:
>
> > On Wed, Feb 17, 2016 at 04:24:26PM +0200, Felipe Balbi wrote:
> >>
> >> Hi,
> >>
> >> Heikki Krogerus writes:
> >> > This should allow the core driver to drop handling of
> >> > platform data and expe
Heikki Krogerus writes:
> On Wed, Feb 17, 2016 at 04:24:26PM +0200, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Heikki Krogerus writes:
>> > This should allow the core driver to drop handling of
>> > platform data and expect the platform specific details to
>> > always come from properties.
>> >
>> >
On Wed, Feb 17, 2016 at 04:24:26PM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Heikki Krogerus writes:
> > This should allow the core driver to drop handling of
> > platform data and expect the platform specific details to
> > always come from properties.
> >
> > Signed-off-by: Heikki Krogerus
> > C
Hi,
Heikki Krogerus writes:
> Hi John,
>
>> Hi Heikki,
>>
>> The properties are now set using your patch.
>>
>> However I get a use-after-free error when I unload the driver:
>
> OK. I need to prepare proper fixes for the fwnode handling, but I
> think these patches are in any case OK. Though
Hi,
Heikki Krogerus writes:
> This should allow the core driver to drop handling of
> platform data and expect the platform specific details to
> always come from properties.
>
> Signed-off-by: Heikki Krogerus
> Cc: Huang Rui
> CC: John Youn
doesn't compile dude:
make -k -j16 -- drivers/usb
Hi John,
> Hi Heikki,
>
> The properties are now set using your patch.
>
> However I get a use-after-free error when I unload the driver:
OK. I need to prepare proper fixes for the fwnode handling, but I
think these patches are in any case OK. Though they now depend on
those fixes of course.
On 2/9/2016 5:51 AM, Heikki Krogerus wrote:
> Hi,
>
>> I can reproduce this now when the device does not have primary fwnode
>> (of_node or ACPI). Everything seems to work fine if there is the
>> primary fwnode and when the build-in properties are used as the
>> secondary fwnode (fallback).
>>
>>
Hi,
> I can reproduce this now when the device does not have primary fwnode
> (of_node or ACPI). Everything seems to work fine if there is the
> primary fwnode and when the build-in properties are used as the
> secondary fwnode (fallback).
>
> This is a regression in drivers/base/property.c. Than
> > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> > index d064ba8..22cd49b 100644
> > --- a/drivers/usb/dwc3/dwc3-pci.c
> > +++ b/drivers/usb/dwc3/dwc3-pci.c
> > @@ -47,6 +47,14 @@ static const struct acpi_gpio_mapping
> > acpi_dwc3_byt_gpios[] = {
> >
> > static int
On 2/8/2016 12:26 AM, Heikki Krogerus wrote:
>>
>> The properties are being set here successfully but when queried in
>> core.c they all report 0.
>>
>> Any ideas?
>
> How are you testing that? I just tested those properties with
> linux-next and:
I tried on linux-next and still see the same thi
On 2/8/2016 12:26 AM, Heikki Krogerus wrote:
> Hi John,
>
>>> @@ -114,16 +117,14 @@ static int dwc3_pci_quirks(struct pci_dev *pdev)
>>> (pdev->device == PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 ||
>>> pdev->device == PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI ||
>>> pdev->device == PCI_
Hi John,
> > @@ -114,16 +117,14 @@ static int dwc3_pci_quirks(struct pci_dev *pdev)
> > (pdev->device == PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 ||
> > pdev->device == PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI ||
> > pdev->device == PCI_DEVICE_ID_SYNOPSYS_HAPSUSB31)) {
> > -
> > -
On 2/3/2016 1:03 AM, Heikki Krogerus wrote:
> This should allow the core driver to drop handling of
> platform data and expect the platform specific details to
> always come from properties.
>
> Signed-off-by: Heikki Krogerus
> Cc: Huang Rui
> CC: John Youn
> ---
> drivers/usb/dwc3/dwc3-pci.c
This should allow the core driver to drop handling of
platform data and expect the platform specific details to
always come from properties.
Signed-off-by: Heikki Krogerus
Cc: Huang Rui
CC: John Youn
---
drivers/usb/dwc3/dwc3-pci.c | 81 +++--
1 file cha
16 matches
Mail list logo
