Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, 2016-06-29 at 14:27 +0300, Heikki Krogerus wrote: > About the end user of the interface, I think Oliver knows more about > that. But I would imagine that the use cases will be something like, > for example, on systems that need prefer sertain roles, perhaps Host > for example on some

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 29, 2016 at 04:21:49PM +0530, Rajaram R wrote: > On Wed, Jun 29, 2016 at 4:00 PM, Heikki Krogerus > wrote: > > On Wed, Jun 29, 2016 at 02:21:10PM +0530, Rajaram R wrote: > >> On Mon, Jun 27, 2016 at 5:43 PM, Heikki Krogerus > >>

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 29, 2016 at 4:00 PM, Heikki Krogerus wrote: > On Wed, Jun 29, 2016 at 02:21:10PM +0530, Rajaram R wrote: >> On Mon, Jun 27, 2016 at 5:43 PM, Heikki Krogerus >> wrote: >> > Hi, >> > >> > On Mon, Jun 27, 2016 at

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 29, 2016 at 02:21:10PM +0530, Rajaram R wrote: > On Mon, Jun 27, 2016 at 5:43 PM, Heikki Krogerus > wrote: > > Hi, > > > > On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote: > >> May be I am missing user or usage of the driver.. I see this

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Mon, Jun 27, 2016 at 5:43 PM, Heikki Krogerus wrote: > Hi, > > On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote: >> May be I am missing user or usage of the driver.. I see this driver is >> providing limited information of the Type-C connectors or the

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On 06/28/2016 06:12 AM, Heikki Krogerus wrote: On Mon, Jun 27, 2016 at 06:39:46AM -0700, Guenter Roeck wrote: On 06/27/2016 05:13 AM, Heikki Krogerus wrote: Hi, On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote: May be I am missing user or usage of the driver.. I see this driver is

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Mon, Jun 27, 2016 at 06:39:46AM -0700, Guenter Roeck wrote: > On 06/27/2016 05:13 AM, Heikki Krogerus wrote: > > Hi, > > > > On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote: > > > May be I am missing user or usage of the driver.. I see this driver is > > > providing limited

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On 06/27/2016 05:13 AM, Heikki Krogerus wrote: Hi, On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote: May be I am missing user or usage of the driver.. I see this driver is providing limited information of the Type-C connectors or the port partner Yes, this interface can't provide

Re: [PATCHv3 1/2] usb: USB Type-C connector class

Hi, On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote: > May be I am missing user or usage of the driver.. I see this driver is > providing limited information of the Type-C connectors or the port > partner Yes, this interface can't provide directly information received from PD commands

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On 06/23/2016 05:00 AM, Heikki Krogerus wrote: Hi Oliver, On Thu, Jun 23, 2016 at 10:38:58AM +0200, Oliver Neukum wrote: On Thu, 2016-06-23 at 11:23 +0300, Heikki Krogerus wrote: On Wed, Jun 22, 2016 at 06:44:18PM +0200, Oliver Neukum wrote: No it's not. DRP means a port that can operate

Re: [PATCHv3 1/2] usb: USB Type-C connector class

Hi Roger, I'll fix all the typos you mention below... On Thu, Jun 23, 2016 at 02:53:11PM +0300, Roger Quadros wrote: > Hi Heikki, > > On 21/06/16 17:51, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user space to get the status

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Thu, Jun 23, 2016 at 03:25:46PM +0300, Roger Quadros wrote: > Hi, > > On 23/06/16 15:00, Heikki Krogerus wrote: > > Hi Oliver, > > > > On Thu, Jun 23, 2016 at 10:38:58AM +0200, Oliver Neukum wrote: > >> On Thu, 2016-06-23 at 11:23 +0300, Heikki Krogerus wrote: > >>> On Wed, Jun 22, 2016 at

Re: [PATCHv3 1/2] usb: USB Type-C connector class

Hi, On 23/06/16 15:00, Heikki Krogerus wrote: > Hi Oliver, > > On Thu, Jun 23, 2016 at 10:38:58AM +0200, Oliver Neukum wrote: >> On Thu, 2016-06-23 at 11:23 +0300, Heikki Krogerus wrote: >>> On Wed, Jun 22, 2016 at 06:44:18PM +0200, Oliver Neukum wrote: >> >>> No it's not. DRP means a port that

Re: [PATCHv3 1/2] usb: USB Type-C connector class

Hi Oliver, On Thu, Jun 23, 2016 at 10:38:58AM +0200, Oliver Neukum wrote: > On Thu, 2016-06-23 at 11:23 +0300, Heikki Krogerus wrote: > > On Wed, Jun 22, 2016 at 06:44:18PM +0200, Oliver Neukum wrote: > > > No it's not. DRP means a port that can operate as _either_ Source > > (host) or Sink

Re: [PATCHv3 1/2] usb: USB Type-C connector class

Hi Heikki, On 21/06/16 17:51, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when USB PD is s/PD/PD

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Thu, 2016-06-23 at 11:23 +0300, Heikki Krogerus wrote: > On Wed, Jun 22, 2016 at 06:44:18PM +0200, Oliver Neukum wrote: > No it's not. DRP means a port that can operate as _either_ Source > (host) or Sink (device), but not at the same time.. Yes, but it is unclear what you will be after a

Re: [PATCHv3 1/2] usb: USB Type-C connector class

Hi, On Wed, Jun 22, 2016 at 02:54:28PM -0700, Guenter Roeck wrote: > Hi, > > > + > > +static void typec_remove_partner(struct typec_port *port) > > +{ > > + WARN_ON(port->partner->alt_modes); > > You are setting partner->alt_modes in typec_register_altmodes(), > but you don't clear it in

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 22, 2016 at 06:44:18PM +0200, Oliver Neukum wrote: > On Wed, 2016-06-22 at 17:38 +0300, Heikki Krogerus wrote: > > On Wed, Jun 22, 2016 at 03:47:03PM +0200, Oliver Neukum wrote: > > > On Wed, 2016-06-22 at 14:44 +0300, Heikki Krogerus wrote: > > > > If our port is DRD (which would be

Re: [PATCHv3 1/2] usb: USB Type-C connector class

Hi, On Tue, Jun 21, 2016 at 05:51:50PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when USB

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, 2016-06-22 at 17:38 +0300, Heikki Krogerus wrote: > On Wed, Jun 22, 2016 at 03:47:03PM +0200, Oliver Neukum wrote: > > On Wed, 2016-06-22 at 14:44 +0300, Heikki Krogerus wrote: > > > If our port is DRD (which would be DRP in the port controller spec), > > > the supported_power_roles will

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 22, 2016 at 03:47:03PM +0200, Oliver Neukum wrote: > On Wed, 2016-06-22 at 14:44 +0300, Heikki Krogerus wrote: > > If our port is DRD (which would be DRP in the port controller spec), > > the supported_power_roles will list: > > > > device, host > > > > And the power role, if

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, 2016-06-22 at 14:44 +0300, Heikki Krogerus wrote: > If our port is DRD (which would be DRP in the port controller spec), > the supported_power_roles will list: > > device, host > > And the power role, if the port is Source only, the > supported_power_roles will list: > >

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 22, 2016 at 12:14:55PM +0200, Oliver Neukum wrote: > On Wed, 2016-06-22 at 12:50 +0300, Heikki Krogerus wrote: > > On Tue, Jun 21, 2016 at 10:25:05PM +0200, Oliver Neukum wrote: > > > On Tue, 2016-06-21 at 17:51 +0300, Heikki Krogerus wrote: > > > > +What:

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, 2016-06-22 at 13:03 +0300, Heikki Krogerus wrote: > On Wed, Jun 22, 2016 at 12:50:16PM +0300, Heikki Krogerus wrote: > > > But if the port is DRP, we will always be able to swap the data role > > between DFP and UFP. > > Just to clarify: DRP as it's defined in Type-C spec < 1.2 means

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, 2016-06-22 at 12:50 +0300, Heikki Krogerus wrote: > On Tue, Jun 21, 2016 at 10:25:05PM +0200, Oliver Neukum wrote: > > On Tue, 2016-06-21 at 17:51 +0300, Heikki Krogerus wrote: > > > +What: /sys/class/typec//supported_data_roles > > > +Data: June 2016 > > > +Contact:

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 22, 2016 at 12:50:16PM +0300, Heikki Krogerus wrote: > On Tue, Jun 21, 2016 at 10:25:05PM +0200, Oliver Neukum wrote: > > On Tue, 2016-06-21 at 17:51 +0300, Heikki Krogerus wrote: > > > +What: /sys/class/typec//supported_data_roles > > > +Data: June 2016 > > >

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Tue, Jun 21, 2016 at 10:25:05PM +0200, Oliver Neukum wrote: > On Tue, 2016-06-21 at 17:51 +0300, Heikki Krogerus wrote: > > +What: /sys/class/typec//supported_data_roles > > +Data: June 2016 > > +Contact: Heikki Krogerus > >

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Tue, 2016-06-21 at 17:51 +0300, Heikki Krogerus wrote: > +What: /sys/class/typec//supported_data_roles > +Data: June 2016 > +Contact: Heikki Krogerus > +Description: > + Lists the USB data roles, host or device, the port is

[PATCHv3 1/2] usb: USB Type-C connector class

The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when USB PD is available, also control over power role swapping and Alternate Modes.