Re: [Patch v2 02/14] usb: phy-mxs: Add platform judgement code

2013-10-23 Thread Shawn Guo
On Tue, Oct 22, 2013 at 01:58:36PM +0800, Peter Chen wrote: The mxs-phy has three versions until now, each versions have some differences among PHY operations. the 1st version is for mx23/mx28 SoC, The 2nd version is for mx6q and mx6dl, the 3rd version is for mx6sl and later mx6 platform.

Re: [Patch v2 02/14] usb: phy-mxs: Add platform judgement code

2013-10-23 Thread Peter Chen
On Wed, Oct 23, 2013 at 02:13:24PM +0800, Shawn Guo wrote: + +enum imx_phy_type { + IMX6Q_USB_PHY, + IMX6SL_USB_PHY, + IMX23_USB_PHY, +}; + struct mxs_phy { struct usb_phy phy; struct clk *clk; + enum imx_phy_type devtype; }; -#define to_mxs_phy(p)

Re: [Patch v2 02/14] usb: phy-mxs: Add platform judgement code

2013-10-23 Thread Shawn Guo
On Wed, Oct 23, 2013 at 02:46:04PM +0800, Peter Chen wrote: How about compare compatible string directly at probe? if (of_device_is_compatible(np, fsl,imx6q-usbphy)) mxs_phy-devtype = IMX6Q_USB_PHY; else if ((of_device_is_compatible(np, fsl,imx6sl-usbphy))

[Patch v2 02/14] usb: phy-mxs: Add platform judgement code

2013-10-22 Thread Peter Chen
The mxs-phy has three versions until now, each versions have some differences among PHY operations. the 1st version is for mx23/mx28 SoC, The 2nd version is for mx6q and mx6dl, the 3rd version is for mx6sl and later mx6 platform. Signed-off-by: Peter Chen peter.c...@freescale.com ---