[RESEND PATCH v3 2/4] usb: musb: Bugfix of_node assignment

2013-11-18 Thread Markus Pargmann
It is not safe to assign the of_node to a device without driver. The device is matched against a list of drivers and the of_node could lead to a DT match with the parent driver. Signed-off-by: Markus Pargmann --- drivers/usb/musb/musb_core.c | 12 +++- drivers/usb/musb/musb_dsps.c | 1 -

Re: [RESEND PATCH v3 2/4] usb: musb: Bugfix of_node assignment

2013-11-25 Thread Felipe Balbi
Hi, On Mon, Nov 18, 2013 at 04:54:36PM +0100, Markus Pargmann wrote: > It is not safe to assign the of_node to a device without driver. The > device is matched against a list of drivers and the of_node could lead > to a DT match with the parent driver. > > Signed-off-by: Markus Pargmann > --- >

Re: [RESEND PATCH v3 2/4] usb: musb: Bugfix of_node assignment

2013-11-25 Thread Sebastian Andrzej Siewior
On 11/25/2013 05:14 PM, Felipe Balbi wrote: > Hi, > > On Mon, Nov 18, 2013 at 04:54:36PM +0100, Markus Pargmann wrote: >> It is not safe to assign the of_node to a device without driver. >> The device is matched against a list of drivers and the of_node >> could lead to a DT match with the parent

Re: [RESEND PATCH v3 2/4] usb: musb: Bugfix of_node assignment

2013-11-26 Thread Markus Pargmann
Hi, On Mon, Nov 25, 2013 at 05:48:54PM +0100, Sebastian Andrzej Siewior wrote: > On 11/25/2013 05:14 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Nov 18, 2013 at 04:54:36PM +0100, Markus Pargmann wrote: > >> It is not safe to assign the of_node to a device without driver. > >> The device is ma

Re: [RESEND PATCH v3 2/4] usb: musb: Bugfix of_node assignment

2014-08-04 Thread Markus Pargmann
Hi Sebastian, This thread was about the of_node assignment for the child device musb-hdrc. Mainline commit: 4fc4b274f9b3 (usb: musb: dsps: do not bind to "musb-hdrc") On Mon, Nov 25, 2013 at 05:48:54PM +0100, Sebastian Andrzej Siewior wrote: > > Is this fixing a bug? Commit 4fc4b2 ("usb:

Re: [RESEND PATCH v3 2/4] usb: musb: Bugfix of_node assignment

2014-08-05 Thread Sebastian Andrzej Siewior
On 08/04/2014 12:13 PM, Markus Pargmann wrote: >> In the long term I would suggest to move the DT probe over to the musb >> core code and we wouldn't need the node assignment anymore… >> >> [0] http://www.spinics.net/lists/linux-usb/msg94701.html > > Really old thread but I just noticed that this

Re: [RESEND PATCH v3 2/4] usb: musb: Bugfix of_node assignment

2014-08-05 Thread Felipe Balbi
On Tue, Aug 05, 2014 at 02:33:25PM +0200, Sebastian Andrzej Siewior wrote: > On 08/04/2014 12:13 PM, Markus Pargmann wrote: > > >> In the long term I would suggest to move the DT probe over to the musb > >> core code and we wouldn't need the node assignment anymore… > >> > >> [0] http://www.spinic