[RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

2018-02-24 Thread Masahiro Yamada
As Documentation/kbuild/kconfig-language.txt notes, 'select' should be used with care - it forces a lower limit of another symbol, ignoring the dependency. MFD_SYSCON depends on HAS_IOMEM, but several drivers with COMPILE_TEST select it. This causes unmet dependencies for architecture without HAS

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

2018-02-25 Thread Andy Shevchenko
On Sat, Feb 24, 2018 at 4:50 PM, Masahiro Yamada wrote: > Also, make MFD_SYSCON 'default y' because some defconfig files may > rely on someone select's MFD_SYSCON. I'm not sure this is right thing to do. You basically imply that there always a user of it. -- With Best Regards, Andy Shevchenko

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

2018-02-26 Thread Arnd Bergmann
On Sat, Feb 24, 2018 at 3:50 PM, Masahiro Yamada wrote: > As Documentation/kbuild/kconfig-language.txt notes, 'select' should be > used with care - it forces a lower limit of another symbol, ignoring > the dependency. > > MFD_SYSCON depends on HAS_IOMEM, but several drivers with COMPILE_TEST > sel

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

2018-02-26 Thread Masahiro Yamada
2018-02-26 17:43 GMT+09:00 Arnd Bergmann : > On Sat, Feb 24, 2018 at 3:50 PM, Masahiro Yamada > wrote: >> As Documentation/kbuild/kconfig-language.txt notes, 'select' should be >> used with care - it forces a lower limit of another symbol, ignoring >> the dependency. >> >> MFD_SYSCON depends on HA

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

2018-02-26 Thread Arnd Bergmann
On Mon, Feb 26, 2018 at 12:53 PM, Masahiro Yamada wrote: > 2018-02-26 17:43 GMT+09:00 Arnd Bergmann : >> On Sat, Feb 24, 2018 at 3:50 PM, Masahiro Yamada >> wrote: >>> As Documentation/kbuild/kconfig-language.txt notes, 'select' should be >>> used with care - it forces a lower limit of another sy

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

2018-02-26 Thread Masahiro Yamada
2018-02-26 21:43 GMT+09:00 Arnd Bergmann : > On Mon, Feb 26, 2018 at 12:53 PM, Masahiro Yamada > wrote: >> 2018-02-26 17:43 GMT+09:00 Arnd Bergmann : >>> On Sat, Feb 24, 2018 at 3:50 PM, Masahiro Yamada >>> wrote: As Documentation/kbuild/kconfig-language.txt notes, 'select' should be us

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

2018-02-27 Thread Arnd Bergmann
On Tue, Feb 27, 2018 at 1:46 AM, Masahiro Yamada wrote: > 2018-02-26 21:43 GMT+09:00 Arnd Bergmann : >> On Mon, Feb 26, 2018 at 12:53 PM, Masahiro Yamada >> wrote: >>> 2018-02-26 17:43 GMT+09:00 Arnd Bergmann : On Sat, Feb 24, 2018 at 3:50 PM, Masahiro Yamada wrote: > As Documentat

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

2018-02-27 Thread Masahiro Yamada
2018-02-27 18:03 GMT+09:00 Arnd Bergmann : > On Tue, Feb 27, 2018 at 1:46 AM, Masahiro Yamada > wrote: >> 2018-02-26 21:43 GMT+09:00 Arnd Bergmann : >>> On Mon, Feb 26, 2018 at 12:53 PM, Masahiro Yamada >>> wrote: 2018-02-26 17:43 GMT+09:00 Arnd Bergmann : > On Sat, Feb 24, 2018 at 3:50

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

2018-02-27 Thread Arnd Bergmann
On Tue, Feb 27, 2018 at 11:22 AM, Masahiro Yamada wrote: > 2018-02-27 18:03 GMT+09:00 Arnd Bergmann : >> On Tue, Feb 27, 2018 at 1:46 AM, Masahiro Yamada >> wrote: >>> But, we need to decide what the right solution is. >> >> I think for consistency, we should change the existing >> 'depends on MF