Re: [RFC v2 0/4] Remove BUG() calls from xHCI driver

2013-06-18 Thread Mathias Nyman
On 06/17/2013 08:25 PM, Alan Stern wrote: On Mon, 17 Jun 2013, Sarah Sharp wrote: The older patchset did have some useful improvements, aside from the misguided patch to make the USB core be more robust about handling NULL pointers from usb_hub_to_struct_hub(). As discussed, that could only ha

Re: [RFC v2 0/4] Remove BUG() calls from xHCI driver

2013-06-17 Thread Sarah Sharp
On Mon, Jun 17, 2013 at 10:40:24AM -0700, Greg Kroah-Hartman wrote: > On Mon, Jun 17, 2013 at 09:55:17AM -0700, Sarah Sharp wrote: > > This is a revised version of the patchset that was originally sent to > > fix "security issues" identified by the Klockwork static analysis tool. > > As discussed,

Re: [RFC v2 0/4] Remove BUG() calls from xHCI driver

2013-06-17 Thread Greg Kroah-Hartman
On Mon, Jun 17, 2013 at 09:55:17AM -0700, Sarah Sharp wrote: > This is a revised version of the patchset that was originally sent to > fix "security issues" identified by the Klockwork static analysis tool. > As discussed, these weren't real security issues, mostly just Klockwork > not understandin

Re: [RFC v2 0/4] Remove BUG() calls from xHCI driver

2013-06-17 Thread Alan Stern
On Mon, 17 Jun 2013, Sarah Sharp wrote: > The older patchset did have some useful improvements, aside from the > misguided patch to make the USB core be more robust about handling NULL > pointers from usb_hub_to_struct_hub(). As discussed, that could only > happen if khubd binds to a hub with no

[RFC v2 0/4] Remove BUG() calls from xHCI driver

2013-06-17 Thread Sarah Sharp
This is a revised version of the patchset that was originally sent to fix "security issues" identified by the Klockwork static analysis tool. As discussed, these weren't real security issues, mostly just Klockwork not understanding that BUG() would stop code execution. The older patchset did have