RE: [RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

2012-10-23 Thread Andrzej Pietrasiewicz
Hello Felipe, Hello Sebastian, On Tuesday, October 23, 2012 8:55 AM Felipe Balbi wrote: > Hi, > > On Mon, Oct 22, 2012 at 04:26:35PM +0200, Sebastian Andrzej Siewior wrote: > > after a mkdir config0 you should allocate a struct usb_configuration for > this. > > > > |+->functio

Re: [RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

2012-10-23 Thread Sebastian Andrzej Siewior
On 10/23/2012 08:54 AM, Felipe Balbi wrote: Hi, Hi, On Mon, Oct 22, 2012 at 04:26:35PM +0200, Sebastian Andrzej Siewior wrote: after a mkdir config0 you should allocate a struct usb_configuration for this. |+->function0 |+ name (=> ether) Here I am not

Re: [RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

2012-10-23 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 04:26:35PM +0200, Sebastian Andrzej Siewior wrote: > after a mkdir config0 you should allocate a struct usb_configuration for this. > > |+->function0 > |+ name (=> ether) > > Here I am not sure if we should name it function0 and hav

Re: [RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

2012-10-22 Thread Sebastian Andrzej Siewior
* Andrzej Pietrasiewicz | 2012-10-22 10:13:48 [+0200]: >Perhaps I should have been more explicit about this: by RFC I mean something >not intended for merging yet but rather a proof of concept or the like. > >However, I am confused taken this: > >http://marc.info/?l=linux-usb&m=132431126927355&w=2

RE: [RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

2012-10-22 Thread Andrzej Pietrasiewicz
On Friday, October 19, 2012 5:27 PM Felipe Balbi wrote: > > I think what we want here is a possibility to configure multiple > > functions in one gadget (under one udc, in other words). > > eventually, but not until we do the ground work/housekeeping to get there. > We definitely don't want to

Re: [RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

2012-10-19 Thread Felipe Balbi
Hi, On Thu, Oct 18, 2012 at 05:12:48PM +0200, Andrzej Pietrasiewicz wrote: > Hello Felipe, > > On Wednesday, October 17, 2012 3:56 PM Felipe Balbi wrote: > > > > > On Wed, Oct 17, 2012 at 11:43:11AM +0200, Andrzej Pietrasiewicz wrote: > > > Demonstrate a USB gadget configured entirely through

RE: [RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

2012-10-18 Thread Andrzej Pietrasiewicz
Hello Felipe, On Wednesday, October 17, 2012 3:56 PM Felipe Balbi wrote: > On Wed, Oct 17, 2012 at 11:43:11AM +0200, Andrzej Pietrasiewicz wrote: > > Demonstrate a USB gadget configured entirely through configfs. > > This is a work in progress. > > > > this is wrong. we don't want *another*

Re: [RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

2012-10-17 Thread Sebastian Andrzej Siewior
On 10/17/2012 03:56 PM, Felipe Balbi wrote: --- a/drivers/usb/gadget/Makefile +++ b/drivers/usb/gadget/Makefile @@ -38,6 +38,7 @@ obj-$(CONFIG_USB_MV_U3D) += mv_u3d_core.o # # USB gadget drivers # +g_usb_functions-y := usb_functions.o this is wrong. we don't want *anothe

Re: [RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

2012-10-17 Thread Felipe Balbi
Hi, On Wed, Oct 17, 2012 at 11:43:11AM +0200, Andrzej Pietrasiewicz wrote: > Demonstrate a USB gadget configured entirely through configfs. > This is a work in progress. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park > > --- > drivers/usb/gadget/Kconfig | 12

[RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

2012-10-17 Thread Andrzej Pietrasiewicz
Demonstrate a USB gadget configured entirely through configfs. This is a work in progress. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Kconfig | 12 + drivers/usb/gadget/Makefile|2 + drivers/usb/gadget/usb_functions.c | 1204 +