Re: [RFT PATCH] xhci: handle no ping response error properly

2015-09-22 Thread Steinar H. Gunderson
On Tue, Sep 22, 2015 at 02:58:57PM +0300, Mathias Nyman wrote: > But can you find a "No Ping response error, Skip one Isoc TD" entry in the > log that didn't cause any > harm, e.g. it was not followed by a "ERROR Transfer event TRB DMA.." entry, > and continued working > > If yes, then the

Re: [RFT PATCH] xhci: handle no ping response error properly

2015-09-22 Thread Steinar H. Gunderson
On Tue, Sep 22, 2015 at 02:58:57PM +0300, Mathias Nyman wrote: > But can you find a "No Ping response error, Skip one Isoc TD" entry in the > log that didn't cause any > harm, e.g. it was not followed by a "ERROR Transfer event TRB DMA.." entry, > and continued working > > If yes, then the

Re: [RFT PATCH] xhci: handle no ping response error properly

2015-09-22 Thread Mathias Nyman
On 22.09.2015 01:14, Steinar H. Gunderson wrote: On Mon, Sep 21, 2015 at 08:25:22PM +0200, Steinar H. Gunderson wrote: I ran 4.3-rc2 with your patch applied. The problem still happens: I turned on all tracing. Maybe it will be useful. The easiest way to provoke it was seemingly to run lots of

Re: [RFT PATCH] xhci: handle no ping response error properly

2015-09-21 Thread Steinar H. Gunderson
On Mon, Sep 21, 2015 at 03:41:19PM +0300, Mathias Nyman wrote: > If a host fails to wake up a isochronous SuperSpeed device from U1/U2 > in time for a isoch transfer it will generate a "No ping response error" > Host will then move to the next transfer descriptor. > > Handle this case in the same

[RFT PATCH] xhci: handle no ping response error properly

2015-09-21 Thread Mathias Nyman
If a host fails to wake up a isochronous SuperSpeed device from U1/U2 in time for a isoch transfer it will generate a "No ping response error" Host will then move to the next transfer descriptor. Handle this case in the same way as missed service errors, tag the current TD as skipped and handle

Re: [RFT PATCH] xhci: handle no ping response error properly

2015-09-21 Thread Steinar H. Gunderson
On Mon, Sep 21, 2015 at 08:25:22PM +0200, Steinar H. Gunderson wrote: > I ran 4.3-rc2 with your patch applied. The problem still happens: I turned on all tracing. Maybe it will be useful. The easiest way to provoke it was seemingly to run lots of other stuff, and then kill my program with

Re: [RFT PATCH] xhci: handle no ping response error properly

2015-09-21 Thread Steinar H. Gunderson
On Mon, Sep 21, 2015 at 03:41:19PM +0300, Mathias Nyman wrote: > If a host fails to wake up a isochronous SuperSpeed device from U1/U2 > in time for a isoch transfer it will generate a "No ping response error" > Host will then move to the next transfer descriptor. > > Handle this case in the same