Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-02 Thread Bjørn Mork
Felipe Balbi writes: > On Thu, Nov 01, 2012 at 11:06:58AM -0400, David Miller wrote: >> From: Bjørn Mork >> Date: Thu, 01 Nov 2012 14:38:29 +0100 >> >> > Felipe Balbi writes: >> > >> >> btw, only alpha and x86 seem to be providing all of those, but if you >> >> look into our documentation, it'

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-02 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 04:47:14PM +0300, Max Filippov wrote: > On Thu, Nov 1, 2012 at 5:23 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote: > >> On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: > >> > On Thu, Nov 01, 2012 at 12:33:

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-02 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 11:06:58AM -0400, David Miller wrote: > From: Bjørn Mork > Date: Thu, 01 Nov 2012 14:38:29 +0100 > > > Felipe Balbi writes: > > > >> btw, only alpha and x86 seem to be providing all of those, but if you > >> look into our documentation, it's said that drivers are su

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread James Bottomley
On Thu, 2012-11-01 at 06:04 -0700, Greg KH wrote: > On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: > > On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote: > > > > tree: git://git.ker

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread David Miller
From: Max Filippov Date: Thu, 1 Nov 2012 16:47:14 +0300 > Strange, AFAICS architectures that use asm-generic/io.h (blackfin, openrisc, > score, unicore32 and xtensa) also provide those functions. They define HAVE_IOMEM, s390 does not, therefore you must protect the driver Kconfig with HAVE_IOMEM

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread David Miller
From: Bjørn Mork Date: Thu, 01 Nov 2012 14:38:29 +0100 > Felipe Balbi writes: > >> btw, only alpha and x86 seem to be providing all of those, but if you >> look into our documentation, it's said that drivers are supposed to use >> write/read{b,w,l,q} for all memory-mapped io. I'd expect all pla

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Fengguang Wu
On Thu, Nov 01, 2012 at 04:47:14PM +0300, Max Filippov wrote: > On Thu, Nov 1, 2012 at 5:23 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote: > >> On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: > >> > On Thu, Nov 01, 2012 at 12:33:39PM

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Max Filippov
On Thu, Nov 1, 2012 at 5:23 PM, Felipe Balbi wrote: > Hi, > > On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote: >> On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: >> > On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote: >> > > Hi, >> > > >> > > On Thu, Nov 01, 2012 a

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Bjørn Mork
Felipe Balbi writes: > btw, only alpha and x86 seem to be providing all of those, but if you > look into our documentation, it's said that drivers are supposed to use > write/read{b,w,l,q} for all memory-mapped io. I'd expect all platforms > to provide those even if just to allow compilation of d

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote: > On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: > > On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote: > > > > tree: g

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Greg KH
On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: > On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote: > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv > > > hea

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Felipe Balbi
On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote: > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv > > head: 1789e52acc90c87484a109d6349eefe63cabb257 > > commit: 1789e52acc90c874

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv > head: 1789e52acc90c87484a109d6349eefe63cabb257 > commit: 1789e52acc90c87484a109d6349eefe63cabb257 [3/3] usb: phy: add R-Car > USB phy driver > con

[balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv head: 1789e52acc90c87484a109d6349eefe63cabb257 commit: 1789e52acc90c87484a109d6349eefe63cabb257 [3/3] usb: phy: add R-Car USB phy driver config: make ARCH=cris allyesconfig All error/warnings: drivers/usb/phy/rcar-phy.c: