RE: [PATCH net-next v2] r8152: reduce the number of Tx

2014-08-31 Thread Hayes Wang
From: David Miller [mailto:da...@davemloft.net] [...] This driver has a loop that iterates MAX_TX times to initialize both the RX and TX buffers. So if they are not equal, it can't possibly work. Excuse me. I don't find that the RTL8152_MAX_TX is used by rx buffer. The rx buffer only use

Re: [PATCH net-next v2] r8152: reduce the number of Tx

2014-08-31 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 1 Sep 2014 02:46:38 + From: David Miller [mailto:da...@davemloft.net] [...] This driver has a loop that iterates MAX_TX times to initialize both the RX and TX buffers. So if they are not equal, it can't possibly work. Excuse me. I

Re: [PATCH net-next v2] r8152: reduce the number of Tx

2014-08-29 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 28 Aug 2014 10:24:18 +0800 Because the Tx has the features of stopping queue and aggregation, We don't need many tx buffers. Change the tx number from 10 to 4 to reduce the usage of the memory. This could save 16K * 6 bytes memory.