RE: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-02-03 Thread Alan Stern
On Tue, 3 Feb 2015, Peter Chen wrote: How i386 platform chooses which driver is suitable for device? The ehci_pci_init may overwrite what ci_hdrc_host_init does if it runs later? There's nothing special about the i386 platform. _All_ platforms that support PCI use the same

RE: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-02-02 Thread Peter Chen
How i386 platform chooses which driver is suitable for device? The ehci_pci_init may overwrite what ci_hdrc_host_init does if it runs later? There's nothing special about the i386 platform. _All_ platforms that support PCI use the same matching code to select drivers. (This is

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-02-02 Thread Alan Stern
On Mon, 2 Feb 2015, Peter Chen wrote: Let's look v2 patch, it bypasses probe at ehci-pci.c, then why ehci_pci_init is still needed to call? The chipidea driver has already done the same thing in ehci_pci_init. You're right; ehci_pci_init isn't needed. But there's no way to

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-02-01 Thread Peter Chen
On Fri, Jan 30, 2015 at 10:49 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 30 Jan 2015, Peter Chen wrote: The chipidea driver is structured in an odd way. It looks like the PCI device combines a host controller and a device controller (and maybe even an OTG controller) into a

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-30 Thread Alan Stern
On Fri, 30 Jan 2015, Peter Chen wrote: The chipidea driver is structured in an odd way. It looks like the PCI device combines a host controller and a device controller (and maybe even an OTG controller) into a single device. Any problems for that? No, but it is odd and it requires

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-29 Thread Alan Stern
On Thu, 29 Jan 2015, Peter Chen wrote: Then, it is strange. Do we need even two glue layer drivers for pci device? Look at usb/chipidea/ci_hdrc_pci.c it has pci_register_driver, and its host driver will call ehci_init_driver, it is definitely duplicated with usb/host/ehci-pci.c.

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-29 Thread Peter Chen
On Thu, Jan 29, 2015 at 10:44:48AM -0500, Alan Stern wrote: On Thu, 29 Jan 2015, Peter Chen wrote: Then, it is strange. Do we need even two glue layer drivers for pci device? Look at usb/chipidea/ci_hdrc_pci.c it has pci_register_driver, and its host driver will call

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Tue, Jan 27, 2015 at 11:21:56AM -0500, Alan Stern wrote: On Tue, 27 Jan 2015, Peter Chen wrote: Please fix this properly. I don't know the right way to fix this. Alan, has you any suggestion? It depends. How did the code

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Alan Stern
On Wed, 28 Jan 2015, Peter Chen wrote: Hi Andy, Would you define pci_id at ci_hdrc_pci.c (instead of ehci-pci.c) at your platform code/table to fix this problem? I am not familiar with pci, but it works at other platforms, like ARM. You can't remove the definition of pci_id in

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Peter Chen
On Wed, Jan 28, 2015 at 10:42:53AM -0500, Alan Stern wrote: On Wed, 28 Jan 2015, Peter Chen wrote: Hi Andy, Would you define pci_id at ci_hdrc_pci.c (instead of ehci-pci.c) at your platform code/table to fix this problem? I am not familiar with pci, but it works at other

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-27 Thread Alan Stern
On Tue, 27 Jan 2015, Peter Chen wrote: Please fix this properly. I don't know the right way to fix this. Alan, has you any suggestion? It depends. How did the code before the adfa79d1c06a commit avoid this problem? By simply not enabling CONFIG_USB_EHCI_HCD? Hi Andy,

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-27 Thread Alan Stern
On Tue, 27 Jan 2015, Andy Shevchenko wrote: On Tue, 2015-01-27 at 11:21 -0500, Alan Stern wrote: On Tue, 27 Jan 2015, Peter Chen wrote: Please fix this properly. I don't know the right way to fix this. Alan, has you any suggestion? It depends. How did the code

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-27 Thread Peter Chen
On Tue, Jan 27, 2015 at 11:21:56AM -0500, Alan Stern wrote: On Tue, 27 Jan 2015, Peter Chen wrote: Please fix this properly. I don't know the right way to fix this. Alan, has you any suggestion? It depends. How did the code before the adfa79d1c06a commit avoid this

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-26 Thread Greg KH
On Mon, Jan 26, 2015 at 07:10:42PM +0200, Andy Shevchenko wrote: On some Intel MID platforms the ChipIdea USB controller is used. The EHCI PCI is in conflict with the proper driver. The patch makes a quick fix to get Intel Medfield platforms work back. One would make a proper patch to

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-26 Thread Andy Shevchenko
On Mon, 2015-01-26 at 09:21 -0800, Greg KH wrote: On Mon, Jan 26, 2015 at 07:10:42PM +0200, Andy Shevchenko wrote: On some Intel MID platforms the ChipIdea USB controller is used. The EHCI PCI is in conflict with the proper driver. The patch makes a quick fix to get Intel Medfield

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-26 Thread Alan Stern
On Mon, 26 Jan 2015, Andy Shevchenko wrote: On Mon, 2015-01-26 at 09:21 -0800, Greg KH wrote: On Mon, Jan 26, 2015 at 07:10:42PM +0200, Andy Shevchenko wrote: On some Intel MID platforms the ChipIdea USB controller is used. The EHCI PCI is in conflict with the proper driver. The

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-26 Thread Peter Chen
On Mon, Jan 26, 2015 at 01:23:47PM -0500, Alan Stern wrote: On Mon, 26 Jan 2015, Andy Shevchenko wrote: On Mon, 2015-01-26 at 09:21 -0800, Greg KH wrote: On Mon, Jan 26, 2015 at 07:10:42PM +0200, Andy Shevchenko wrote: On some Intel MID platforms the ChipIdea USB controller is used.