Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Greg KH
On Mon, Jun 06, 2016 at 05:24:57PM +, mario_limoncie...@dell.com wrote: > That said, I would be highly surprised if Realtek decided to implement > with another OEM differently. It would increase their code complexity > on Windows as well since this is part of the generic driver. Ah, it's refr

RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Mario_Limonciello
> > Realtek has this in their Windows driver that all OEM's will be taking. > > Another OEM would just need to burn the right information into the SPI at > > manufacturing and expose it to the DSDT. > > Where it the match up for the Realtek bit to corrispond with this > specific ACPI field? If it

Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Greg KH
LKML ; Netdev > > ; Linux USB ; > > pali.ro...@gmail.com; anthony.w...@canonical.com > > Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC > > address on RTL8153-AD > > > > On Mon, Jun 06, 2016 at 09:15:21AM -0500, Mario Limonciello wrote: >

RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Mario_Limonciello
: Re: [PATCH v3] r8152: Add support for setting pass through MAC > address on RTL8153-AD > > > + /* returns _AUXMAC_#AABBCCDDEEFF# */ > > + status = acpi_evaluate_object(NULL, "\\_SB.AMAC", NULL, &buffer); > > + obj = (union acpi_object *)buffer.pointer;

RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Mario_Limonciello
H v3] r8152: Add support for setting pass through MAC > address on RTL8153-AD > > On Mon, Jun 06, 2016 at 09:15:21AM -0500, Mario Limonciello wrote: > > The RTL8153-AD supports a persistent system specific MAC address. > > This means a device plugged into two different

RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Mario_Limonciello
l.com; > anthony.w...@canonical.com > Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC > address on RTL8153-AD > > On Mon, Jun 06, 2016 at 02:43:37PM +, mario_limoncie...@dell.com > wrote: > > > -Original Message- > > > From: Greg KH

Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Greg KH
LKML ; Netdev > > ; Linux USB ; > > pali.ro...@gmail.com; anthony.w...@canonical.com > > Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC > > address on RTL8153-AD > > > > On Mon, Jun 06, 2016 at 09:15:20AM -0500, Mario Limonciello wrote: > >

RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Mario_Limonciello
H v3] r8152: Add support for setting pass through MAC > address on RTL8153-AD > > On Mon, Jun 06, 2016 at 09:15:20AM -0500, Mario Limonciello wrote: > > Since this is a Realtek feature, I feel this shouldn't be moved into a > > platform > > MAC address lookup.

Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Andrew Lunn
> + /* returns _AUXMAC_#AABBCCDDEEFF# */ > + status = acpi_evaluate_object(NULL, "\\_SB.AMAC", NULL, &buffer); > + obj = (union acpi_object *)buffer.pointer; > + if (ACPI_SUCCESS(status)) { > + if (obj->type != ACPI_TYPE_BUFFER || > + obj->string.length !

Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Greg KH
On Mon, Jun 06, 2016 at 09:15:21AM -0500, Mario Limonciello wrote: > The RTL8153-AD supports a persistent system specific MAC address. > This means a device plugged into two different systems with host side > support will show different (but persistent) MAC addresses. > > This information for the

Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Greg KH
On Mon, Jun 06, 2016 at 09:15:20AM -0500, Mario Limonciello wrote: > Since this is a Realtek feature, I feel this shouldn't be moved into a > platform > MAC address lookup. The code should only be run when the correct Realtek > device > is plugged in. > > Changes from v2: > * Only apply to RTL