RE: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-27 Thread Jun Li
n...@freescale.com; > mathias.ny...@linux.intel.com; t...@atomide.com; joao.pi...@synopsys.com; > abres...@chromium.org; r.bald...@samsung.com; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org; linux-o...@vger.kernel.org > Subject: RE: [PATCH v6 08/12] usb: hcd: Adapt to OTG core >

RE: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-27 Thread Jun Li
n...@freescale.com; > mathias.ny...@linux.intel.com; t...@atomide.com; joao.pi...@synopsys.com; > abres...@chromium.org; r.bald...@samsung.com; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org; linux-o...@vger.kernel.org > Subject: Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core > &

Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-27 Thread Roger Quadros
On 27/04/16 14:00, Roger Quadros wrote: > On 27/04/16 13:16, Jun Li wrote: >> Hi >> >>> >>> + >>> +static struct otg_hcd_ops otg_hcd_intf = { >>> + .add = usb_add_hcd, >>> + .remove = usb_remove_hcd, >>> + .usb_bus_start_enum = usb_bus_start_enum, >> >> Build break if CONFIG_USB_OTG is not en

Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-27 Thread Roger Quadros
On 27/04/16 13:16, Jun Li wrote: > Hi > >> >> + >> +static struct otg_hcd_ops otg_hcd_intf = { >> +.add = usb_add_hcd, >> +.remove = usb_remove_hcd, >> +.usb_bus_start_enum = usb_bus_start_enum, > > Build break if CONFIG_USB_OTG is not enabled: > > drivers/built-in.o:(.data+0x1db30):

RE: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-27 Thread Jun Li
Hi > > + > +static struct otg_hcd_ops otg_hcd_intf = { > + .add = usb_add_hcd, > + .remove = usb_remove_hcd, > + .usb_bus_start_enum = usb_bus_start_enum, Build break if CONFIG_USB_OTG is not enabled: drivers/built-in.o:(.data+0x1db30): undefined reference to `usb_bus_start_enum' Ma

Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-19 Thread Roger Quadros
On 19/04/16 11:14, Peter Chen wrote: > On Mon, Apr 18, 2016 at 02:29:37PM +0800, Peter Chen wrote: >> On Tue, Apr 05, 2016 at 05:05:13PM +0300, Roger Quadros wrote: >>> Introduce usb_otg_add/remove_hcd() for use by host >>> controllers that are part of OTG/dual-role port. >>> >>> Non Device tree pl

Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-19 Thread Roger Quadros
On 18/04/16 09:29, Peter Chen wrote: > On Tue, Apr 05, 2016 at 05:05:13PM +0300, Roger Quadros wrote: >> Introduce usb_otg_add/remove_hcd() for use by host >> controllers that are part of OTG/dual-role port. >> >> Non Device tree platforms can use the otg_dev argument >> to specify the OTG controll

Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-19 Thread Peter Chen
On Mon, Apr 18, 2016 at 02:29:37PM +0800, Peter Chen wrote: > On Tue, Apr 05, 2016 at 05:05:13PM +0300, Roger Quadros wrote: > > Introduce usb_otg_add/remove_hcd() for use by host > > controllers that are part of OTG/dual-role port. > > > > Non Device tree platforms can use the otg_dev argument >

Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-17 Thread Peter Chen
On Tue, Apr 05, 2016 at 05:05:13PM +0300, Roger Quadros wrote: > Introduce usb_otg_add/remove_hcd() for use by host > controllers that are part of OTG/dual-role port. > > Non Device tree platforms can use the otg_dev argument > to specify the OTG controller device. If otg_dev is NULL > then the de