Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-11-04 Thread Pratyush Anand
On Sat, Nov 02, 2013 at 04:18:05AM +0800, Paul Zimmerman wrote: From: Alan Stern Sent: Friday, November 01, 2013 7:09 AM Now DELAYED_STATUS isn't used anywhere. You should add the following hunk to this patch: Index: usb-3.12/drivers/usb/gadget/storage_common.c

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-11-01 Thread Pratyush Anand
On Thu, Oct 31, 2013 at 12:32:29AM +0800, Alan Stern wrote: On Wed, 30 Oct 2013, Alan Stern wrote: I think you have found a bug in the dwc3 driver. At this point, because the IGNORE_BULK_OUT bit is set, g_mass_storage issues a usb_ep_clear_halt() call for the bulk-in (CSW) endpoint.

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-11-01 Thread Alan Stern
On Fri, 1 Nov 2013, Pratyush Anand wrote: Tested-by: Pratyush Anand pratyush.an...@st.com Thank you. However, I noticed that the same error recovery test fails even after above patch if dwc3 dbg/vdbg messages are enabled. However, reason is not in dwc3 driver, rather in mass storage

RE: CSW endpoint status returned STALL after BOT MSC Reset

2013-11-01 Thread Paul Zimmerman
From: Alan Stern Sent: Friday, November 01, 2013 7:09 AM Now DELAYED_STATUS isn't used anywhere. You should add the following hunk to this patch: Index: usb-3.12/drivers/usb/gadget/storage_common.c === ---

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-31 Thread Pratyush Anand
Thanks for the quick patch..I will test it. On Wed, Oct 30, 2013 at 10:02 PM, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 30 Oct 2013, Alan Stern wrote: I think you have found a bug in the dwc3 driver. At this point, because the IGNORE_BULK_OUT bit is set, g_mass_storage issues a

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-31 Thread Alan Stern
On Thu, 31 Oct 2013, Pratyush Anand wrote: This is fine. But I do not see any way to unwedge ep0. dwc3_gadget_ep0_set_halt ignores *value* argument and will not handle a gadget driver's clear halt status request. However, I do no see any gadget driver wedging ep0, so may be it will not

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-30 Thread Alan Stern
On Wed, 30 Oct 2013, Pratyush Anand wrote: I am using dwc3 driver. I my case kernel version is even a bit old 3.3, but dwc3 patches are almost updated. I am using g_mass_storage. Why don't you try running an up-to-date kernel, like 3.11, instead? Yaa, I am trying to upgrade my

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-30 Thread Alan Stern
On Wed, 30 Oct 2013, Pratyush Anand wrote: I read a bit usbmassbulk specification. What I understood that, host sends a CBW (21 byte bulk out command), which should start with dCBWSignature 43425355. I see that in both pass and fail case host sends a 31 byte bulk out with signature as

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-30 Thread Pratyush Anand
Thanks a lot Alan for your help. On Wed, Oct 30, 2013 at 9:38 PM, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 30 Oct 2013, Pratyush Anand wrote: I am using dwc3 driver. I my case kernel version is even a bit old 3.3, but dwc3 patches are almost updated. I am using g_mass_storage.

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-30 Thread Alan Stern
On Wed, 30 Oct 2013, Alan Stern wrote: I think you have found a bug in the dwc3 driver. At this point, because the IGNORE_BULK_OUT bit is set, g_mass_storage issues a usb_ep_clear_halt() call for the bulk-in (CSW) endpoint. This tells the dwc3 driver to change the endpoint's status back to

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-30 Thread Felipe Balbi
hi, sorry for the delay On Wed, Oct 30, 2013 at 02:14:49PM +0530, Pratyush Anand wrote: Hi Felip, I too got this issue with my dwc3 based usb device platform. Have you ever tried to run USBCV MSC test with dwc3 + g_mass_storage? If yes, what was the result in your case. We have a copule

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-30 Thread Felipe Balbi
Hi, On Wed, Oct 30, 2013 at 12:09:32PM -0400, Alan Stern wrote: On Wed, 30 Oct 2013, Pratyush Anand wrote: I read a bit usbmassbulk specification. What I understood that, host sends a CBW (21 byte bulk out command), which should start with dCBWSignature 43425355. I see that in both

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-30 Thread Felipe Balbi
Hi, On Wed, Oct 30, 2013 at 12:32:29PM -0400, Alan Stern wrote: On Wed, 30 Oct 2013, Alan Stern wrote: I think you have found a bug in the dwc3 driver. At this point, because the IGNORE_BULK_OUT bit is set, g_mass_storage issues a usb_ep_clear_halt() call for the bulk-in (CSW)

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-30 Thread Alan Stern
On Wed, 30 Oct 2013, Felipe Balbi wrote: now that I reread documentation on set_wedge() I see that Alan's patch is correct. dwc3 should ignore CLEAR_FEATURE(HALT_ENDPOINT) from the host, but if the gadget driver directly calls clear_halt() is should succeed. And now that I look back on it, I

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-30 Thread Felipe Balbi
Hi, On Wed, Oct 30, 2013 at 03:49:20PM -0400, Alan Stern wrote: On Wed, 30 Oct 2013, Felipe Balbi wrote: now that I reread documentation on set_wedge() I see that Alan's patch is correct. dwc3 should ignore CLEAR_FEATURE(HALT_ENDPOINT) from the host, but if the gadget driver directly

Re: CSW endpoint status returned STALL after BOT MSC Reset

2013-10-28 Thread Alan Stern
Be aware that the mailing list doesn't like HTML. Plain-text only, please. On Mon, 28 Oct 2013, zouid abdelhamid wrote: Hi folks, I am testing a USB MSC, device mode, using USBCV2.0 . The device is an ARM based platform with a USB DRD that is running 3.4 kernel, the USB port is