Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-21 Thread Roger Quadros
On 01/21/2014 12:11 PM, Kishon Vijay Abraham I wrote: > Since PHYs for dwc3 is optional (not all SoCs that have DWC3 use PHYs), > do not return from probe if the USB PHY library returns -ENODEV as that > indicates the platform does not have PHY. > > Signed-off-by: Kishon Vijay Abraham I Reviewed

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-21 Thread Felipe Balbi
On Tue, Jan 21, 2014 at 03:41:38PM +0530, Kishon Vijay Abraham I wrote: > Since PHYs for dwc3 is optional (not all SoCs that have DWC3 use PHYs), > do not return from probe if the USB PHY library returns -ENODEV as that this isn't correct, they all have PHYs, some of them might not be controllable

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-24 Thread Kishon Vijay Abraham I
Hi, On Tuesday 21 January 2014 08:17 PM, Felipe Balbi wrote: > On Tue, Jan 21, 2014 at 03:41:38PM +0530, Kishon Vijay Abraham I wrote: >> Since PHYs for dwc3 is optional (not all SoCs that have DWC3 use PHYs), >> do not return from probe if the USB PHY library returns -ENODEV as that > > this isn

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-27 Thread Heikki Krogerus
Hi Felipe, On Tue, Jan 21, 2014 at 08:47:25AM -0600, Felipe Balbi wrote: > On Tue, Jan 21, 2014 at 03:41:38PM +0530, Kishon Vijay Abraham I wrote: > > Since PHYs for dwc3 is optional (not all SoCs that have DWC3 use PHYs), > > do not return from probe if the USB PHY library returns -ENODEV as that

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-27 Thread Felipe Balbi
Hi, On Mon, Jan 27, 2014 at 05:08:55PM +0200, Heikki Krogerus wrote: > > > Since PHYs for dwc3 is optional (not all SoCs that have DWC3 use PHYs), > > > do not return from probe if the USB PHY library returns -ENODEV as that > > > > this isn't correct, they all have PHYs, some of them might not b

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-28 Thread Heikki Krogerus
Hi, On Mon, Jan 27, 2014 at 10:05:20AM -0600, Felipe Balbi wrote: > > Why would you need to know if the PHY drivers are needed or not > > explicitly in your controller driver? > > because, one way or another, they all do need it. Except for quirky ones > like AM437x where a USB3 IP was hardwired

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-28 Thread Felipe Balbi
Hi, On Tue, Jan 28, 2014 at 05:32:30PM +0200, Heikki Krogerus wrote: > On Mon, Jan 27, 2014 at 10:05:20AM -0600, Felipe Balbi wrote: > > > Why would you need to know if the PHY drivers are needed or not > > > explicitly in your controller driver? > > > > because, one way or another, they all do n

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-29 Thread Heikki Krogerus
Hi, On Tue, Jan 28, 2014 at 10:30:36AM -0600, Felipe Balbi wrote: > On Tue, Jan 28, 2014 at 05:32:30PM +0200, Heikki Krogerus wrote: > > On Mon, Jan 27, 2014 at 10:05:20AM -0600, Felipe Balbi wrote: > > For the controller drivers the PHYs are just a resource like any > > other. The controller driv

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-12 Thread Kishon Vijay Abraham I
On Wednesday 29 January 2014 08:17 PM, Heikki Krogerus wrote: > Hi, > > On Tue, Jan 28, 2014 at 10:30:36AM -0600, Felipe Balbi wrote: >> On Tue, Jan 28, 2014 at 05:32:30PM +0200, Heikki Krogerus wrote: >>> On Mon, Jan 27, 2014 at 10:05:20AM -0600, Felipe Balbi wrote: >>> For the controller drivers

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-19 Thread Roger Quadros
Hi, On 02/12/2014 11:46 AM, Kishon Vijay Abraham I wrote: > On Wednesday 29 January 2014 08:17 PM, Heikki Krogerus wrote: >> Hi, >> >> On Tue, Jan 28, 2014 at 10:30:36AM -0600, Felipe Balbi wrote: >>> On Tue, Jan 28, 2014 at 05:32:30PM +0200, Heikki Krogerus wrote: On Mon, Jan 27, 2014 at 10:

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-21 Thread Kishon Vijay Abraham I
Hi Roger, On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: > Hi, > > On 02/12/2014 11:46 AM, Kishon Vijay Abraham I wrote: >> On Wednesday 29 January 2014 08:17 PM, Heikki Krogerus wrote: >>> Hi, >>> >>> On Tue, Jan 28, 2014 at 10:30:36AM -0600, Felipe Balbi wrote: On Tue, Jan 28

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-21 Thread Roger Quadros
On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: >> Hi, >> >> On 02/12/2014 11:46 AM, Kishon Vijay Abraham I wrote: >>> On Wednesday 29 January 2014 08:17 PM, Heikki Krogerus wrote: Hi, On Tue, Jan 28,

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Kishon Vijay Abraham I
Hi Roger, On Friday 21 February 2014 05:59 PM, Roger Quadros wrote: > On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: >> Hi Roger, >> >> On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: >>> Hi, >>> >>> On 02/12/2014 11:46 AM, Kishon Vijay Abraham I wrote: On Wednesday 29 Jan

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Kishon Vijay Abraham I
On Friday 21 February 2014 05:59 PM, Roger Quadros wrote: > On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: >> Hi Roger, >> >> On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: >>> Hi, >>> >>> On 02/12/2014 11:46 AM, Kishon Vijay Abraham I wrote: On Wednesday 29 January 2014 0

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Roger Quadros
On 02/24/2014 11:51 AM, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Friday 21 February 2014 05:59 PM, Roger Quadros wrote: >> On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: >>> Hi Roger, >>> >>> On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: Hi, On 02/12/20

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Kishon Vijay Abraham I
Hi, On Monday 24 February 2014 04:35 PM, Roger Quadros wrote: > On 02/24/2014 11:51 AM, Kishon Vijay Abraham I wrote: >> Hi Roger, >> >> On Friday 21 February 2014 05:59 PM, Roger Quadros wrote: >>> On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: Hi Roger, On Wednesday 19 Febr

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Felipe Balbi
On Mon, Feb 24, 2014 at 03:21:05PM +0530, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Friday 21 February 2014 05:59 PM, Roger Quadros wrote: > > On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: > >> Hi Roger, > >> > >> On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: > >>> Hi