removing the timer from cdc-ncm

2012-09-21 Thread Oliver Neukum
Hi, here is the patch that does everything I consider theoretically necessary to have bundling of frames in usbnet and adapting cdc-ncm to it. I'd appreciate any review in case I am doing something stupid. Regards Oliver diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/n

RE: removing the timer from cdc-ncm

2012-09-24 Thread Alexey ORISHKO
> -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.de] > Sent: Friday, September 21, 2012 10:35 AM > To: Alexey ORISHKO; bj...@mork.no; net...@vger.kernel.org; linux- > u...@vger.kernel.org > Subject: removing the timer from cdc-ncm > > Hi, > &g

Re: removing the timer from cdc-ncm

2012-09-24 Thread Oliver Neukum
On Monday 24 September 2012 14:13:50 Alexey ORISHKO wrote: > I've tried to apply it, but always got a message that "patch does not apply". > What is the base for this patch? Greg KH's tree, specifically commit 6dab7ede9390d4d937cb89feca932e4fd575d2da HTH Oliver -- To uns

RE: removing the timer from cdc-ncm

2012-09-25 Thread Alexey ORISHKO
> -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.de] > > here is the patch that does everything I consider theoretically > necessary to have bundling of frames in usbnet and adapting cdc-ncm to > it. > > I'd appreciate any review in case I am doing something stupid. > I h

Re: removing the timer from cdc-ncm

2012-09-26 Thread Oliver Neukum
On Tuesday 25 September 2012 13:18:10 Alexey ORISHKO wrote: > > -Original Message- > > From: Oliver Neukum [mailto:oneu...@suse.de] > > > > here is the patch that does everything I consider theoretically > > necessary to have bundling of frames in usbnet and adapting cdc-ncm to > > it. > >

RE: removing the timer from cdc-ncm

2012-09-26 Thread Alexey ORISHKO
> -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.de] > Thank you. Worse than I hoped, but not unexpected. I'll stare at the > code a bit. Just a small clarification: on Ellisys trace I see only ConnectionSpeedChange and NetworkConnection (Connected). No data was sent on th

Re: removing the timer from cdc-ncm

2012-10-11 Thread Bjørn Mork
Oliver Neukum writes: > On Tuesday 25 September 2012 13:18:10 Alexey ORISHKO wrote: > >> Linux host got panic right after data path has been established >> (i.e. connected to mobile network). > > Thank you. Worse than I hoped, but not unexpected. I'll stare at the > code a bit. I had the same ex

Re: removing the timer from cdc-ncm

2012-10-11 Thread Bjørn Mork
Bjørn Mork writes: > [48880.048494] BUG: unable to handle kernel NULL pointer dereference at > 0068 > [48880.048573] IP: [] cdc_ncm_tx_bundle+0x168/0x43b > [cdc_ncm] This one is because you removed the "if (skb == NULL)" from the for loop, but left the "skb = NULL;" at the end: @