Re: ohci-pci controller won't resume and HC died; cleaning up - only on shutdown/reboot

On Mon, 8 Aug 2016, ican realizeum wrote: > >> The caller was hcd_resume_work(), which is part of a workqueue. This > >> routine runs when the OHCI driver calls usb_hcd_resume_root_hub(). > >> There are only 3 places in the driver where this happens (two in > >> ohci-hcd.c and one in

[PACTH v2] cdc-wdm: Clear read pipeline in case of error

From: Robert Foss Implemented queued response handling. This queue is processed every time the WDM_READ flag is cleared. In case of a read error, userspace may not actually read the data, since the driver returns an error through wdm_poll. After this, the underlying

Re: [PATCH RESEND] xhci:Remove unused marco definitions from the file xhci-hub.c

On Mon, Aug 08, 2016 at 12:00:38PM -0400, Nicholas Krause wrote: > This removes the unneeded marco definitions for the marcos > of XHCI_PORT_RW1S, XHCI_PORT_RW1C, XHCI_PORT_RWand > XHCI_PORT_RZ due to no uses of these marcos in the file > xhci-hub.c or any other related kernel source code

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

On 2016-08-07 04:59 AM, Oliver Neukum wrote: On Thu, 2016-08-04 at 13:44 -0400, Robert Foss wrote: On 2016-08-03 06:39 AM, Oliver Neukum wrote: On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote: How can that depend on what we return to user space? In the driver we can continue just

Re: ohci-pci controller won't resume and HC died; cleaning up - only on shutdown/reboot

On Mon, Aug 8, 2016 at 5:38 PM, Alan Stern wrote: > On Mon, 8 Aug 2016, ican realizeum wrote: > >> >> The caller was hcd_resume_work(), which is part of a workqueue. This >> >> routine runs when the OHCI driver calls usb_hcd_resume_root_hub(). >> >> There are only 3

Re: [PATCH v3 2/9] usb: gadget: align buffer size when allocating for OUT endpoint

Hi, On 05-08-2016 20:15, kbuild test robot wrote: > Hi Felipe, > > [auto build test ERROR on balbi-usb/next] > [also build test ERROR on v4.7 next-20160805] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: >

Re: ohci-pci controller won't resume and HC died; cleaning up - only on shutdown/reboot

On Mon, Aug 8, 2016 at 7:43 PM, ican realizeum wrote: > On Mon, Aug 8, 2016 at 5:38 PM, Alan Stern wrote: >> On Mon, 8 Aug 2016, ican realizeum wrote: >> >>> >> The caller was hcd_resume_work(), which is part of a workqueue. This >>> >>

Re: ohci-pci controller won't resume and HC died; cleaning up - only on shutdown/reboot

On Mon, 8 Aug 2016, ican realizeum wrote: > Ok, here's what I found out: > tlp being enabled in /etc/default/tlp (as TLP_ENABLE=1) would always > set those to 'auto' aka they show up as 'suspended', regardless of > what I did (eg. set them 'on') before executing shutdown(from X, in > menu,

Re: ohci-pci controller won't resume and HC died; cleaning up - only on shutdown/reboot

On Mon, Aug 8, 2016 at 11:01 PM, Alan Stern wrote: > On Mon, 8 Aug 2016, ican realizeum wrote: > >> >> 1. if I have line in debug.sh which attempts to poweroff manually via >> >> sysrq, like this: >> >> echo o > /proc/sysrq-trigger ; sleep 5 >> >> then, there are no

Re: ohci-pci controller won't resume and HC died; cleaning up - only on shutdown/reboot

On Mon, Aug 8, 2016 at 8:41 PM, Alan Stern wrote: > On Mon, 8 Aug 2016, ican realizeum wrote: > >> Ok, here's what I found out: >> tlp being enabled in /etc/default/tlp (as TLP_ENABLE=1) would always >> set those to 'auto' aka they show up as 'suspended', regardless of

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

Oliver Neukum writes: > But why fix similar issues at two different places? And what about > PCI or other cards that show the same problem? I guess some sort of common helper would be nice to avoid open coding this fix everywhere. But you would still have to modify every

[PATCH v4 07/10] usb: gadget: f_midi: drop substreams when disabling endpoint

This change makes sure that the ALSA buffers are cleaned if an endpoint becomes disabled. Before this change, if the internal ALSA buffer did overflow, the MIDI function would stop sending MIDI to the host. Signed-off-by: Felipe F. Tonello ---

[PATCH v4 09/10] usb: gadget: f_hid: use free_ep_req()

We should always use free_ep_req() when allocating requests with alloc_ep_req(). Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_hid.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c

[PATCH v4 08/10] usb: gadget: remove useless parameter in alloc_ep_req()

The default_length parameter of alloc_ep_req was not really necessary and gadget drivers would almost always create an inline function to pass the same value to len and default_len. So this patch also removes duplicate code from few drivers. Signed-off-by: Felipe F. Tonello

[PATCH v4 05/10] usb: gadget: f_midi: defaults buflen sizes to 512

512 is the value used by wMaxPacketSize, as specified by the USB Spec. This makes sure this driver uses, by default, the most optimal value for IN and OUT endpoint requests. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 2 +-

[PATCH v4 02/10] usb: gadget: change len to size_t on alloc_ep_req()

Length of buffers should be of type size_t whenever possible. Altough recommended, this change has no real practical change, unless a driver has a uses a huge or negative buffer size - it might help find these bugs. Signed-off-by: Felipe F. Tonello ---

[PATCH v4 03/10] usb: gadget: align buffer size when allocating for OUT endpoint

Using usb_ep_align() makes sure that the buffer size for OUT endpoints is always aligned with wMaxPacketSize (512 usually). This makes sure that no buffer has the wrong size, which can cause nasty bugs. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/u_f.c | 3

[PATCH v4 01/10] usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_align

USB spec specifies wMaxPacketSize to be little endian (as other properties), so when using this variable in the driver we should convert to the current CPU endianness if necessary. This patch also introduces usb_ep_align() which does always returns the aligned buffer size for an endpoint. This is

[PATCH v4 04/10] usb: gadget: f_midi: remove alignment code for OUT endpoint

The new version of alloc_ep_req() already aligns the buffer size to wMaxPacketSize on OUT endpoints. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v4 00/10] Gadget endpoint request allocation and MIDI

As discussed with Baolin Wang, Michal Nazarewicz and Felipe Balbi. I propose the forced buffer alignment of OUT endpoints USB requests. This is implemented by patches #1 and #3. That not just simplifies the driver code, but it also prevents nasty bugs when buflen is not aligned or even less than

[PACTH v3 2/2] usb: xhci: plat: Enable async suspend/resume

From: Andrew Bresticker USB host controllers can take a significant amount of time to suspend and resume, adding several hundred miliseconds to the kernel resume time. Since the XHCI controller has no outside dependencies (other than clocks, which are suspended

[PACTH v3 0/2] usb: xhci: plat: Enable PM, async resume/suspend

From: Robert Foss This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. This is a resumbmission of v3. Changes since v1: - Added Signed-off-by: Robert Foss - Added proper metadata tags to series.

[PATCH v4 06/10] usb: gadget: f_midi: refactor state machine

This refactor results in a cleaner state machine code and promotes consistency, readability, and maintanability of this driver. This refactor state machine was well tested and it is currently running in production code and devices. Signed-off-by: Felipe F. Tonello ---

[PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req()

Use gadget's framework allocation function instead of directly calling usb_ep_alloc_request(). Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_hid.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PACTH v3 1/2] usb: xhci: plat: Enable runtime PM

From: Andrew Bresticker Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss

Re: ohci-pci controller won't resume and HC died; cleaning up - only on shutdown/reboot

On Mon, 8 Aug 2016, ican realizeum wrote: > >> 1. if I have line in debug.sh which attempts to poweroff manually via > >> sysrq, like this: > >> echo o > /proc/sysrq-trigger ; sleep 5 > >> then, there are no 'controller won't resume' and no 'HC died' > >> messages, but there are only those with

[PATCH resend 0/1] phy-sun4i-usb: Add support for peripheral-only mode

Hi Kishon, As discussed before, here is a resend now that rc1 is out (and includes the new of_usb_get_dr_mode_by_phy helper this patch needs). Please merge this for 4.9-rcX some of the musb-sunxi glue changes already merged have a runtime dependency on this patch, without this patch boards using

[PATCH resend] phy-sun4i-usb: Add support for peripheral-only mode

Use the new of_usb_get_dr_mode_by_phy() function to get the dr_mode from the musb controller node instead of assuming that having an id_det gpio means otg mode, and not having one means host mode. Implement peripheral-only mode by adding a sun4i_usb_phy0_get_id_det helper which looks at the

Re: [PATCH] scsi: introduce a quirk for false cache reporting

> "Oliver" == Oliver Neukum writes: Oliver> Some SATA to USB bridges fail to cooperate with some drives Oliver> resulting in no cache being present being reported to the Oliver> host. That causes the host to skip sending a command to Oliver> synchronize caches. That causes

[no subject]

unsubscsribe -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()

>Quoting Peter Chen (2016-08-06 00:54:35) >> On Fri, Aug 05, 2016 at 02:53:56PM -0700, Stephen Boyd wrote: >> > Quoting Peter Chen (2016-07-08 02:45:28) >> > > On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote: >> > > > We don't call hw_device_reset() with the ci->lock held, so it >> >

[RESEND PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE

From: Yonglong Wu According to USB30 specification, the Function Remote Wakeup field can be modified by the SetFeature() requests. SetFeature() is recommended to use. Signed-off-by: Yonglong Wu --- drivers/usb/core/hub.c |2 +- 1 file

Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

On Fri, 5 Aug 2016 23:21:35 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160805 08:35]: > > I repeat the subject line of the patch: > > [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() > > It is *not* fix charging. > > > > So you

Re: [PATCH v5 2/6] power: add power sequence library

El Mon, Aug 08, 2016 at 04:52:07PM +0800 Peter Chen ha dit: > We have an well-known problem that the device needs to do some power > sequence before it can be recognized by related host, the typical > example like hard-wired mmc devices and usb devices. > > This power sequence is hard to be

[PATCH 1/1] usb: misc: usbtest: add fix for driver hang

In sg_timeout(), req->status is set to "-ETIMEDOUT" before calling into usb_sg_cancel(). usb_sg_cancel() will do nothing and return directly if req->status has been set to a non-zero value. This will cause driver hang as soon as transfer time out is triggered. In my test case, below system log

[PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE

From: Yonglong Wu According to USB30 specification, the Function Remote Wakeup field can be modified by the SetFeature() requests. SetFeature() is recommended to use. Change-Id: Ie744b95f12d7d21d9519e77ed706c8cc33fa Signed-off-by: Yonglong Wu

Re: creating a virtual usb device from user-space

On Sun, Aug 07, 2016 at 06:55:36PM +0200, stéphane bryant wrote: > Hi > > We are working on a project where a user-space application (a device > emulator) creates a USB device on the host machine (thus allowing the > emulated device to emulate a USB slave and to act as a usb dongle on the > host

Re: ohci-pci controller won't resume and HC died; cleaning up - only on shutdown/reboot

Sorry, I just realized that in gmail `Default reply behaviour` was set to `Reply` not `Reply All`, so I skipped the list when I replied last(for I forgot to select Reply All as I did before). Oops. So now hopefully everyone else can see the quoted previous email below. On Mon, Aug 8, 2016 at 4:35

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Sun, 2016-08-07 at 23:37 +0200, Pavel Machek wrote: > Hi! > > > > With these boards, you will not see anything on the screen that is > > > attached to a Type-C connector until the OS has booted to the point > > > where it has negotiated the power contract and entered a mode. > > > > > > If

[PATCH 0/3] usb: renesas_usbhs: fix the driver for v4.8

This patch set is based on the latest Felipe's usb.git / testing/fixes branch. (The commit id = 10493a3c0718 ("usb: dwc3: gadget: increment request->actual once") Yoshihiro Shimoda (3): usb: renesas_usbhs: Fix receiving data corrupt on R-Car Gen3 with dmac usb: renesas_usbhs: clear the

Re: [PATCH v3] cdc-wdm: fix "out-of-sync" due to missing notifications

On Mon, Aug 08, 2016 at 02:12:06PM +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > On Sun, 2016-07-10 at 17:45 +0200, Bjørn Mork wrote: > >> The workaround has been tested on a large number of different MBIM > >> and QMI devices, as well as the Ericsson F5521gw and H5321gw

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

Oliver Neukum writes: > On Mon, 2016-07-18 at 16:10 +0200, Kristian Evensen wrote: >> On Mon, Jul 18, 2016 at 3:50 PM, Oliver Neukum wrote: >> > No, you misunderstand me. I don't want quirks if we can avoid it. >> > But if you need to do this for rndis_host

[PATCH 1/3] usb: renesas_usbhs: Fix receiving data corrupt on R-Car Gen3 with dmac

Since R-Car Gen3 SoC has the USB-DMAC, this driver should set dparam->has_usb_dmac to 1. Otherwise, behavior of this driver and the usb-dmac driver will be mismatch, then sometimes receiving data will be corrupt. Fixes: de18757e272d ("usb: renesas_usbhs: add R-Car Gen3 power control") Cc:

[PATCH 2/3] usb: renesas_usbhs: clear the BRDYSTS in usbhsg_ep_enable()

This patch fixes an issue that unexpected BRDY interruption happens when the usb_ep_{enable,disable}() are called with different direction. In this case, the driver will cause the following message: renesas_usbhs e659.usb: irq_ready run_error 1 : -16 This issue causes the followings: 1) A

[PATCH 3/3] usb: renesas_usbhs: Use dmac only if the pipe type is bulk

This patch fixes an issue that isochronous transfer's data is possible to be lost as a workaround. Since this driver uses a workqueue to start the dmac, the transfer is possible to be delayed when system load is high. Fixes: 6e4b74e4690d ("usb: renesas: fix scheduling in atomic context bug") Cc:

Re: ohci-pci controller won't resume and HC died; cleaning up - only on shutdown/reboot

On Mon, Aug 8, 2016 at 11:42 AM, ican realizeum wrote: > Sorry, I just realized that in gmail `Default reply behaviour` was set > to `Reply` not `Reply All`, so I skipped the list when I replied > last(for I forgot to select Reply All as I did before). Oops. So now >

Re: [PATCH v3,4/5] usb: Add MediaTek USB3 DRD Driver

On Fri, Jun 10, 2016 at 03:32:41PM +0800, Chunfeng Yun wrote: > --- /dev/null > +++ b/drivers/usb/mtu3/Makefile > @@ -0,0 +1,20 @@ > + > +#ifeq ($(CONFIG_USB_DEBUG),y) > + ccflags-y += -DDEBUG > +#endif There is no CONFIG_USB_DEBUG in the tree anymore, are you sure you tested this? :)

Re: [PATCH] USB: serial: fix memleak on error path in usb-serial

On Mon, Aug 08, 2016 at 02:34:46AM +0100, Alexey Klimov wrote: > udriver struct allocated by kzalloc() will not be freed > if usb_register() and next calls fail. This patch fixes this > by adding one more step with kfree(udriver) in error path. > > Cc: Alan Stern >

[PATCH] scsi: introduce a quirk for false cache reporting

Some SATA to USB bridges fail to cooperate with some drives resulting in no cache being present being reported to the host. That causes the host to skip sending a command to synchronize caches. That causes data loss when the drive is powered down. Signed-off-by: Oliver Neukum

[PATCH v5 4/6] usb: core: add power sequence handling for USB devices

Some hard-wired USB devices need to do power sequence to let the device work normally, the typical power sequence like: enable USB PHY clock, toggle reset pin, etc. But current Linux USB driver lacks of such code to do it, it may cause some hard-wired USB devices works abnormal or can't be

[PATCH v5 2/6] power: add power sequence library

We have an well-known problem that the device needs to do some power sequence before it can be recognized by related host, the typical example like hard-wired mmc devices and usb devices. This power sequence is hard to be described at device tree and handled by related host driver, so we have

[PATCH v5 3/6] binding-doc: usb: usb-device: add optional properties for power sequence

Add optional properties for power sequence. Signed-off-by: Peter Chen Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[PATCH v5 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

From: Peter Chen At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node, we let the

Re: [PATCH] USB: serial: option: add D-Link DWM-156/A3

On Sun, Jul 24, 2016 at 01:53:30PM +0200, Lubomir Rintel wrote: > The device has three interfaces; the three serial ports ought to be I assumed you meant "four interfaces" above and updated the commit message before applying. > handled by this driver: > > 00 Diagnostic interface serial port >

Re: [PATCH v3] cdc-wdm: fix "out-of-sync" due to missing notifications

Oliver Neukum writes: > On Sun, 2016-07-10 at 17:45 +0200, Bjørn Mork wrote: >> The workaround has been tested on a large number of different MBIM >> and QMI devices, as well as the Ericsson F5521gw and H5321gw modems >> with real Device Management functions. >> >>

Re: [PATCH] USB: ftdi_sio: Added custom PIDs for Ivium Technologies electrochemical interface products

On Thu, Jul 28, 2016 at 06:52:55PM +, Robert Deliën wrote: > Ivium Technologies uses the FTDI VID with custom PIDs for their line of > electrochemical interfaces and the PalmSens they developed for PalmSens BV. > > PIDs are kept in numerical order, entries in id_table_combined[] are at > the

[PATCH v5 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl-udoo.dtsi | 26

Re: [PATCH 1/1] USB: serial: option: add support for Telit LE920A4

On Tue, Aug 02, 2016 at 11:29:25AM +0200, Daniele Palmas wrote: > This patch adds a set of compositions for Telit LE920A4. > > Compositions in short are: > > 0x1207: tty + tty > 0x1208: tty + adb + tty + tty > 0x1211: tty + adb + ecm > 0x1212: tty + adb > 0x1213: ecm + tty > 0x1214: tty + adb +

[PATCH v5 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by: Rob Herring --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++ 1 file changed, 48

[PATCH v5 0/6] power: add power sequence library

Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2], I use a generic power sequence library for parsing the power sequence elements on DT, and implement generic power sequence on library. The host driver can

Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

On Thu, Jul 28, 2016 at 05:01:45PM -0400, Sheng-Hui J. Chu wrote: > BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO > IC. > > To support BCM920706V2_EVAL dev board for WICED development on Linux. Add > the VID(0a5c) and > PID(6422) to ftdi_sio driver to allow

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

On Mon, 2016-08-08 at 14:44 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > I don't see how it would be specific for a subsystem. If the patch > > is correct, it belongs into the networking core. > > The bug is in the firmware implementation of the "read unique vendor >