Re: [PATCH v2 2/3] Documentation: bindings: add DT documentation for u2phy and u2phy grf

2017-03-02 Thread Heiko Stuebner
Am Freitag, 3. März 2017, 00:21:56 CET schrieb Rob Herring: > On Thu, Mar 02, 2017 at 03:49:04PM +0800, Meng Dongyang wrote: > > Due to the u2phy registers are separated from general grf, we need to > > add u2phy grf node and place u2phy node in it. So this patch add u2phy > > grf node. > >

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-02 Thread Mats Karrman
On 2017-03-03 04:13, Guenter Roeck wrote: On 03/02/2017 07:22 AM, Mats Karrman wrote: Looking forward, one thing I have run into is how to connect the typec driver with a driver for an alternate mode. E.g. the DisplayPort Alternate Mode specification includes the HPD (hot plug) and

Re: [PATCH 2/2] HID: hiddev: store hiddev's minor number when hiddev is connected

2017-03-02 Thread Kim Jaejoong
2017-03-02 23:13 GMT+09:00 Benjamin Tissoires : > On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: >> The hid-core announces kernel message which driver is loaded if there is >> a hiddev, but hiddev's minor number is always zero even though it's not >> zero. >> >>

Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev

2017-03-02 Thread Kim Jaejoong
2017-03-02 23:10 GMT+09:00 Benjamin Tissoires : > On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: >> We need to store the minor number each drivers. In case of hidraw, it's >> minor number stores in struct hidraw. But hiddev's minor is located in >> struct

Re: [PATCH v2 1/3] Documentation: bindings: add assign clock property in u2phy node

2017-03-02 Thread Rob Herring
On Thu, Mar 02, 2017 at 03:49:03PM +0800, Meng Dongyang wrote: > On some platform such as RK3328, the 480m clock may need to assign > clock parent in dts in stead of clock driver. So this patch add > property of assigned-clocks and assigned-clock-parents to assign > parent for 480m clock. > >

Re: [PATCH v2 2/3] Documentation: bindings: add DT documentation for u2phy and u2phy grf

2017-03-02 Thread Rob Herring
On Thu, Mar 02, 2017 at 03:49:04PM +0800, Meng Dongyang wrote: > Due to the u2phy registers are separated from general grf, we need to > add u2phy grf node and place u2phy node in it. So this patch add u2phy > grf node. Similar comment on the subject. > > Changes in v2: > - add u2phy grf

Re: [PATCH v2 2/3] Documentation: bindings: add DT documentation for u2phy and u2phy grf

2017-03-02 Thread rock-chips(daniel.meng)
On 2017/3/3 14:21, Rob Herring wrote: On Thu, Mar 02, 2017 at 03:49:04PM +0800, Meng Dongyang wrote: Due to the u2phy registers are separated from general grf, we need to add u2phy grf node and place u2phy node in it. So this patch add u2phy grf node. Similar comment on the subject.

[PATCH 09/21] USB: serial: digi_acceleport: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Note that this driver uses an additional bulk-endpoint pair as an out-of-band port. Signed-off-by: Johan Hovold --- drivers/usb/serial/digi_acceleport.c | 23

Re: [PATCH] USB: misc: ldusb: Fixed coding style issues

2017-03-02 Thread Greg KH
On Fri, Mar 03, 2017 at 12:55:46AM +0100, Milian Reichardt wrote: > Fixed multiple coding style issues. Please be specific as to exactly what issues you are fixing up. And don't do multiple things in the same patch, each different thing needs to be broken up into an individual patch. thanks,

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-02 Thread Guenter Roeck
On 03/02/2017 07:35 PM, Peter Chen wrote: On Tue, Feb 21, 2017 at 05:24:04PM +0300, Heikki Krogerus wrote: +/* --- */ +/* Driver callbacks to report role updates */ + +/** + * typec_set_data_role - Report data role change + * @port: The USB Type-C Port where

Bug ID: 193901 Summary: dvb-usb: bulk message failed on Linux 4.9 - on Linux 4.8 no issues

2017-03-02 Thread W.Pelser
Hallo! I have the same problems with my DVB-T2 USB-Stick. August DVB-T210 (V 2.0) is detected by kernel as Mygica T230 DVB-T/T2/C which is the same as Geniatech 230. Tested: Kernel 4.10.1.: "no frontend was attached" Latest working kernel for me is Kernel 4.4.X. with firmware from

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-02 Thread Peter Chen
On Thu, Mar 02, 2017 at 08:29:07PM -0800, Guenter Roeck wrote: > On 03/02/2017 07:35 PM, Peter Chen wrote: > >On Tue, Feb 21, 2017 at 05:24:04PM +0300, Heikki Krogerus wrote: > >>+/* --- */ > >>+/* Driver callbacks to report role updates */ > >>+ > >>+/** > >>+

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-02 Thread Peter Chen
On Tue, Feb 21, 2017 at 05:24:04PM +0300, Heikki Krogerus wrote: > +/* --- */ > +/* Driver callbacks to report role updates */ > + > +/** > + * typec_set_data_role - Report data role change > + * @port: The USB Type-C Port where the role was changed > + * @role:

Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev

2017-03-02 Thread Benjamin Tissoires
On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: > We need to store the minor number each drivers. In case of hidraw, it's > minor number stores in struct hidraw. But hiddev's minor is located in > struct hid_device. > > So reallocates for hiddev's minor number. > There is not a real need to

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-02 Thread Guenter Roeck
On 03/02/2017 07:22 AM, Mats Karrman wrote: Hi Heikki, Good to see things are happening with Type-C! On 2017-02-21 15:24, Heikki Krogerus wrote: ... +When connected, the partner will be presented also as its own device under +/sys/class/typec/. The parent of the partner device will always be

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-02 Thread NeilBrown
On Mon, Feb 20 2017, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add this in their kernels > or USB gadget

[PATCH] usb: dwc2: Make sure we disconnect the gadget state

2017-03-02 Thread John Stultz
I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have chased down. Basically every other time I pluged in the OTG port, the gadget interface would properly initialize. The other times, I'd get a big WARN_ON in dwc2_hsotg_init_fifo() about the fifo_map not

[PATCH 02/21] USB: serial: clean up endpoint and port-counter types

2017-03-02 Thread Johan Hovold
Use unsigned-char type for the endpoint and port counters. Signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 14 +++--- include/linux/usb/serial.h | 11 ++- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git

[PATCH 16/21] USB: serial: opticon: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold --- drivers/usb/serial/opticon.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/usb/serial/opticon.c

Re: [PATCH 2/6] USB: serial: ftdi_sio: detect BM chip with iSerialNumber bug

2017-03-02 Thread Johan Hovold
On Tue, Feb 28, 2017 at 12:51:24PM +, Ian Abbott wrote: > If a BM type chip has iSerialNumber set to 0 in its EEPROM, an incorrect > value is read from the bcdDevice field of the USB descriptor, making it > look like an AM type chip. Attempt to correct this in > ftdi_determine_type() by

Re: [RESEND PATCH 2/2] phy: rockchip-inno-usb2: add support of u2phy for rk3328

2017-03-02 Thread kbuild test robot
Hi Meng, [auto build test ERROR on robh/for-next] [also build test ERROR on v4.10 next-20170302] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Meng-Dongyang/Documentation-bindings-add-DT

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-02 Thread Mats Karrman
Hi Heikki, Good to see things are happening with Type-C! On 2017-02-21 15:24, Heikki Krogerus wrote: ... +When connected, the partner will be presented also as its own device under +/sys/class/typec/. The parent of the partner device will always be the port it +is attached to. The partner

Re: [PATCH 4/6] USB: serial: ftdi_sio: only allow valid event_char values

2017-03-02 Thread Johan Hovold
On Tue, Feb 28, 2017 at 12:51:26PM +, Ian Abbott wrote: > The "event_char" device attribute value, when written, is interpreted as > an enable bit in bit 8, and an "event character" in bits 7 to 0. Return > an error for out-of-range values. > > Signed-off-by: Ian Abbott >

[PATCH 0/2] HID: hiddev: move hiddev's minor number and refactoring

2017-03-02 Thread Jaejoong Kim
Hi all, I found hiddev's minor number is always zero in struct hid_device. So, store the minor number asked from usb core in struct hid_device. This is my first approach. But after reviewed from Bendjamin, he suggested that it would make sense to store a minor number in struct hiddev like

Re: [PATCH 3/6] USB: serial: ftdi_sio: only allow valid latency timer values

2017-03-02 Thread Johan Hovold
On Tue, Feb 28, 2017 at 12:51:25PM +, Ian Abbott wrote: > Valid latency timer values are between 1 ms and 255 ms in 1 ms steps. > The store function for the "latency_timer" device attribute currently > allows any value, although only the lower 8-bits will be written to the > latency timer.

Re: [PATCH 2/2] HID: hiddev: store hiddev's minor number when hiddev is connected

2017-03-02 Thread Benjamin Tissoires
On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: > The hid-core announces kernel message which driver is loaded if there is > a hiddev, but hiddev's minor number is always zero even though it's not > zero. > > So, we need to store the minor number asked from usb core and do some > refactoring

[PATCH 14/21] USB: serial: mos7720: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Note that the driver expects two bulk-endpoint pairs also for mcs7715 devices for which only one serial port is registered. Signed-off-by: Johan Hovold ---

Re: [PATCH 6/6] USB: serial: ftdi_sio: allow other bases for "event_char"

2017-03-02 Thread Johan Hovold
On Tue, Feb 28, 2017 at 12:51:28PM +, Ian Abbott wrote: > The 'store' function for the "event_char" device attribute currently > expects a base 10 value. The value is composed of an enable bit in bit > 8 and an 8-bit "event character" code in bits 7 to 0. It seems > reasonable to allow

[PATCH 13/21] USB: serial: kobil_sct: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold --- drivers/usb/serial/kobil_sct.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/serial/kobil_sct.c

[PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev

2017-03-02 Thread Jaejoong Kim
We need to store the minor number each drivers. In case of hidraw, it's minor number stores in struct hidraw. But hiddev's minor is located in struct hid_device. So reallocates for hiddev's minor number. Signed-off-by: Jaejoong Kim --- drivers/hid/usbhid/hiddev.c | 1 +

[PATCH 18/21] USB: serial: pl2303: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/usb/serial/pl2303.c

[PATCH 05/21] USB: serial: replace runtime overflow check

2017-03-02 Thread Johan Hovold
Since commit 0a8fd1346254 ("USB: fix problems with duplicate endpoint addresses") USB core guarantees that there are no more than 15 endpoint descriptors per type (and altsetting) so the corresponding overflow checks can now be replaced with a compile-time check on the array sizes (and indirectly

[PATCH 2/2] HID: hiddev: store hiddev's minor number when hiddev is connected

2017-03-02 Thread Jaejoong Kim
The hid-core announces kernel message which driver is loaded if there is a hiddev, but hiddev's minor number is always zero even though it's not zero. So, we need to store the minor number asked from usb core and do some refactoring work(move from hiddev.c to hiddev.h) to access hiddev in

[PATCH 01/21] USB: serial: clean up probe error paths

2017-03-02 Thread Johan Hovold
Clean up the probe error paths by adding a couple of new error labels. Signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/usb/serial/usb-serial.c

[PATCH 21/21] USB: serial: whiteheat: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Note that the driver registers four ports but uses five bulk-endpoint pairs. Signed-off-by: Johan Hovold --- drivers/usb/serial/whiteheat.c | 32 ++--

[PATCH 19/21] USB: serial: spcp8x5: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold --- drivers/usb/serial/spcp8x5.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/usb/serial/spcp8x5.c

[PATCH 00/21] USB: serial: refactor endpoint sanity checks

2017-03-02 Thread Johan Hovold
This series refactors the endpoint sanity checks by allowing subdrivers to specify a minimum number of endpoints required per type and letting core verify this during probe. Note that the checks are minimum (i.e. we allow further unused endpoints) and are verified only after the subdriver probe

[PATCH 03/21] USB: serial: refactor and clean up endpoint handling

2017-03-02 Thread Johan Hovold
Refactor and clean up endpoint handling. This specifically moves the endpoint-descriptor arrays of the stack. Signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 155 +--- 1 file changed, 80 insertions(+), 75 deletions(-)

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

2017-03-02 Thread Felipe Balbi
Hi, Alan Stern writes: >> Alan Stern writes: >> >> So I am not sure how the Gadget driver can figure out that it needs to >> >> usb_ep_queue() another request for status stage when handling the >> >> no-data control? >> > >> > Gadget

[PATCH 04/21] USB: serial: allow up to 16 ports per device

2017-03-02 Thread Johan Hovold
Raise the arbitrary limit of how many ports a single device can claim from eight to 16. This specifically enables the upper eight ports of some mxuport devices. Signed-off-by: Johan Hovold --- include/linux/usb/serial.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 06/21] USB: serial: add endpoint sanity check to core

2017-03-02 Thread Johan Hovold
Allow drivers to specify a minimum number of endpoints per type, which USB serial core will verify after subdriver probe has returned (where the current alternate setting may have been changed). Signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 9 -

[PATCH 10/21] USB: serial: io_edgeport: simplify and tighten endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Also require the presence of a bulk-out endpoint, something which prevents the driver from trying to send bulk messages over the control pipe should a bulk-out endpoint be missing. Signed-off-by:

[PATCH 07/21] USB: serial: ark3116: simplify endpoint sanity check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold --- drivers/usb/serial/ark3116.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/usb/serial/ark3116.c

[PATCH 15/21] USB: serial: omninet: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Note that the driver uses the second bulk-out endpoint for writing. Signed-off-by: Johan Hovold --- drivers/usb/serial/omninet.c | 14 +- 1 file changed, 1

[PATCH 11/21] USB: serial: iuu_phoenix: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold --- drivers/usb/serial/iuu_phoenix.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git

[PATCH 08/21] USB: serial: cyberjack: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold --- drivers/usb/serial/cyberjack.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/usb/serial/cyberjack.c

[PATCH 20/21] USB: serial: symbolserial: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold --- drivers/usb/serial/symbolserial.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git

[PATCH 17/21] USB: serial: oti6858: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold --- drivers/usb/serial/oti6858.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/usb/serial/oti6858.c

[PATCH 12/21] USB: serial: keyspan_pda: simplify endpoint check

2017-03-02 Thread Johan Hovold
Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold --- drivers/usb/serial/keyspan_pda.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git

Re: [PATCH] usb: musb: cppi41: don't check early-TX-interrupt for Isoch transfer

2017-03-02 Thread Alexandre Bailon
On 03/02/2017 03:52 AM, Bin Liu wrote: > The CPPI41 driver polls register to workaround the pre-mature TX > interrupt issue, but it causes audio playback underrun when triggered in > Isoch transfers. > > Isoch doesn't do back-to-back transfers, the TX should be done by the > time the next

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

2017-03-02 Thread Felipe Balbi
Hi, Baolin Wang writes: >>> > Baolin Wang writes: >>> (One possible approach would be to have the setup routine return >>> different values for explicit and implicit status stages -- for >>> example, return 1 if it wants to submit

Re: [PATCH] Revert "usb: gadget: uvc: Add missing call for additional setup data"

2017-03-02 Thread Laurent Pinchart
Hi Roger, Thank you for the patch. On Thursday 02 Mar 2017 10:44:58 Roger Quadros wrote: > This reverts commit 4fbac5206afd01b717d4bdc58793d471f3391b4b. > > This commit breaks g_webcam when used with uvc-gadget [1]. > > The user space application (e.g. uvc-gadget) is responsible for > sending

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

2017-03-02 Thread Baolin Wang
Hi, On 28 February 2017 at 06:11, Alan Stern wrote: > On Tue, 21 Feb 2017, Baolin Wang wrote: > >> On 17 February 2017 at 16:04, Felipe Balbi wrote: >> > >> > Hi, >> > >> > Baolin Wang writes: >> (One possible approach

Re: [PATCH] usb: musb: cppi41: don't check early-TX-interrupt for Isoch transfer

2017-03-02 Thread Sergei Shtylyov
Hello! On 3/2/2017 5:52 AM, Bin Liu wrote: The CPPI41 driver polls register to workaround the pre-mature TX It's CPPI 4.1. And "premature". interrupt issue, but it causes audio playback underrun when triggered in Isoch transfers. Isoch doesn't do back-to-back transfers, the TX should

RE: [PATCH v4 11/19] scsi: megaraid: Replace PCI pool old API

2017-03-02 Thread Sumit Saxena
>-Original Message- >From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >ow...@vger.kernel.org] On Behalf Of Romain Perier >Sent: Wednesday, March 01, 2017 9:25 PM >To: Dan Williams; Doug Ledford; Sean Hefty; Hal Rosenstock; >jeffrey.t.kirs...@intel.com; David S. Miller;

[PATCH] Revert "usb: gadget: uvc: Add missing call for additional setup data"

2017-03-02 Thread Roger Quadros
This reverts commit 4fbac5206afd01b717d4bdc58793d471f3391b4b. This commit breaks g_webcam when used with uvc-gadget [1]. The user space application (e.g. uvc-gadget) is responsible for sending response to UVC class specific requests on control endpoint in uvc_send_response() in uvc_v4l2.c. The

Re: [PATCH] usb: musb: cppi41: don't check early-TX-interrupt for Isoch transfer

2017-03-02 Thread Sebastian Andrzej Siewior
On 2017-03-01 20:40:04 [-0600], Bin Liu wrote: > The CPPI41 driver polls register to workaround the pre-mature TX > interrupt issue, but it causes audio playback underrun when triggered in > Isoch transfers. > > Isoch doesn't do back-to-back transfers, the TX should be done by the > time the next

FW: RE: Re: FW: RE: Re: Subject: [PATCH v3] USB:Core: BugFix: Proper handling of Race Condition when two USB class drivers try to call init_usb_class simultaneously

2017-03-02 Thread Ajay Kaher
> On Wed, 1 Mar 2017, Alan Stern wrote: >> On Wed, 1 Mar 2017, Ajay Kaher wrote: >>> On Mon, 22 Feb 2017, Ajay Kaher wrote: >>>    > Alan, as per my understanding I have shifted the lock from > release_usb_class() to destroy_usb_class() in patch v3.  > If it is not right, please