Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-21 Thread Arnd Bergmann
On Thursday 21 January 2016 17:48:32 Peter Chen wrote: > > > > > So two hubs at ports 1 and 2 of the USB controller that integrates > > the root hub and shares a device node with it. > > > Ok, so the "reg" is the address for certain root hub (HS or SS), not > the unity address for the whole cont

Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-21 Thread Arnd Bergmann
On Thursday 21 January 2016 10:21:15 Alan Stern wrote: > On Thu, 21 Jan 2016, Arnd Bergmann wrote: > > > On Thursday 21 January 2016 17:48:32 Peter Chen wrote: > > > > > > > > > > > So two hubs at ports 1 and 2 of the USB controller that integrates

Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-22 Thread Arnd Bergmann
On Friday 22 January 2016 14:59:01 Peter Chen wrote: > On Thu, Jan 21, 2016 at 11:24:21PM +0100, Arnd Bergmann wrote: > > On Thursday 21 January 2016 10:21:15 Alan Stern wrote: > > > On Thu, 21 Jan 2016, Arnd Bergmann wrote: > > > > On Thursday 21 January

Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-22 Thread Arnd Bergmann
On Friday 22 January 2016 10:55:01 Alan Stern wrote: > On Fri, 22 Jan 2016, Arnd Bergmann wrote: > > > > > hub@3 { /* same external hub, highspeed mode */ > > > > compatible = "usb2109,0812.591", > > > >

Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-25 Thread Arnd Bergmann
On Monday 25 January 2016 11:57:37 Peter Chen wrote: > >> > > >> > hub@3 { /* same external hub, highspeed mode */ > >> > compatible = "usb2109,0812.591", > >> > "usb2109,0812", > >> > "usb2109,class9

[PATCH 0/7] USB changes for rare warnings

2016-01-28 Thread Arnd Bergmann
, as I have done only compile-time testing. After these patches, I get no other warnings for USB drivers at the moment. Arnd Bergmann (7): usb: gadget: pxa25x_udc: move register definitions from arch usb: gadget: pxa25x_udc cleanup usb: gadget: pxa25x_udc: use readl/writel for mmio usb: fsl

[PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

2016-01-28 Thread Arnd Bergmann
s incorrectly copied from pxa25x to ixp4xx. Signed-off-by: Arnd Bergmann --- arch/arm/mach-ixp4xx/include/mach/ixp4xx-regs.h | 198 arch/arm/mach-pxa/include/mach/pxa25x-udc.h | 163 --- drivers/usb/gadget/udc/pxa25x_udc.c | 161

[PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

2016-01-28 Thread Arnd Bergmann
some magic setting in the chip that makes the endianess of the MMIO register match the CPU, and in that case, the code actually does the right thing for all configurations, both before and after this patch. Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/udc/pxa25x_

[PATCH 2/7] usb: gadget: pxa25x_udc cleanup

2016-01-28 Thread Arnd Bergmann
replace the hardcoded virtual address pointers. Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/udc/pxa25x_udc.c | 468 +--- drivers/usb/gadget/udc/pxa25x_udc.h | 10 +- 2 files changed, 275 insertions(+), 203 deletions(-) diff --git a/drivers/usb/gadget/udc

[PATCH 4/7] usb: fsl: drop USB_FSL_MPH_DR_OF Kconfig symbol

2016-01-28 Thread Arnd Bergmann
o ensure the file is built-in if needed. There is currently a dependency on CONFIG_OF, but this is redundant, as we already know that this is set unconditionally for the platforms that use this driver. Signed-off-by: Arnd Bergmann --- drivers/usb/Makefile | 2 +- drivers/usb/gadget/udc

[PATCH 5/7] usb: isp1301-omap: mark power_up as __maybe_unused

2016-01-28 Thread Arnd Bergmann
ently drop the definition when it is unused. Signed-off-by: Arnd Bergmann --- drivers/usb/phy/phy-isp1301-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-isp1301-omap.c b/drivers/usb/phy/phy-isp1301-omap.c index 3af263cc0caa..8d111ec653e4 100644 ---

[PATCH 7/7] usb: musb/ux500: remove duplicate check for dma_is_compatible

2016-01-28 Thread Arnd Bergmann
d removing it must be the cleanest solution. Signed-off-by: Arnd Bergmann --- drivers/usb/musb/ux500_dma.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/musb/ux500_dma.c b/drivers/usb/musb/ux500_dma.c index d0b6a1cd7f62..c92a295049ad 100644 --- a/drivers/usb/musb/ux500_d

[PATCH 6/7] usb: musb: use %pad format string from dma_addr_t

2016-01-28 Thread Arnd Bergmann
igned int}' [-Werror=format=] dev_dbg(musb->controller, "ep%i %s dma ch%i dma: %08x len: %u(%u) packet_sz: %i(%i)\n", This uses the %pad format string, which prints a dma_addr_t that gets passed by reference, which works for all combinations. Signed-off-by: Arnd Bergmann

Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

2016-01-29 Thread Arnd Bergmann
On Friday 29 January 2016 10:32:07 Robert Jarzmik wrote: > > This addresses both issues by moving all the definitions into the > > pxa25x_udc driver itself. It turns out the only difference between > > them was 'UDCCS_IO_ROF', and that could well be a mistake when it > > was incorrectly copied from

Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

2016-01-29 Thread Arnd Bergmann
On Friday 29 January 2016 17:18:09 Krzysztof Hałasa wrote: > Arnd Bergmann writes: > > > The unclear part here is for IXP4xx, which supports both big-endian > > and little-endian configurations. So far, the driver has done > > no byteswap in either case. I suspect th

Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

2016-01-29 Thread Arnd Bergmann
On Friday 29 January 2016 21:03:40 Sergei Shtylyov wrote: > On 01/29/2016 07:18 PM, Krzysztof Hałasa wrote: > > >> The unclear part here is for IXP4xx, which supports both big-endian > >> and little-endian configurations. So far, the driver has done > >> no byteswap in either case. I suspect that

[PATCH] usb: xhci: fix build error for USB_SPEED_SUPER_PLUS

2016-02-01 Thread Arnd Bergmann
itch [-Werror=switch] This changes the XHCI driver to handle USB_SPEED_SUPER_PLUS the same way as USB_SPEED_SUPER in the xhci_drop_ep_from_interval_table and xhci_add_ep_to_interval_table functions, explicitly ignoring it. Signed-off-by: Arnd Bergmann Fixes: 8a1b2725a60d ("usb: define USB_S

Re: [PATCH 0/7] USB changes for rare warnings

2016-02-03 Thread Arnd Bergmann
On Wednesday 03 February 2016 20:15:47 Robert Jarzmik wrote: > Felipe Balbi writes: > > > Hi Arnd, > > > >> arch/arm/mach-ixp4xx/include/mach/ixp4xx-regs.h | 198 - > >> arch/arm/mach-pxa/include/mach/pxa25x-udc.h | 163 > > > > for arch/arm I need Acked-by from relevant folk

Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency

2016-02-03 Thread Arnd Bergmann
On Wednesday 03 February 2016 19:54:02 Felipe Balbi wrote: > > hi, > > Bin Liu writes: > > On Wed, Jan 20, 2016 at 11:56:34AM +0100, Arnd Bergmann wrote: > >> The phy-am335x driver accidentally selects 'USB_COMMON', which is > >> not correct as t

[PATCH] usb: rework CONFIG_USB_COMMON logic

2016-02-03 Thread Arnd Bergmann
amp;& (USB || USB_GADGET)) As suggested by Felipe Balbi, this turns the logic around, and makes 'USB_COMMON' selected by everything else that needs it, so we can remove the dependencies. Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode"

Re: [PATCH] usb: rework CONFIG_USB_COMMON logic

2016-02-04 Thread Arnd Bergmann
On Thursday 04 February 2016 14:39:16 Peter Chen wrote: > > --- > > Preliminary for now, I've added it to my patch stack for randconfig tests > > and will test it overnight to see if any build-time regressions come up. 400 randconfig builds later, no obvious regressions, so please consider this a

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-04 Thread Arnd Bergmann
On Thursday 04 February 2016 14:00:07 Petr Kulhavy wrote: > @@ -560,6 +626,97 @@ static int da8xx_probe(struct platform_device *pdev) > glue->dev = &pdev->dev; > glue->clk = clk; > > + if (np) { > + struct musb_hdrc_config *co

Re: [PATCH v4 1/1] USB: core: let USB device know device node

2016-02-05 Thread Arnd Bergmann
On Friday 05 February 2016 14:11:25 Peter Chen wrote: > On Thu, Feb 04, 2016 at 11:44:50AM +0100, Philipp Zabel wrote: > > Am Montag, den 25.01.2016, 15:24 +0800 schrieb Peter Chen: > > > diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt > > > b/Documentation/devicetree/bindings/us

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-05 Thread Arnd Bergmann
On Friday 05 February 2016 18:34:36 Petr Kulhavy wrote: > TI DA8xx MUSB driver equipped with DeviceTree support. > Tested with AM1808 board and USB2.0 (OTG) in host mode. > > Signed-off-by: Petr Kulhavy > --- > .../devicetree/bindings/usb/da8xx-usb.txt | 63 > drivers/usb/musb

Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

2016-02-08 Thread Arnd Bergmann
On Monday 08 February 2016 14:04:22 Petr Kulhavy wrote: > Hello Arndt, > > On 05.02.2016 23:22, Arnd Bergmann wrote: > > Please make this > > > > Should be one of "ti,da850-musb" or "ti,da830-musb" > > > > We don't use wild

Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

2016-02-15 Thread Arnd Bergmann
On Monday 15 February 2016 08:33:37 Krzysztof Hałasa wrote: > Arnd Bergmann writes: > > >> Anyway, I think readl()/writel() do the right thing: in BE mode they > >> swap PCI accesses and don't swap normal registers, in LE mode nothing is > >> swapp

Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

2016-02-15 Thread Arnd Bergmann
On Monday 15 February 2016 14:51:13 Krzysztof Hałasa wrote: > Arnd Bergmann writes: > > > I consider the use of __raw_* accessors a bug, I don't think we should > > ever do that because it hides how the hardware actually works, it doesn't > > work with spinlock

Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

2016-02-16 Thread Arnd Bergmann
On Tuesday 16 February 2016 10:26:14 Krzysztof Hałasa wrote: > Arnd Bergmann writes: > > > The barriers on a spinlock synchronize between CPUs but not an external > > bus, so (on some architectures) a spinlock protecting an MMIO register > > does not guara

Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

2016-02-16 Thread Arnd Bergmann
On Tuesday 16 February 2016 14:24:10 Krzysztof Hałasa wrote: > Arnd Bergmann writes: > > > Both writes leave the CPU core within the spinlock but are not serialized > > with anything else, so there is no ordering between the CPUs when they > > enter the shared bus, o

Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

2016-02-17 Thread Arnd Bergmann
On Wednesday 17 February 2016 09:36:37 Krzysztof Hałasa wrote: > Arnd Bergmann writes: > > > ixp4xx is really special in that it performs hardware swapping for > > internal devices based on CPU endianess but not on PCI devices. > > Again, IXP4xx does not perform

Re: [PATCH 0/7] fix IS_ERR_VALUE usage

2016-02-17 Thread Arnd Bergmann
On Monday 15 February 2016 15:35:18 Andrzej Hajda wrote: > > Andrzej Hajda (7): > netfilter: fix IS_ERR_VALUE usage > MIPS: module: fix incorrect IS_ERR_VALUE macro usages > drivers: char: mem: fix IS_ERROR_VALUE usage > atmel-isi: fix IS_ERR_VALUE usage > serial: clps711x: fix IS_ERR_VA

Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

2016-02-17 Thread Arnd Bergmann
On Wednesday 17 February 2016 17:08:27 Felipe Balbi wrote: > > Hi, > > Arnd Bergmann writes: > > ixp4xx and pxa25x both use this driver and provide a slightly > > different set of register definitions for it. Aside from that, > > the definition in the ixp4xx-re

[PATCH] USB: cdc_subset: only build when one driver is enabled

2016-02-17 Thread Arnd Bergmann
gurations are enable. Alternatively we could simply remove the #warning (nothing wrong for compile-testing), turn it into a runtime warning, or change the Kconfig options into a menu to hide CONFIG_USB_NET_CDC_SUBSET. Signed-off-by: Arnd Bergmann --- drivers/net/usb/Kconfig | 10 ++ driv

Re: [PATCH v6 1/1] USB: core: let USB device know device node

2016-02-19 Thread Arnd Bergmann
, > then the device node is for the device we are creating for USB core. > > Signed-off-by: Peter Chen > Acked-by: Philipp Zabel > Acked-by: Alan Stern > Acked-by: Rob Herring > Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscrib

[PATCH] usb: move usb_calc_bus_time into common code

2016-02-19 Thread Arnd Bergmann
s/usb/dwc2/dwc2.ko] undefined! Moving the function that is called from the USB HCD specific code into the shared USB code avoids this problem. Signed-off-by: Arnd Bergmann Fixes: f889904b25df ("usb: dwc2: host: Properly set even/odd frame") --- I have no idea if this is the correct solu

usb: avoid warnings for unused pm functions

2016-03-02 Thread Arnd Bergmann
This series addresses a couple of similar warnings in USB host and phy drivers. In each case, there is a mismatch between the references to some functions and the #ifdef hiding those functions (if any). The series gets rid of all those #ifdes and instead changes the drivers that don't already get

[PATCH 4/6] usb: ehci-atmel: use __maybe_unused to hide pm functions

2016-03-02 Thread Arnd Bergmann
drop the function definition. Signed-off-by: Arnd Bergmann --- drivers/usb/host/ehci-atmel.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c index be0964a801e8..7440722bfbf0 100644 --- a/drivers/usb/host/ehci-atmel.c

[PATCH 5/6] phy: dm816x: use __maybe_unused to hide pm functions

2016-03-02 Thread Arnd Bergmann
n] drivers/phy/phy-dm816x-usb.c:139:12: error: 'dm816x_usb_phy_runtime_resume' defined but not used [-Werror=unused-function] This adds __maybe_unused annotations to let the compiler know it can silently drop the function definition. Signed-off-by: Arnd Bergmann --- drivers/phy/

[PATCH 1/6] usb: host: unhide suspend/resume declarations

2016-03-02 Thread Arnd Bergmann
There is no need to hide function declarations, and making these visible to the SoC specific host drivers lets us use __maybe_unused and IS_ENABLED() checks to control their use, rather than having to use #ifdef to hide all callers. Signed-off-by: Arnd Bergmann --- drivers/usb/host/ehci.h | 2

[PATCH 3/6] usb: ohci-at91: use __maybe_unused to hide pm functions

2016-03-02 Thread Arnd Bergmann
drop the function definition. Signed-off-by: Arnd Bergmann --- drivers/usb/host/ohci-at91.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 95c8ddde0725..d177372bb357 100644 --- a/drivers/usb/host/ohci-at91.c

[PATCH 2/6] usb: xhci-mtk: use __maybe_unused to hide pm functions

2016-03-02 Thread Arnd Bergmann
et without the #ifdef. Signed-off-by: Arnd Bergmann --- drivers/usb/host/xhci-mtk.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c index 9532f5aef71b..79959f17c38c 100644 --- a/drivers/usb/host/xhci-mtk.c +++

[PATCH 6/6] phy: twl4030: use __maybe_unused to hide pm functions

2016-03-02 Thread Arnd Bergmann
n] drivers/phy/phy-twl4030-usb.c:408:12: error: 'twl4030_usb_runtime_resume' defined but not used [-Werror=unused-function] This adds __maybe_unused annotations to let the compiler know it can silently drop the function definition. Signed-off-by: Arnd Bergmann --- drivers/phy/phy-twl40

[PATCH, RESEND] staging: emxx_udc: allow modular build

2016-07-05 Thread Arnd Bergmann
ointed out that this was incorrect. Signed-off-by: Arnd Bergmann Fixes: 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") --- On Tuesday, July 5, 2016 11:52:42 AM CEST Mark Brown wrote: > On Tue, Jul 05, 2016 at 10:15:03AM +0100, Build bot for Mark Brown wrote: >

Re: master build: 2 failures 3 warnings (v4.7-1605-ge658052)

2016-07-26 Thread Arnd Bergmann
On Tuesday, July 26, 2016 1:29:55 PM CEST Build bot for Mark Brown wrote: > Tree/Branch: master > Git describe: v4.7-1605-ge658052 > Commit: e65805251f Merge branch 'irq-core-for-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > > Build Time: 106 min 43 sec > > Passed:7 / 9

Re: [PATCH 3/3] ehci-platform: add the max clock number to 4

2016-08-01 Thread Arnd Bergmann
On Sunday, July 31, 2016 7:25:36 PM CEST Icenowy Zheng wrote: > Allwinner A64 EHCI requires 4 clocks to be enabled. > > Signed-off-by: Icenowy Zheng > Can you say what those four clocks are? Are you sure that it's not just a case of a clock being incorrectly described in the clk driver, i.e. y

Re: [PATCH] USB: core: add missing header dependencies

2016-09-01 Thread Arnd Bergmann
ld_node is defined at of.c, but missing its declare as a global function. Fix it by adding related header file as well as compile it on conditional of CONFIG_OF. Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: Alan Stern Cc: linux-usb@vger.kernel.org Cc: linux-k

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-02 Thread Arnd Bergmann
On Thursday, September 1, 2016 5:14:28 PM CEST Leo Li wrote: > > Hi Felipe and Arnd, > > It has been a while since the last response to this discussion, but we > haven't reached an agreement yet! Can we get to a conclusion on if it > is valid to create child platform device for abstraction purpo

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-02 Thread Arnd Bergmann
On Friday, September 2, 2016 12:55:33 PM CEST Robin Murphy wrote: > > Huh? There's only no DMA description in DT if the device can be assumed > to be happy with the defaults. Anything else should be using > "dma-ranges", "dma-coherent", etc. to describe non-default integration > aspects. For devic

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-02 Thread Arnd Bergmann
On Friday, September 2, 2016 10:21:23 AM CEST Alan Stern wrote: > On Fri, 2 Sep 2016, Felipe Balbi wrote: > > > Hi, > > > > Russell King - ARM Linux writes: > > > On Fri, Sep 02, 2016 at 12:43:39PM +0200, Arnd Bergmann wrote: > > >> On Thursday, S

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-05 Thread Arnd Bergmann
On Friday, September 2, 2016 5:16:31 PM CEST Leo Li wrote: > > Can we use the firmware or bootloader information to provide the > default dma-mapping attributes for devices that doesn't have an > of_node pointer or ACPI data? This will at least restore what we had > previously provided . I'm con

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-06 Thread Arnd Bergmann
On Tuesday, September 6, 2016 2:35:29 PM CEST Peter Chen wrote: > On Mon, Sep 05, 2016 at 05:39:27PM +0200, Arnd Bergmann wrote: > > On Friday, September 2, 2016 5:16:31 PM CEST Leo Li wrote: > > > > Most of these are probably never used with any nonstandard > >

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-06 Thread Arnd Bergmann
On Tuesday, September 6, 2016 9:40:19 AM CEST Felipe Balbi wrote: > > this only solves the problem for DT devices. Legacy devices and > PCI-based systems will still suffer from the same problem. At least for > dwc3, I will only be taking patches that solve the problem for all > users, not a subset

[PATCH for v4.8] usb: dwc3: mark PM function as __maybe_unused

2016-09-06 Thread Arnd Bergmann
d drop the definitions silently and avoids this warning. Signed-off-by: Arnd Bergmann Fixes: f6c274e11e3b ("usb: dwc3: pci: runtime_resume child device") --- drivers/usb/dwc3/dwc3-pci.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) After we fixed all other warnings repo

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-06 Thread Arnd Bergmann
On Tuesday, September 6, 2016 1:50:48 PM CEST Felipe Balbi wrote: > Hi, > > Arnd Bergmann writes: > > On Tuesday, September 6, 2016 9:40:19 AM CEST Felipe Balbi wrote: > >> > >> this only solves the problem for DT devices. Legacy devices and > >> PC

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-07 Thread Arnd Bergmann
On Wednesday, September 7, 2016 10:17:31 AM CEST Roger Quadros wrote: > > > > Speaking of that flag, I suppose we need the same logic to know where > > to look for USB devices attached to a dwc3 host when we need to describe > > them in DT. By default we look for child device nodes under the > > n

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-07 Thread Arnd Bergmann
On Wednesday, September 7, 2016 2:33:13 PM CEST Peter Chen wrote: > > > > Right, that should make it work with iommu as well. However, it does > > not solve the other issue I mentioned above, with boards that have > > USB devices hardwired to a chipidea host controller that need > > configuration

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-07 Thread Arnd Bergmann
On Wednesday, September 7, 2016 3:44:28 PM CEST Peter Chen wrote: > > The pre-condition of DT function at USB HCD core works is the host > controller device has of_node, since it is the root node for USB tree > described at DT. If the host controller device is not at DT, it needs > to try to get i

Re: [PATCH for v4.8] usb: dwc3: mark PM function as __maybe_unused

2016-09-07 Thread Arnd Bergmann
uct dev_pm_ops dwc3_pci_dev_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(dwc3_pci_pm_dummy, dwc3_pci_pm_dummy) > > Can you check if this is enough for you? Works just fine here. > I'm sure this solves the problem too Acked-by: Arnd Bergmann I usually prefer the __maybe_unused

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-07 Thread Arnd Bergmann
On Wednesday, September 7, 2016 4:04:52 PM CEST Roger Quadros wrote: > > The main use for it is to let you specify a MAC address for on-board > > ethernet devices that lack an EPROM, but any other information can be > > added that way too. > > > >> There is a bug in the USB core because of which

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-07 Thread Arnd Bergmann
On Wednesday, September 7, 2016 1:24:07 PM CEST Felipe Balbi wrote: > > Hi, > > Arnd Bergmann writes: > > [...] > > > Regarding the DMA configuration that you mention in ci_hdrc_add_device(), > > I think we should replace > > > > pdev-&g

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-07 Thread Arnd Bergmann
On Wednesday, September 7, 2016 12:08:20 PM CEST Alan Stern wrote: > On Wed, 7 Sep 2016, Arnd Bergmann wrote: > > > drivers/usb/host/ehci-fsl.c| 4 ++-- > > How did this driver end up in the patch? > > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/us

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-08 Thread Arnd Bergmann
On Thursday, September 8, 2016 9:15:36 AM CEST Peter Chen wrote: > > > > Right, I was specifically talking about the code in chipidea here, > > which I think is never used on the PCI bus, and how the current > > code is broken. We can probably do better than of_dma_configure() > > (see below), but

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-08 Thread Arnd Bergmann
On Thursday, September 8, 2016 11:03:10 AM CEST Felipe Balbi wrote: > Arnd Bergmann writes: > >> Arnd Bergmann writes: > just look at the history of the file, you'll see that an Intel employee > was a maintainer of chipidea driver. Also: > > $ git ls-files dri

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-08 Thread Arnd Bergmann
On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi wrote: > > If we do that, we have to put child devices of the dwc3 devices into > > the platform glue, and it also breaks those dwc3 devices that don't > > have a parent driver. > > Well, this is easy to fix: > > if (dwc->dev->p

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-08 Thread Arnd Bergmann
On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: > Arnd Bergmann writes: > > On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi wrote: > >> > If we do that, we have to put child devices of the dwc3 devices into > >> > the platform gl

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-08 Thread Arnd Bergmann
On Thursday, September 8, 2016 2:00:13 PM CEST Felipe Balbi wrote: > Arnd Bergmann writes: > > On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: > >> Arnd Bergmann writes: > >> > That sounds a bit clumsy for the sake of consistency with PCI. >

Re: [RFC 15/15] mfd: syscon: Fix build of missing ioremap on UM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:41 Krzysztof Kozlowski wrote: > Since commit c89c0114955a ("mfd: syscon: Set regmap max_register in > of_syscon_register") the syscon uses ioremap so it fails on COMPILE_TEST > without HAS_IOMEM: > > drivers/mfd/syscon.c: In function ‘of_syscon_register’: > drivers/

Re: [RFC 02/15] dmaengine: nxp: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:28 Krzysztof Kozlowski wrote: > index c77f214c9466..7fbf96bff280 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -290,6 +290,7 @@ config LPC18XX_DMAMUX > bool "NXP LPC18xx/43xx DMA MUX for PL080" > depends on ARCH_LPC18XX || COMPIL

Re: [RFC 03/15] hwspinlock: qcom: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:29 Krzysztof Kozlowski wrote: > diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig > index 73a401662853..5ab2d51dc147 100644 > --- a/drivers/hwspinlock/Kconfig > +++ b/drivers/hwspinlock/Kconfig > @@ -21,6 +21,7 @@ config HWSPINLOCK_OMAP > config H

Re: [RFC 01/15] clocksource: atmel: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:27 Krzysztof Kozlowski wrote: > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index c346be650892..5927944b46e0 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -239,6 +239,7 @@ config ATMEL_PIT > > c

Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:30 Krzysztof Kozlowski wrote: > config ST_IRQCHIP > bool > select REGMAP > + depends on HAS_IOMEM# For MFD_SYSCON > select MFD_SYSCON > help > Enables SysCfg Controlled IRQs on STi based platforms. > Not user vis

Re: [RFC 05/15] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:31 Krzysztof Kozlowski wrote: > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -225,6 +225,7 @@ config PHY_MT65XX_USB3 > config PHY_HI6220_USB > tristate "hi6220 USB PHY support" > depends on (ARCH_HISI && ARM64) || COMPILE_TEST > +

Re: [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:34 Krzysztof Kozlowski wrote: > index 0da40e2e4280..5c530b6b125d 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -1302,6 +1302,7 @@ config RTC_DRV_AT91RM9200 > config RTC_DRV_AT91SAM9 > tristate "AT91SAM9 RTT as RTC" > depends on

Re: [RFC 09/15] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:35 Krzysztof Kozlowski wrote: > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 201f5c296a95..e5931e434fa2 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -79,6 +79,7 @@ config VIDEO_OMAP3

Re: [RFC 10/15] net: ethernet: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:36 Krzysztof Kozlowski wrote: > The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet > direct dependencies. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/net/ethernet/hisilicon/Kconfig | 1 + > drivers/net/ethernet/stmicro/stmmac/Kcon

Re: [RFC 11/15] power: reset: keystone: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:37 Krzysztof Kozlowski wrote: > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > index 0a6408a39c66..0f34846ae80d 100644 > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig > @@ -141,6 +141,7 @@ config POWER_RESET_XGENE >

Re: [RFC 14/15] usb: xhci: mtk: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 17:03:40 Krzysztof Kozlowski wrote: > index 8c20ebbc049c..f759a778d606 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -45,6 +45,7 @@ config USB_XHCI_PLATFORM > > config USB_XHCI_MTK > tristate "xHCI support for Mediatek MT65xx" > +

Re: [rtc-linux] Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 21:00:57 Krzysztof Kozlowski wrote: > > > > Not user visible. > > Hmmm... you are right (here and in other patches) but why am I getting > all these errors: > warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X > && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWM

Re: [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 13:27:59 Geert Uytterhoeven wrote: > On Thu, Mar 3, 2016 at 11:55 AM, Arnd Bergmann wrote: > > On Thursday 03 March 2016 17:03:34 Krzysztof Kozlowski wrote: > >> index 0da40e2e4280..5c530b6b125d 100644 > >> --- a/drivers/rtc/Kconfig >

Re: [rtc-linux] Re: [RFC 09/15] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 21:40:23 Krzysztof Kozlowski wrote: > >> select MFD_SYSCON > >> diff --git a/drivers/media/platform/exynos4-is/Kconfig > >> b/drivers/media/platform/exynos4-is/Kconfig > >> index 57d42c6172c5..c4317b99d257 100644 > >> --- a/drivers/media/platform/exynos4-is/Kconfi

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-19 Thread Arnd Bergmann
On Friday 18 March 2016 09:54:14 Peter Chen wrote: > > > > I don't think it's a very widespread problem, there are only very few > > developers that intentionally use this method, and some use the > > platform_device_register_full() call to create a device with a known > > mask, which is generally

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-19 Thread Arnd Bergmann
On Monday 14 March 2016 18:51:08 Peter Chen wrote: > On Wed, Mar 09, 2016 at 05:16:50PM -0600, Li Yang wrote: > > On Tue, Mar 8, 2016 at 9:40 PM, Bjorn Andersson > > wrote: > > > On Tue, Mar 8, 2016 at 11:52 AM, Li Yang wrote: > > >> On Wed, Mar 2, 2016 at 4:59 PM, Li Yang wrote: > > >>> On Mon,

[PATCH] usb-phy: qcom-8x16: fix regulator API abuse

2016-03-23 Thread Arnd Bergmann
devices (or all but one of them are wrong), and if more than one of them tries to request the resources correctly, they fail. [1] https://lkml.org/lkml/2016/1/26/267 Signed-off-by: Arnd Bergmann --- drivers/usb/phy/phy-qcom-8x16-usb.c | 72 ++--- 1 file change

[PATCH] usb: rework CONFIG_USB_COMMON logic

2016-03-23 Thread Arnd Bergmann
amp;& (USB || USB_GADGET)) As suggested by Felipe Balbi, this turns the logic around, and makes 'USB_COMMON' selected by everything else that needs it, so we can remove the dependencies. Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode"

Re: [PATCH] usb: rework CONFIG_USB_COMMON logic

2016-03-30 Thread Arnd Bergmann
On Wednesday 30 March 2016 13:31:01 Felipe Balbi wrote: > Arnd Bergmann writes: > > [ text/plain ] > > The phy-am335x driver selects 'USB_COMMON', but all other drivers > > use 'depends on' for that symbol, and it depends on USB || USB_GADGET &

Re: [PATCHv3 2/2] usb: dwc2: Add reset control to dwc2

2016-04-13 Thread Arnd Bergmann
On Thursday 14 April 2016, dingu...@opensource.altera.com wrote: > @@ -337,6 +338,17 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg > *hsotg) > { > int i, ret; > > + hsotg->reset = devm_reset_control_get(hsotg->dev, "dwc2"); > + if (IS_ERR(hsotg->reset)) { > +

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 14:59:00 Catalin Marinas wrote: > > I would be in favour of a dma_inherit() function as well. We could hack > something up in the arch code (like below) but I would rather prefer an > explicit dma_inherit() call by drivers creating such devices. > > diff --git a/arch/ar

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 16:50:19 Catalin Marinas wrote: > On Wed, Apr 27, 2016 at 04:11:17PM +0200, Arnd Bergmann wrote: > > On Wednesday 27 April 2016 14:59:00 Catalin Marinas wrote: > > > > > > I would be in favour of a dma_inherit() function as well. We could hac

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 19:53:51 Felipe Balbi wrote: > Arnd Bergmann writes: > > On Wednesday 27 April 2016 16:50:19 Catalin Marinas wrote: > >> On Wed, Apr 27, 2016 at 04:11:17PM +0200, Arnd Bergmann wrote: > >> > On Wednesday 27 April 2016 14:59:00 Catalin Marin

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 13:59:13 Alan Stern wrote: > On Wed, 27 Apr 2016, Arnd Bergmann wrote: > > > I've looked at the usb HCD code now and see this: > > > > struct usb_hcd *usb_create_shared_hcd(const struct hc_driver *driver, > > struc

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 23:05:42 Felipe Balbi wrote: > Arnd Bergmann writes: > > On Wednesday 27 April 2016 13:59:13 Alan Stern wrote: > >> On Wed, 27 Apr 2016, Arnd Bergmann wrote: > >> > >> > I've looked at the usb HCD code now

[PATCH] usbip: vudc: fix Kconfig dependencies

2016-04-28 Thread Arnd Bergmann
27; drivers/usb/built-in.o: In function `vudc_probe': This addresses both issues, by changing the dependency for USBIP_CORE to USB_COMMON, and adding additional dependencies on USB or USB_GADGET for the individual portions as needed. Signed-off-by: Arnd Bergmann Fixes: 9360575c5837 ("usbip:

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-28 Thread Arnd Bergmann
On Thursday 28 April 2016 15:16:12 Russell King - ARM Linux wrote: > On Thu, Apr 28, 2016 at 09:37:08AM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Arnd Bergmann writes: > > >pointer and pass that in platform_data. This is really easy, it's &

[PATCH] usb: gadget: udc: atmel: fix debug output

2017-02-01 Thread Arnd Bergmann
=maybe-uninitialized] DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", This changes the debug output the same way as the other code. Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme") Signed-off-by: Arnd Bergmann --- drivers/usb/gadg

Re: [PATCH 1/3 v2] usb: host: fotg2: add device tree probing

2017-02-10 Thread Arnd Bergmann
On Friday, February 10, 2017 2:12:36 PM CET Linus Walleij wrote: > > > + /* Right now device-tree probed devices don't get dma_mask set. > > +* Since shared usb code relies on it, set it here for now. > > +* Once we have dma capability bindings this can go away. > > +

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

2017-02-14 Thread Arnd Bergmann
On Tue, Feb 14, 2017 at 11:36 AM, Roger Quadros wrote: > On 11/02/17 03:27, Peter Chen wrote: >> From: Arnd Bergmann >> >> For xhci-hcd platform device, all the DMA parameters are not >> configured properly, notably dma ops for dwc3 devices. So, set >> the dm

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

2017-02-14 Thread Arnd Bergmann
On Tue, Feb 14, 2017 at 1:26 PM, Roger Quadros wrote: > On 14/02/17 13:44, Arnd Bergmann wrote: >> On Tue, Feb 14, 2017 at 11:36 AM, Roger Quadros wrote: >>> Why are we using sysdev to read DT property? We should be using the >>> XHCI device (&pdev->dev) here,

[PATCH, RESEND] usb: gadget: udc: atmel: fix debug output

2017-02-22 Thread Arnd Bergmann
=maybe-uninitialized] DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", This changes the debug output the same way as the other code. Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme") Signed-off-by: Arnd Bergmann Acked-by: Al

[PATCH RESEND^2] usb: gadget: udc: atmel: fix debug output

2017-03-08 Thread Arnd Bergmann
=maybe-uninitialized] DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", This changes the debug output the same way as the other code. Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme") Signed-off-by: Arnd Bergmann Acked-by: Al

Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers

2013-02-05 Thread Arnd Bergmann
On Monday 21 January 2013, Greg Kroah-Hartman wrote: > On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: > > > Both the fsl_mxc gadget and the imx_udc gadget drivers fail t

<    1   2   3   4   5   6   7   >