Updated the document as per the latest implementation.
While at it also fixed some trivial typos.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
.../devicetree/bindings/usb/exynos-usb.txt | 38 +++-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git
Updated the documentation as per the latest driver implementation.
While at it also fixed some trivial typos.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
.../devicetree/bindings/usb/samsung-usbphy.txt | 48 ++--
1 file changed, 23 insertions(+), 25 deletions
otg.h header file was included twice.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/dwc3/core.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 577af1b..474162e 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers
'eem_alloc' is local to this file. Make it static.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/f_eem.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/f_eem.c b/drivers/usb/gadget/f_eem.c
index d00392d..d61c11d 100644
'ecm_alloc' is local to this file. Make it static.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/f_ecm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/f_ecm.c b/drivers/usb/gadget/f_ecm.c
index edab45d..8d9e6f7 100644
'xhci_del_comp_mod_timer' is local to this file.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/host/xhci-hub.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index fae697e..2b61700 100644
Local symbols used in this file are made static.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Anatolij Gustschin ag...@denx.de
---
drivers/usb/host/fsl-mph-dr-of.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/amd5536udc.c |2 --
drivers/usb/gadget/goku_udc.c |1 -
drivers/usb/gadget/net2280.c|1 -
drivers/usb/gadget/pch_udc.c|1 -
4 files
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/dwc3/dwc3-pci.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 997ebe4..f41ce36 100644
tegra-clk is obtained using devm_clk_get(). Hence clk_put
should not be used.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Stephen Warren swar...@nvidia.com
---
drivers/usb/host/ehci-tegra.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/musb/musb_am335x.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_am335x.c b
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Ravi B ravib...@ti.com
---
drivers/usb/musb/musb_dsps.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/phy/phy-am335x-control.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-am335x
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Stephen Warren swar...@wwwdotorg.org
Cc: linux-te...@vger.kernel.org
---
drivers/usb/phy/phy-tegra-usb.c |2 +-
1 file changed, 1
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/phy/phy-am335x.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-am335x.c b/drivers
Hi Felipe,
On 30 September 2013 09:44, Sachin Kamat sachin.ka...@linaro.org wrote:
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/musb/musb_am335x.c |2 +-
1 file
Hi Jingoo,
On 10 October 2013 12:01, Jingoo Han jg1@samsung.com wrote:
The non-DT for EXYNOS SoCs is not supported from v3.11.
Thus, there is no need to support non-DT for Exynos EHCI driver.
The 'include/linux/platform_data/usb-ehci-exynos.h' file has been
used for non-DT support. Thus,
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/host/ohci-at91.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c-hsotg.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/misc/usb3503.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/phy/phy-twl6030-usb.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/phy/phy-twl6030-usb.c
b/drivers/usb
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/host/ohci-pxa27x.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host
On 22 October 2013 11:44, Greg KH gre...@linuxfoundation.org wrote:
On Mon, Oct 21, 2013 at 07:23:11AM -0500, Felipe Balbi wrote:
Hi,
On Sat, Oct 19, 2013 at 02:17:52PM -0700, Greg KH wrote:
On Thu, Oct 17, 2013 at 01:55:02PM +0530, Sachin Kamat wrote:
'of_match_ptr' is defined in linux
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
module_platform_driver_probe() eliminates the boilerplate and simplifies
the code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Li Yang le...@freescale.com
---
drivers/usb/gadget/fsl_udc_core.c | 16 +---
1 files changed, 1 insertions(+), 15 deletions(-)
diff --git
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
/s3c2410_udc.c:1632:3: error:
cannot take address of bit-field ‘maxpacket’
usb_ep_set_maxpacket_limit(ep-ep, ep-ep.maxpacket);
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Reviewed-by: Robert Baldyga r.bald...@samsung.com
---
drivers/usb/gadget/s3c2410_udc.c |2 +-
1 file changed, 1
Fixes the following compilation warning:
drivers/usb/gadget/s3c-hsudc.c: In function ‘s3c_hsudc_probe’:
drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label ‘err_add_device’
defined but not used [-Wunused-label]
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c
On 3 February 2014 13:59, Sachin Kamat sachin.ka...@linaro.org wrote:
Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'.
Fixes the following compilation error introduced by commit e117e742d310
(usb: gadget: add maxpacket_limit field to struct usb_ep):
drivers/usb
On 18 February 2014 20:58, Felipe Balbi ba...@ti.com wrote:
On Mon, Feb 03, 2014 at 01:59:38PM +0530, Sachin Kamat wrote:
Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'.
Fixes the following compilation error introduced by commit e117e742d310
(usb: gadget: add
On 18 February 2014 20:58, Felipe Balbi ba...@ti.com wrote:
On Mon, Feb 03, 2014 at 01:59:39PM +0530, Sachin Kamat wrote:
Fixes the following compilation warning:
drivers/usb/gadget/s3c-hsudc.c: In function 's3c_hsudc_probe':
drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label
Adds header file protection macros.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
include/linux/platform_data/s3c-hsotg.h |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/include/linux/platform_data/s3c-hsotg.h
b/include/linux/platform_data/s3c-hsotg.h
On 17/07/2012, Felipe Balbi ba...@ti.com wrote:
On Tue, Jul 17, 2012 at 02:40:10PM +0530, Sachin Kamat wrote:
Adds header file protection macros.
you need to comment if you actually ran into an issue. Is there any file
which ends up with double inclusion of this header or are you just
trying
Adds header file protection macros to avoid multiple inclusion.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
include/linux/platform_data/s3c-hsotg.h |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/include/linux/platform_data/s3c-hsotg.h
b/include/linux
Hi Praveen,
Some minor comments:
On 7 August 2012 12:58, Praveen Paneri p.pan...@samsung.com wrote:
Adding the transceiver to hsotg driver. Keeping the platform data
for continuing the smooth operation for boards which still uses it
Signed-off-by: Praveen Paneri p.pan...@samsung.com
---
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Nicolas Ferre nicolas.fe...@atmel.com
---
drivers/usb/gadget/atmel_usba_udc.c |2 --
1 file changed, 2
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Kevin Cernekee cerne...@gmail.com
---
drivers/usb/gadget/bcm63xx_udc.c |1 -
1 file changed, 1 deletion
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Alan Stern st...@rowland.harvard.edu
---
drivers/usb/gadget/dummy_hcd.c |1 -
1 file changed, 1 deletion
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Jaswinder Singh jaswinder.si...@linaro.org
---
drivers/usb/gadget/f_uac2.c |2 --
1 file changed, 2
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Darius Augulis augulis.dar...@gmail.com
---
drivers/usb/gadget/imx_udc.c |2 --
1 file changed, 2
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Eric Miao eric.y.m...@gmail.com
---
drivers/usb/gadget/pxa25x_udc.c |1 -
1 file changed, 1 deletion
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c2410_udc.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/phy/phy-ab8500-usb.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/phy/phy
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Philipp Zabel philipp.za...@gmail.com
---
drivers/usb/phy/phy-gpio-vbus-usb.c |2 --
1 file changed, 2
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Chao Xie chao@marvell.com
---
drivers/usb/phy/phy-mv-usb.c |3 ---
1 file changed, 3 deletions
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Marek Vasut ma...@denx.de
---
drivers/usb/phy/phy-mxs-usb.c |2 --
1 file changed, 2 deletions(-)
diff
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/phy/phy-nop.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/phy/phy-nop.c b
'qt2_process_read_urb' is referenced only in this file. Make it static.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/serial/quatech2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index
module_usb_driver() eliminates boilerplate and simplifies the code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Realtek linux nic maintainers nic_s...@realtek.com
---
drivers/net/usb/r8152.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers
version.h header inclusion is not necessary as detected by
checkversion.pl.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
This series compile tested on linux-next (20130516).
---
drivers/net/usb/r8152.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/r8152.c b
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Marek Vasut ma...@denx.de
Cc: Alexander Shishkin alexander.shish...@linux.intel.com
---
drivers/usb/chipidea
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Yu Xu y...@marvell.com
---
drivers/usb/gadget/mv_u3d_core.c |3 ---
1 file changed, 3 deletions(-)
diff
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Eric Miao eric.y.m...@gmail.com
---
drivers/usb/gadget/pxa27x_udc.c |1 -
1 file changed, 1 deletion
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Alan Stern st...@rowland.harvard.edu
---
drivers/usb/host/ehci-tilegx.c |1 -
1 file changed, 1 deletion
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/host/ohci-da8xx.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/ohci
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Dmitry Chigirev sou...@mvista.com
---
drivers/usb/host/ohci-nxp.c |2 --
1 file changed, 2 deletions
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/host/ohci-octeon.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/ohci
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Tony Lindgren t...@atomide.com
---
drivers/usb/host/ohci-omap.c |1 -
1 file changed, 1 deletion(-)
diff
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Tony Prisk li...@prisktech.co.nz
---
drivers/usb/host/uhci-platform.c |1 -
1 file changed, 1 deletion
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Yuan-Hsin Chen yhc...@faraday-tech.com
---
drivers/usb/host/fusbh200-hcd.c |1 -
1 file changed, 1
Local symbols referenced only in this file are made static.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/host/fusbh200-hcd.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c
index
Hi,
On 20 May 2013 12:13, Yuan-Hsin Chen yuan...@gmail.com wrote:
Hi,
On Mon, May 20, 2013 at 1:51 PM, Sachin Kamat sachin.ka...@linaro.org wrote:
Local symbols referenced only in this file are made static.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Thank you.
I believe you
'omap_ehci_dt_ids' is always compiled in. Hence use of
of_match_ptr is unnecessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Series compile tested against linux-next tree (20130521).
---
drivers/usb/host/ehci-omap.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
'vt8500_ehci_ids' is always compiled in. Hence use of
of_match_ptr is unnecessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/host/ehci-platform.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host
'spear_ehci_id_table' is always compiled in. Hence use of
of_match_ptr is unnecessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Viresh Kumar viresh.ku...@linaro.org
---
drivers/usb/host/ehci-spear.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb
'ehci_orion_dt_ids' is always compiled in. Hence use of
of_match_ptr is unnecessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Tzachi Perelstein tza...@marvell.com
---
drivers/usb/host/ehci-orion.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb
'omap_ohci_dt_ids' is always compiled in. Hence use of
of_match_ptr is unnecessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/host/ohci-omap3.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-omap3.c b/drivers/usb/host/ohci
'spear_ohci_id_table' is always compiled in. Hence use of
of_match_ptr is unnecessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Viresh Kumar viresh.ku...@linaro.org
---
drivers/usb/host/ohci-spear.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb
'platform_uhci_ids' is always compiled in. Hence use of
of_match_ptr is unnecessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Tony Prisk li...@prisktech.co.nz
---
drivers/usb/host/uhci-platform.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb
'nop_xceiv_dt_ids' is always compiled in. Hence use of
of_match_ptr is unnecessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/phy/phy-nop.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-nop.c b/drivers/usb/phy/phy-nop.c
index
On 21 May 2013 20:26, Alan Stern st...@rowland.harvard.edu wrote:
On Tue, 21 May 2013, Sergei Shtylyov wrote:
Hello.
On 21-05-2013 16:05, Ben Dooks wrote:
'omap_ehci_dt_ids' is always compiled in. Hence use of
of_match_ptr is unnecessary.
Thought it was defined as tristate in the
On 21 May 2013 22:10, Alan Stern st...@rowland.harvard.edu wrote:
On Tue, 21 May 2013, Sachin Kamat wrote:
On 21 May 2013 20:26, Alan Stern st...@rowland.harvard.edu wrote:
On Tue, 21 May 2013, Sergei Shtylyov wrote:
Hello.
On 21-05-2013 16:05, Ben Dooks wrote:
'omap_ehci_dt_ids
On 22 May 2013 19:50, Alan Stern st...@rowland.harvard.edu wrote:
On Wed, 22 May 2013, Sachin Kamat wrote:
'hcd' is dereferenced before NULL check. Move the assignment after
the check to avoid potential NULL pointer dereferencing error.
Since the pointer in question can never be NULL, you
'hcd' can never be NULL and the spear_ehci_hcd_drv_remove routine
will never be called in_interrupt. Hence remove these checks.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Viresh Kumar viresh.ku...@linaro.org
Cc: Alan Stern st...@rowland.harvard.edu
---
Compile tested on linux-next
On 18 June 2013 15:24, Manjunath Goudar manjunath.gou...@linaro.org wrote:
On 14 June 2013 01:22, Alan Stern st...@rowland.harvard.edu wrote:
On Thu, 13 Jun 2013, Tomasz Figa wrote:
+ rc = ohci_suspend(hcd, do_wakeup);
+ if (rc == 0 do_wakeup HCD_WAKEUP_PENDING(hcd)) {
+
The error message is common to both clk_get functions. Update it
accordingly.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/phy/phy-samsung-usb2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-samsung-usb2.c
b/drivers/usb/phy
Replace printk with corresponding pr_* functions.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c2410_udc.c | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index
Silences about 75 errors and warnings related to
- Spacing
- Alignment of braces
- Line over 80 characters
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c2410_udc.c | 126 ++---
1 files changed, 61 insertions(+), 65 deletions
'req' being a pointer shouldn't be equated with 0.
Fixes the following compilation warning:
drivers/usb/gadget/s3c2410_udc.c:1299:13: warning:
Using plain integer as NULL pointer
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c2410_udc.c |2 +-
1 files changed
On 22 August 2012 11:48, Felipe Balbi ba...@ti.com wrote:
Hi,
On Wed, Aug 22, 2012 at 11:13:16AM +0530, Sachin Kamat wrote:
Replace printk with corresponding pr_* functions.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c2410_udc.c | 12 +++-
1
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c2410_udc.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers
Silences about 75 errors and warnings related to
- Spacing
- Alignment of braces
- Line over 80 characters
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c2410_udc.c | 124 ++---
1 files changed, 60 insertions(+), 64 deletions
Fixes the following warning:
WARNING: Use #include linux/io.h instead of asm/io.h
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c2410_udc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb
due to this change.
Sachin Kamat (5):
usb: gadget: s3c2410_udc: Replace asm/io.h with linux/io.h
usb: gadget: s3c2410_udc: Use pr_* and dev_err functions
usb: gadget: s3c2410_udc: Silence checkpatch errors and warnings
usb: gadget: s3c2410_udc: Move assignment outside if condition
usb
devm_* functions are used to replace kzalloc, request_mem_region, ioremap
clk_get and request_irq functions in probe call. With the usage of devm_*
functions explicit freeing and unmapping is not required.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c-hsudc.c
Silences the following checkpatch warning:
WARNING: sizeof *hsreq should be sizeof(*hsreq)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c-hsudc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb
Silences the following type of sparse warnings:
warning: Using plain integer as NULL pointer
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c-hsudc.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b
devm_* functions are already used in this file. Hence
convert clk_get to devm_clk_get for completeness.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/gadget/s3c-hsotg.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/s3c
Hi
On 3 September 2012 16:37, ABRAHAM, KISHON VIJAY kis...@ti.com wrote:
Hi,
On Mon, Sep 3, 2012 at 3:48 PM, Sachin Kamat sachin.ka...@linaro.org wrote:
Silences the following type of sparse warnings:
warning: Using plain integer as NULL pointer
Signed-off-by: Sachin Kamat sachin.ka
Hi Vivek,
On 30 April 2014 14:25, Vivek Gautam gautam.vi...@samsung.com wrote:
From: Kamil Debski k.deb...@samsung.com
Add support to PHY of USB2 of the Exynos 5250 SoC.
Signed-off-by: Kamil Debski k.deb...@samsung.com
[gautam.vi...@samsung.com: Split the usb phy entries from
syscon
On 30 April 2014 14:25, Vivek Gautam gautam.vi...@samsung.com wrote:
Add required device node for ehci and ohci controllers to
enable USB 2.0 support.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
---
arch/arm/boot/dts/exynos5420.dtsi | 36 +++-
1
module_spi_driver simplifies the code by eliminating
boilerplate code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/host/max3421-hcd.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host
The third argument of devm_of_phy_get expects a pointer.
Hence use NULL instead of 0.
Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
drivers/usb/host/ohci-exynos.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host
The third argument of devm_of_phy_get expects a pointer.
Hence use NULL instead of 0. Fixes the following warning:
drivers/usb/host/ehci-exynos.c:91:51: warning: Using plain integer as NULL
pointer
Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
drivers/usb/host/ehci-exynos.c |2
Silences the below warning:
WARNING: sizeof *twl should be sizeof(*twl)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/phy/phy-twl6030-usb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-twl6030-usb.c
b/drivers/usb/phy/phy
'keystone_usbphy_ids' is always compiled in. Hence the
helper macro is not needed.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: WingMan Kwok w-kw...@ti.com
---
drivers/usb/phy/phy-keystone.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy
Local symbols appearing only in this file are made static.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/usb/phy/phy-fsm-usb.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-fsm-usb.c b/drivers/usb/phy/phy-fsm-usb.c
index
Commit c02cecb92ed4 (ARM: orion: move platform_data definitions)
moved the file to the current location but forgot to remove the pointer
to its previous location. Clean it up. While at it also change the header
file protection macros appropriately.
Signed-off-by: Sachin Kamat sachin.ka
1 - 100 of 119 matches
Mail list logo
