dereferences a freed
pointer.
This patch adds the missing kref_get().
Fixes: commit 29bd3bc1194c624ce863cab2a7da9bc1f0c3b47b
Cc: sta...@vger.kernel.org (v4.0)
Cc: Olivier Sobrie oliv...@sobrie.be
Signed-off-by: NeilBrown ne...@suse.de
diff --git a/drivers/net/usb/hso.c b/drivers/net
Hello Dan,
On Fri, Jan 30, 2015 at 09:47:59AM -0600, Dan Williams wrote:
On Fri, 2015-01-30 at 13:22 +0100, Olivier Sobrie wrote:
By using only the usb interface number for the rfkill name, we might
have a name conflicts in case two similar hso devices are connected.
In this patch
[c0009630] (ret_from_fork+0x14/0x24)
---[ end trace cb88537fdc8fa208 ]---
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 55074da..5b157ad
Simply remove the useless extra tab.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index a49ac2e..2f2343d 100644
--- a/drivers/net/usb/hso.c
+++ b
-by: Dan Williams d...@redhat.com
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index c14fc80..d31a165 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net
For hso serial devices, two cancel_work_sync were missing in the
disconnect method.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index c916ab5..c14fc80 100644
the tty_port structure contained in the
hso_device structure has been freed.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 5b157ad..c916ab5 100644
There is no need for a dedicated reset work in the hso driver since
there is already a reset work foreseen in usb_interface that does
the same.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 25 +
1 file changed, 1 insertion(+), 24 deletions
In other functions of the driver, variables of type struct hso_serial
are denoted by serial and variables of type struct hso_device are
denoted by hso_dev. This patch makes the hso_free_interface()
consistent with these notations.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net
fix the issue.
See http://marc.info/?l=linux-usbm=142186699418489 for more info.
- Added an extra patch avoiding name conflicts for the rfkill interface.
Olivier Sobrie (11):
hso: remove useless header file timer.h
hso: fix crash when device disappears while serial port is open
hso: fix
that is called
at the end of the hangup process and we drop the last kref in this
function when all the ports have been closed, when tty_port is no
more needed and when it is safe to free the structure containing the
tty_port structure.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb
No timer related function is used in this driver.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index babda7d..cb0bcc1 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net
In the disconnect path, tx_buffer should freed like tx_data to avoid
a memory leak when the device disconnects.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index
When the rfkill interface was created, a buffer containing the name
of the rfkill node was allocated. This buffer was never freed when the
device disappears.
To fix the problem, we put the name given to rfkill_alloc() in
the hso_net structure.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
Hello Alan,
On Tue, Jan 20, 2015 at 10:26:30AM -0500, Alan Stern wrote:
On Tue, 20 Jan 2015, Olivier Sobrie wrote:
When usb_queue_reset() is called it schedules a work in view of
resetting the usb interface. When the reset work is running, it
can be scheduled again (e.g. by the usb
No timer related function is used in this driver.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index babda7d..cb0bcc1 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net
When the rfkill interface was created, a buffer containing the name
of the rfkill node was allocated. This buffer was never freed when the
device disappears.
To fix the problem, we put the name given to rfkill_alloc() in
the hso_net structure.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
In the disconnect path, tx_buffer should freed like tx_data to avoid
a memory leak when the device disconnects.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index
Simply remove the useless extra tab.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index a49ac2e..2f2343d 100644
--- a/drivers/net/usb/hso.c
+++ b
For hso serial devices, two cancel_work_sync were missing in the
disconnect method.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index c916ab5..c14fc80 100644
that is called
at the end of the hangup process and we drop the last kref in this
function when all the ports have been closed, when tty_port is no
more needed and when it is safe to free the structure containing the
tty_port structure.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb
the tty_port structure contained in the
hso_device structure has been freed.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 5b157ad..c916ab5 100644
this problem, we use a delayed work so that if the reset
work is currently run, we can avoid further call to
__usb_queue_reset_device() work by using cancel_delayed_work().
Unfortunately it increases the size of the usb_interface structure...
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
[c0009630] (ret_from_fork+0x14/0x24)
---[ end trace cb88537fdc8fa208 ]---
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 55074da..5b157ad
There is no need for a dedicated reset work in the hso driver since
there is already a reset work foreseen in usb_interface that does
the same.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 25 +
1 file changed, 1 insertion(+), 24 deletions
In other functions of the driver, variables of type struct hso_serial
are denoted by serial and variables of type struct hso_device are
denoted by hso_dev. This patch makes the hso_free_interface()
consistent with these notations.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net
are queued on an usb interface.
This serie of patches is based on v3.18.
Olivier Sobrie (11):
hso: remove useless header file timer.h
hso: fix crash when device disappears while serial port is open
hso: fix memory leak when device disconnects
hso: fix memory leak in hso_create_rfkill()
hso: fix
Hi Oliver,
On Tue, Jan 20, 2015 at 02:48:37PM +0100, Oliver Neukum wrote:
On Tue, 2015-01-20 at 13:29 +0100, Olivier Sobrie wrote:
When usb_queue_reset() is called it schedules a work in view of
resetting the usb interface. When the reset work is running, it
can be scheduled again (e.g
On Tue, Jan 20, 2015 at 02:13:17PM +0100, Oliver Neukum wrote:
On Tue, 2015-01-20 at 13:29 +0100, Olivier Sobrie wrote:
When the rfkill interface was created, a buffer containing the name
of the rfkill node was allocated. This buffer was never freed when the
device disappears.
To fix
On Tue, Jan 20, 2015 at 10:26:30AM -0500, Alan Stern wrote:
On Tue, 20 Jan 2015, Olivier Sobrie wrote:
When usb_queue_reset() is called it schedules a work in view of
resetting the usb interface. When the reset work is running, it
can be scheduled again (e.g. by the usb disconnect method
Hello,
On Mon, Jan 12, 2015 at 05:14:07AM -0500, Ahmed S. Darwish wrote:
On Sun, Jan 11, 2015 at 09:51:10PM +0100, Marc Kleine-Budde wrote:
On 01/11/2015 09:45 PM, Ahmed S. Darwish wrote:
From: Ahmed S. Darwish ahmed.darw...@valeo.com
(This is a draft patch, I'm not sure if this
in the tty buffer, discards all the data
received in the URB.
Cc: David Miller da...@davemloft.net
Cc: David Laight david.lai...@aculab.com
Cc: One Thousand Gnomes gno...@lxorguk.ukuu.org.uk
Cc: Dan Williams d...@redhat.com
Cc: Jan Dumon j.du...@option.com
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
The workqueue retry_unthrottle_workqueue is not scheduled anywhere
in the code. So, remove it.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index a3a0586
Hi Alan and Davids,
On Thu, Jul 10, 2014 at 04:50:03PM +0100, One Thousand Gnomes wrote:
On Thu, 10 Jul 2014 14:37:37 +
David Laight david.lai...@aculab.com wrote:
From: Olivier Sobrie
...
The function put_rxbuf_data() is called from the urb completion handler.
It puts the data
On Fri, Jul 11, 2014 at 09:28:47AM +, David Laight wrote:
From: Olivier Sobrie Olivier Sobrie
Hi Alan and Davids,
On Thu, Jul 10, 2014 at 04:50:03PM +0100, One Thousand Gnomes wrote:
On Thu, 10 Jul 2014 14:37:37 +
David Laight david.lai...@aculab.com wrote:
From
in the tty buffer, discards all the data
received in the URB.
Cc: David Miller da...@davemloft.net
Cc: David Laight david.lai...@aculab.com
Cc: One Thousand Gnomes gno...@lxorguk.ukuu.org.uk
Cc: Dan Williams d...@redhat.com
Cc: Jan Dumon j.du...@option.com
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
Hi David,
On Tue, Jul 08, 2014 at 04:16:33PM -0700, David Miller wrote:
From: Olivier Sobrie oliv...@sobrie.be
Date: Mon, 7 Jul 2014 11:06:07 +0200
When the module sends bursts of data, sometimes a deadlock happens in
the hso driver when the tty buffer doesn't get the chance
The workqueue retry_unthrottle_workqueue is not scheduled anywhere
in the code. So, remove it.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index a3a0586
there is no room anymore in the tty buffer, we set up a
timer of 100 msecs to give a chance to the upper layer to flush the tty
buffer and make room for new data.
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/usb/hso.c | 51 +
1 file
Hi David,
On Mon, Jul 07, 2014 at 09:13:53AM +, David Laight wrote:
From: Olivier Sobrie
When the module sends bursts of data, sometimes a deadlock happens in
the hso driver when the tty buffer doesn't get the chance to be flushed
quickly enough.
To avoid this, first, we remove
On Mon, Jul 07, 2014 at 12:55:44PM +, David Laight wrote:
From: Olivier Sobrie
Hi David,
On Mon, Jul 07, 2014 at 09:13:53AM +, David Laight wrote:
From: Olivier Sobrie
When the module sends bursts of data, sometimes a deadlock happens in
the hso driver when the tty
Hi Dan,
On Mon, Jul 07, 2014 at 11:41:20AM -0500, Dan Williams wrote:
On Mon, 2014-07-07 at 11:06 +0200, Olivier Sobrie wrote:
When the module sends bursts of data, sometimes a deadlock happens in
the hso driver when the tty buffer doesn't get the chance to be flushed
quickly enough
Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
Cc: Matthias Fuchs matthias.fu...@esd.eu
---
drivers/net/can/usb/esd_usb2.c | 127
1 file changed, 76 insertions(+), 51 deletions(-)
diff --git
The dma buffer given to usb_bulk_msg() must be allocated and not on
the stack.
See Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
Here is the incremental patch.
Thank you Greg !
Olivier
drivers/net/can/usb/kvaser_usb.c
On Fri, Nov 23, 2012 at 02:30:28PM +0100, Olivier Sobrie wrote:
The dma buffer given to usb_bulk_msg() must be allocated and not on
the stack.
See Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
Here is the incremental
The dma buffer given to usb_bulk_msg() must be allocated and not on
the stack.
See Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/can/usb/kvaser_usb.c | 111 --
1 file changed
On Fri, Nov 23, 2012 at 03:08:08PM +0100, Marc Kleine-Budde wrote:
On 11/23/2012 02:54 PM, Olivier Sobrie wrote:
The dma buffer given to usb_bulk_msg() must be allocated and not on
the stack.
See Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier
;a=commitdiff;h=32ec4576c3fb37316b1d11a04b220527822f3f0d
Thanks,
Olivier
On Wed, Nov 21, 2012 at 08:11:13AM +0100, Olivier Sobrie wrote:
This driver provides support for several Kvaser CAN/USB devices.
Such kind of devices supports up to three CAN network interfaces.
It has been tested
Hi Marc,
On Wed, Nov 07, 2012 at 09:29:05PM +0100, Marc Kleine-Budde wrote:
On 10/02/2012 09:16 AM, Olivier Sobrie wrote:
This driver provides support for several Kvaser CAN/USB devices.
Such kind of devices supports up to three CAN network interfaces.
It has been tested with a Kvaser
-by: Olivier Sobrie oliv...@sobrie.be
---
Hi,
This version includes the last changes requested by Marc on version 5 of
the patch.
Olivier
drivers/net/can/usb/Kconfig | 29 +
drivers/net/can/usb/Makefile |1 +
drivers/net/can/usb/kvaser_usb.c | 1598
Hi Marc and Wolfgang,
On Sat, Sep 22, 2012 at 06:02:14PM +0200, Wolfgang Grandegger wrote:
On 09/21/2012 11:54 AM, Marc Kleine-Budde wrote:
On 09/20/2012 07:06 AM, Olivier Sobrie wrote:
This driver provides support for several Kvaser CAN/USB devices.
Such kind of devices supports up
-by: Olivier Sobrie oliv...@sobrie.be
---
Hi,
This new patch fixes the errors pointed out by Marc and Wolfgang.
Changes since v4:
- add missing usb_free_urb()
- put error message in a separate function
- handle return code of kvaser_usb_init_one() in probe function
Olivier
drivers/net/can/usb
SemiPro
- Kvaser OEM Mercury
- Kvaser OEM Leaf
- Kvaser USBcan R
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
Changes since v3:
- add support for CMD_LOG_MESSAGE
drivers/net/can/usb/Kconfig | 33 +
drivers/net/can/usb/Makefile |1 +
drivers/net/can/usb/kvaser_usb.c | 1555
SemiPro
- Kvaser OEM Mercury
- Kvaser OEM Leaf
- Kvaser USBcan R
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
Changes since v2:
- update of error handling
- add method do_get_berr_counter if hardware support it
- fix race condition in probe function
- ...
Here is the behavior in case
On Wed, Aug 08, 2012 at 10:25:35AM +0200, Wolfgang Grandegger wrote:
Hi Oliver,
On 08/08/2012 08:14 AM, Olivier Sobrie wrote:
Hi Wolfgang,
On Tue, Aug 07, 2012 at 08:26:38AM +0200, Wolfgang Grandegger wrote:
On 08/06/2012 07:21 AM, Olivier Sobrie wrote:
This driver provides support
Hi Oliver,
On Mon, Aug 06, 2012 at 10:10:43AM +0200, Oliver Neukum wrote:
On Monday 06 August 2012 07:21:29 Olivier Sobrie wrote:
This driver provides support for several Kvaser CAN/USB devices.
Such kind of devices supports up to three can network interfaces.
It has been tested
56 matches
Mail list logo
