Re: [linux-usb-devel] [PATCH] /proc/tty support for usb serial core

2002-04-10 Thread Greg KH
On Thu, Apr 11, 2002 at 02:57:14AM +0200, Guest section DW wrote: > On Wed, Apr 10, 2002 at 05:10:17PM -0700, Greg KH wrote: > > > This patch against the 2.5.8-pre3 kernel adds /proc/ > > Totally unrelated, but this reminds me: > The unreadable /proc/bus/usb always annoyed me, and I added a > bl

Re: [linux-usb-devel] [PATCH] /proc/tty support for usb serial core

2002-04-10 Thread Guest section DW
On Wed, Apr 10, 2002 at 05:10:17PM -0700, Greg KH wrote: > This patch against the 2.5.8-pre3 kernel adds /proc/ Totally unrelated, but this reminds me: The unreadable /proc/bus/usb always annoyed me, and I added a blank line, separating entries. Hope that no utilities are confused by this. Andr

[linux-usb-devel] [PATCH] /proc/tty support for usb serial core

2002-04-10 Thread Greg KH
Hi, This patch against the 2.5.8-pre3 kernel adds /proc/tty support for all of the usb serial drivers. This is something I wanted to add for a while, and only recently realized that the tty layer offered a very easy interface for this (supply a read_proc or write_proc function pointer, and the t

Re: [linux-usb-devel] Re: 2.5.8-pre3: kernel BUG at usb.c:849! (preempt_count 1)

2002-04-10 Thread Duncan Sands
On Wednesday 10 April 2002 8:25 pm, Pierre Rousselet wrote: > Duncan Sands wrote: > > S: Manufacturer=ALCATEL > > S: Product=Speed Touch USB > > OT, which SpeedTouch driver is it, working with 2.5.8-pre3 ? The user space driver (http://speedtouch.sourceforge.net). I spent some time fixing races

Re: [linux-usb-devel] Re: 2.5.8-pre3: kernel BUG at usb.c:849! (preempt_count 1)

2002-04-10 Thread Duncan Sands
On Wednesday 10 April 2002 7:23 pm, David Brownell wrote: > > > And what usb device driver(s) were supposed to have stopped > > > using "device 3"? I've only noticed such device refcounting bugs > > > being caused by the USB device drivers with bad disconnect() > > > routines, not usbcore or any

Re: [linux-usb-devel] Re: 2.5.8-pre3: kernel BUG at usb.c:849! (preempt_count1)

2002-04-10 Thread Pierre Rousselet
Duncan Sands wrote: > S: Manufacturer=ALCATEL > S: Product=Speed Touch USB OT, which SpeedTouch driver is it, working with 2.5.8-pre3 ? Pierre -- Pierre Rousselet <[EMAIL PROTECTED]> __

[linux-usb-devel] catc: GFP_KERNEL in interrupt or with spinlocks held

2002-04-10 Thread Oliver Neukum
Hi Vojtech, bad usage of mem_flags in catc. Regards Oliver --- catc.c.alt Wed Apr 10 20:11:53 2002 +++ catc.c Wed Apr 10 20:19:56 2002 @@ -278,7 +278,7 @@ atomic_dec(&catc->recq_sz); dbg("getting extra packet");

Re: [linux-usb-devel] selecting usb network devices

2002-04-10 Thread Petko Manolov
David Brownell wrote: > > Although this does make me wonder if I should expose the individual > types of device supported by "usbnet" as separate CONFIG_ options. > Support for some of them is more robust/complete than for others. > Comments? As Greg said this should be up to you. :-)

Re: [linux-usb-devel] selecting usb network devices

2002-04-10 Thread David Brownell
> > It's up to the driver's author to take CONFIG_EXPERIMENTAL off of it. > > I'll gladly take a patch from them to remove it. > > Here is the patch. I pulled out 3 devices from the experimental list > which i am sure are quite mature. Fine with me -- thanks! Although this does make me wonde

Re: [linux-usb-devel] selecting usb network devices

2002-04-10 Thread Greg KH
On Wed, Apr 10, 2002 at 10:30:35AM -0700, Petko Manolov wrote: > > It's up to the driver's author to take CONFIG_EXPERIMENTAL off of it. > > I'll gladly take a patch from them to remove it. > > Here is the patch. I pulled out 3 devices from the experimental list > which i am sure are quite matur

Re: [linux-usb-devel] selecting usb network devices

2002-04-10 Thread Petko Manolov
> It's up to the driver's author to take CONFIG_EXPERIMENTAL off of it. > I'll gladly take a patch from them to remove it. Here is the patch. I pulled out 3 devices from the experimental list which i am sure are quite mature. There may be more so if the authors may add some more if they feel li

Re: [linux-usb-devel] Re: 2.5.8-pre3: kernel BUG at usb.c:849!(preempt_count 1)

2002-04-10 Thread David Brownell
> > And what usb device driver(s) were supposed to have stopped > > using "device 3"? I've only noticed such device refcounting bugs > > being caused by the USB device drivers with bad disconnect() > > routines, not usbcore or any of the host controller drivers, but of > > course that can change.

[linux-usb-devel] Re: removing sleep_on in hub.c

2002-04-10 Thread Greg KH
On Wed, Apr 10, 2002 at 01:52:16AM -0400, Johannes Erdfelt wrote: > On Mon, Apr 08, 2002, Oliver Neukum <[EMAIL PROTECTED]> wrote: > > using sleep_on is a race. The attached patch replaces it with the > > new wait_event macro from sched.h. The patch is against the 2.5 > > from Greg. > > Greg, I'v

[linux-usb-devel] Re: [cset]patch to fix a race in kaweth

2002-04-10 Thread Greg KH
On Wed, Apr 10, 2002 at 07:06:00PM +0200, Oliver Neukum wrote: > Hi, > > kaweth has a race between timeout, xmit and disconnect. > The included patch against 2.5 should fix it. Your mailer mangled this changeset, I get the following error when trying to import it: ===

[linux-usb-devel] Re: 2.5.8-pre3: kernel BUG at usb.c:849! (preempt_count 1)

2002-04-10 Thread Duncan Sands
Ok, I got a new oops, which I could decode: ksymoops 2.4.5 on i586 2.5.8-pre3. Options used -V (default) -k /var/log/ksymoops/20020410185940.ksyms (specified) -l /var/log/ksymoops/20020410185940.modules (specified) -o /lib/modules/2.5.8-pre3/ (specified) -m /boot/System.

[linux-usb-devel] Re: 2.5.8-pre3: kernel BUG at usb.c:849! (preempt_count 1)

2002-04-10 Thread Robert Love
On Wed, 2002-04-10 at 11:41, Johannes Erdfelt wrote: > > <3>error: rmmod[1787] exited with preempt_count 1 > > I don't like the looks of that. That error means a task exited with a nonzero preempt_count, in this case 1. This means a lock was held after exit (or, a lock was never unlocked - e.

Re: [linux-usb-devel] Re: 2.5.8-pre3: kernel BUG at usb.c:849! (preempt_count 1)

2002-04-10 Thread Duncan Sands
On Wednesday 10 April 2002 6:40 pm, you wrote: > > > UP x86 K6 system running 2.5.8-pre3 with preemption. > > > Using usb-uhci. I got the following bug when powering off: > > > > > > usb.c: USB disconnect on device 3 > > > ... > > Does the same BUG happen with "uhci"? I haven't been able to repr

[linux-usb-devel] Re: 2.5.8-pre3: kernel BUG at usb.c:849! (preempt_count 1)

2002-04-10 Thread Duncan Sands
On Wednesday 10 April 2002 5:41 pm, you wrote: > On Wed, Apr 10, 2002, Duncan Sands <[EMAIL PROTECTED]> wrote: > > UP x86 K6 system running 2.5.8-pre3 with preemption. > > Using usb-uhci. I got the following bug when powering off: > > > > usb.c: USB disconnect on device 3 > > kernel BUG at usb.c:

Re: [linux-usb-devel] Re: 2.5.8-pre3: kernel BUG at usb.c:849!(preempt_count 1)

2002-04-10 Thread David Brownell
> > UP x86 K6 system running 2.5.8-pre3 with preemption. > > Using usb-uhci. I got the following bug when powering off: > > > > usb.c: USB disconnect on device 3 > > ... Does the same BUG happen with "uhci"? And what usb device driver(s) were supposed to have stopped using "device 3"? I've onl

Re: [linux-usb-devel] Wrong sanity check in audio.c

2002-04-10 Thread Greg KH
On Tue, Apr 09, 2002 at 08:52:15PM +0200, Thomas Sailer wrote: > Even though I originally implemented it, the sanity check removed > by the patch below seems wrong to me... I don't understand, do you want me to apply this patch? Is this to fix the bug reported on lkml? thanks, greg k-h __

Re: [linux-usb-devel] selecting usb network devices

2002-04-10 Thread Greg KH
On Wed, Apr 10, 2002 at 12:23:45AM -0700, Petko Manolov wrote: > Oliver Neukum wrote: > > > >OK, I found it. The whole subsection depends on CONFIG_EXPERIMENTAL. > > Oh, well. Some of the drivers are quite stable so i thing they could > be excluded from the experimental list. Namely kaweth, usb

[linux-usb-devel] Re: 2.5.8-pre3: kernel BUG at usb.c:849! (preempt_count 1)

2002-04-10 Thread Johannes Erdfelt
On Wed, Apr 10, 2002, Duncan Sands <[EMAIL PROTECTED]> wrote: > UP x86 K6 system running 2.5.8-pre3 with preemption. > Using usb-uhci. I got the following bug when powering off: > > usb.c: USB disconnect on device 3 > kernel BUG at usb.c:849! > invalid operand: > CPU:0 > EIP:0010:[]

[linux-usb-devel] 2.5.8-pre3: kernel BUG at usb.c:849! (preempt_count 1)

2002-04-10 Thread Duncan Sands
UP x86 K6 system running 2.5.8-pre3 with preemption. Using usb-uhci. I got the following bug when powering off: usb.c: USB disconnect on device 3 kernel BUG at usb.c:849! invalid operand: CPU:0 EIP:0010:[]Not tainted EFLAGS: 00010246 eax: ebx: cb8e2800 ecx: cb8e2550

Re: [linux-usb-devel] selecting usb network devices

2002-04-10 Thread Oliver Neukum
On Wednesday 10 April 2002 08:41, Petko Manolov wrote: > >>>in Greg's last 2.5 kernel I can't select any usb network > >>>devices. Is this just me ? > >> > >>Do you get a "Networking support is needed for USB Networking device > >>support" message? Or just nothing for the network devices? > > > >

Re: [linux-usb-devel] selecting usb network devices

2002-04-10 Thread Petko Manolov
Oliver Neukum wrote: > > OK, I found it. The whole subsection depends on CONFIG_EXPERIMENTAL. Oh, well. Some of the drivers are quite stable so i thing they could be excluded from the experimental list. Namely kaweth, usbnet, pegasus... Greg, what do you think? Petkan _