Re: [linux-usb-devel] kernel panic in 2.5.65

2003-03-20 Thread David Brownell
I get the following log each time I disconnect a hub (had to type it from the display, so its not complete). I do not have the problem with 2.5.64. I see something like this also when unloading a host controller driver. I had one of those, then it went away when I removed that check of yours tha

whiteheat - Re: [linux-usb-devel] usb-serial driver audit

2003-03-20 Thread Oliver Neukum
> whiteheat.c whiteheat_attach: usb_clear_halt(serial->dev, pipe); ret = usb_bulk_msg (serial->dev, pipe, command, sizeof(command), &alen, COMMAND_TIMEOUT); DMA on stack whiteheat_write: result = usb_submit_urb(urb, GFP_ATOMIC); no need for ATOMIC here s

[linux-usb-devel] usb-serial driver audit

2003-03-20 Thread Greg KH
Hi all, Since the big usb-serial semaphore has been gone for the usb-serial drivers for a while now in 2.5, I've been trying to audit all of the drivers to make sure that they are still SMP safe. I think I've either fixed up, or validated that there are no problems in the following drivers:

Re: [linux-usb-devel] Belkin Compact Flash card reader

2003-03-20 Thread Matthew Dharm
On Thu, Mar 20, 2003 at 05:01:46PM -0500, Alan Stern wrote: > On Thu, 20 Mar 2003, Dave Turner wrote: > > > On Thu, 20 Mar 2003 at 10:47am, Alan Stern wrote: > > > > > Can you post an extract from the kernel log under 2.4.21-rc5 with > > > usb-storage debugging turned on? > > > > Sure thing. > >

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.3, 2003/03/19 11:23:08-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: get rid of atmsar There are really only two patches: add atmsar stuff into speedtouch.c; and update the Makefile. The other changes are: delete atmsar.c and atmsar.h, rename speedtouch.c to speedtch.c.

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.9, 2003/03/20 14:00:11-08:00, [EMAIL PROTECTED] [PATCH] USB: Update for usb-skeleton My update for usb-skeleton seems to have gotten lost in the shuffle, so here it is again -- all wrapped up in one nice little patch. It's been tested by three different people and passed with

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.8, 2003/03/20 13:54:20-08:00, [EMAIL PROTECTED] [PATCH] USB: pegasus: fix up GFP_DMA usages. (bugzilla.kernel.org #418) drivers/usb/net/pegasus.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff -Nru a/drivers/usb/net/pegasus.c b/drivers/usb/net/pegasus

[linux-usb-devel] [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.1, 2003/03/19 11:21:52-08:00, [EMAIL PROTECTED] [PATCH] USB: fix to synchronous API regarding memory allocation some part of the synchronous API is used in the block io error handling code paths. Therefore it may use only GFP_NOIO, not GFP_KERNEL. - avoid deadlock due to wron

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.11, 2003/03/20 14:03:46-08:00, [EMAIL PROTECTED] [PATCH] USB: new ids for scanner driver This patch adds new vendor/product ids for various scanners. drivers/usb/image/scanner.c |5 +++-- drivers/usb/image/scanner.h | 13 + 2 files changed, 16 insertions(+)

[linux-usb-devel] [BK PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
Hi, Here are some small USB changes. Some speedtouch movements, and some small bugfixes, nothing major. There is a bug when removing hubs that is still present in 2.5.65, that I can reproduce but haven't tracked down yet... Please pull from: bk://linuxusb.bkbits.net/linus-2.5 thanks, greg k-

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.5, 2003/03/19 15:41:23-08:00, [EMAIL PROTECTED] [PATCH] USB: Memleak in drivers/usb/hub.c::usb_reset_device Hello! On Fri, Mar 14, 2003 at 11:37:19AM -0800, Greg KH wrote: > >There seems to be a memleak in drivers/usb/hub.c::usb_reset_device() > >on error exit path. Se

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.10, 2003/03/20 14:03:23-08:00, [EMAIL PROTECTED] [PATCH] USB HID: Ignore P5 Data Glove (2.4 and 2.5 patches) As requested, here are the 2.4 (latest BK tree) and 2.5 (latest bk tree) patches to ignore the non-HID Essential Reality Data Glove (again, user-space lib to acce

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.7, 2003/03/20 13:43:12-08:00, [EMAIL PROTECTED] [PATCH] USB: whiteheat bugfix (bugzilla.kernel.org #314) drivers/usb/serial/whiteheat.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -Nru a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c ---

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.2, 2003/03/19 11:22:14-08:00, [EMAIL PROTECTED] [PATCH] USB speedtouch: cosmetic comment changes drivers/usb/misc/speedtouch.c | 53 +++--- 1 files changed, 14 insertions(+), 39 deletions(-) diff -Nru a/drivers/usb/misc/speedtouch.c b/d

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.4, 2003/03/19 13:09:22-08:00, [EMAIL PROTECTED] [PATCH] USB: ehci-hcd, prink tweaks A not-very interesting patch, it just cleans up some debug output. drivers/usb/host/ehci-dbg.c |6 +++--- drivers/usb/host/ehci-hcd.c | 15 --- 2 files changed, 11 insertion

[linux-usb-devel] Re: [PATCH] USB changes for 2.5.65

2003-03-20 Thread Greg KH
ChangeSet 1.1143.1.6, 2003/03/19 15:41:50-08:00, [EMAIL PROTECTED] [PATCH] USB: reduce stack usage in cdc-ether This patch to 2.5.64 reduces the large stack usage in log_device_info() [and makes it static to boot]. drivers/usb/net/cdc-ether.c | 20 1 files changed, 16 in

[linux-usb-devel] Re: [PATCH 2.4] USB: New ids for scanner driver

2003-03-20 Thread Greg KH
On Thu, Mar 20, 2003 at 05:19:22PM +0100, Henning Meier-Geinitz wrote: > Hi, > > this patch adds some more vendor/product ids for the USB scanner driver. Applied, thanks. greg k-h --- This SF.net email is sponsored by: Tablet PC. Does your

Re: [linux-usb-devel] kernel panic in 2.5.65

2003-03-20 Thread Greg KH
On Thu, Mar 20, 2003 at 02:29:17PM +0100, Spang Oliver wrote: > Hi All, > > I get the following log each time I disconnect a hub (had to type it > from the display, so its not complete). I do not have the problem with > 2.5.64. I see something like this also when unloading a host controller drive

[linux-usb-devel] Re: [PATCH 2.5] USB: new ids for scanner driver

2003-03-20 Thread Greg KH
On Thu, Mar 20, 2003 at 05:34:39PM +0100, Henning Meier-Geinitz wrote: > Hi, > > This patch adds new vendor/product ids for various scanners. Applied, thanks. greg k-h --- This SF.net email is sponsored by: Tablet PC. Does your code think i

Re: [linux-usb-devel] Belkin Compact Flash card reader

2003-03-20 Thread Alan Stern
On Thu, 20 Mar 2003, Dave Turner wrote: > On Thu, 20 Mar 2003 at 10:47am, Alan Stern wrote: > > > Can you post an extract from the kernel log under 2.4.21-rc5 with > > usb-storage debugging turned on? > > Sure thing. > > Linux version 2.4.21-pre5 ([EMAIL PROTECTED]) (gcc version 2.95.3 20010315

Re: [linux-usb-devel] question on interaction with driver core

2003-03-20 Thread Oliver Neukum
Am Donnerstag, 20. März 2003 22:01 schrieb Matthew Dharm: > In my experience, resetting is rare. If you do need it, it's probably > because the device isn't compliant and wasn't going to work anyway. > > So, why don't we just move the reset into the core, and then every driver > (including usb-sto

Re: [linux-usb-devel] question on interaction with driver core

2003-03-20 Thread Matthew Dharm
In my experience, resetting is rare. If you do need it, it's probably because the device isn't compliant and wasn't going to work anyway. So, why don't we just move the reset into the core, and then every driver (including usb-storage) can get reset all at once? That sidesteps the issue, I think

Re: [linux-usb-devel] kernel panic in 2.5.65

2003-03-20 Thread David Brownell
Spang Oliver wrote: Hi All, I get the following log each time I disconnect a hub (had to type it from the display, so its not complete). I do not have the problem with 2.5.64. A more complete oops trace would help of course; if you could use a serial console, or even just hack the stack dump code

Re: [linux-usb-devel] question on interaction with driver core

2003-03-20 Thread Oliver Neukum
> I've actually been thinking along those lines, too... but, given the new > design where devices aren't 'remembered', doing the above would disconnect > a device and create a new one (as seen by the user). It kinda defeats the > entire purpose of the reset (which is to try to get back to a good

Re: [linux-usb-devel] e400: host controller halted. very bad

2003-03-20 Thread Johannes Erdfelt
On Tue, Mar 18, 2003, Duncan Sands <[EMAIL PROTECTED]> wrote: > This is with latest Linus BK. From the system log, during boot: > > kernel: drivers/usb/class/usblp.c: usblp0: nonzero read/write bulk status received: > -104 > kernel: drivers/usb/class/usblp.c: usblp0: error -104 reading from prin

Re: [linux-usb-devel] question on interaction with driver core

2003-03-20 Thread Matthew Dharm
On Thu, Mar 20, 2003 at 11:32:45AM -0500, Alan Stern wrote: > Requiring every driver which might be bound to an interface that is part > of a storage device to avoid GFP_KERNEL feels too draconian to me. Maybe > it would be better simply to remove the usb_reset_device() call from > usb-storage, or

Re: [linux-usb-devel] Belkin Compact Flash card reader

2003-03-20 Thread Dave Turner
On Thu, 20 Mar 2003 at 10:47am, Alan Stern wrote: > Can you post an extract from the kernel log under 2.4.21-rc5 with > usb-storage debugging turned on? Sure thing. Linux version 2.4.21-pre5 ([EMAIL PROTECTED]) (gcc version 2.95.3 20010315 (release)) #1 Wed Mar 19 16:17:04 GMT 2003 [snip] usb.

[linux-usb-devel] [PATCH 2.5] USB: new ids for scanner driver

2003-03-20 Thread Henning Meier-Geinitz
Hi, This patch adds new vendor/product ids for various scanners. Bye, Henning diff -u -r linux-2.5.65/drivers/usb/image/scanner.c linux-2.5.65-newids6/drivers/usb/image/scanner.c --- linux-2.5.65/drivers/usb/image/scanner.c2003-03-17 22:43:50.0 +0100 +++ linux-2.5.65-newids6/dri

Re: [linux-usb-devel] question on interaction with driver core

2003-03-20 Thread Alan Stern
On Wed, 19 Mar 2003, Matthew Dharm wrote: > I'm not certain this is a problem... > > I know blocking is legal in the SCSI error-handling context. Other I/O > will continue during this time. > > I have to think about this some more > > Matt > > On Thu, Mar 20, 2003 at 12:48:02AM +0100, Oli

Re: [linux-usb-devel] cleanup of synchronous API

2003-03-20 Thread David Brownell
Here's an updated version of Oliver's patch, changing: - uses "struct completion" for simplicity - the wait_event_timeout() logic is now like the other macros which can return before the event happens: returns a value - clarity for MAX_SCHEDULE_TIMEOUT scenarios, by using the standard "

Re: [linux-usb-devel] cleanup of synchronous API

2003-03-20 Thread Oliver Neukum
Am Donnerstag, 20. März 2003 17:03 schrieb Alan Stern: > On Thu, 20 Mar 2003, Oliver Neukum wrote: > > > were doing it, I'd not use the synchronous unlink call; > > > "ought not" to matter, but we can be more sure than that. > > > > That's dangerous. We must have absolute confidence about whether >

[linux-usb-devel] [PATCH 2.4] USB: New ids for scanner driver

2003-03-20 Thread Henning Meier-Geinitz
Hi, this patch adds some more vendor/product ids for the USB scanner driver. Bye, Henning diff -u -r linux-2.4.21-pre5.newids5/drivers/usb/scanner.c linux-2.4.21-pre5.newids6/drivers/usb/scanner.c --- linux-2.4.21-pre5.newids5/drivers/usb/scanner.c 2003-02-28 13:48:29.0 +0100 +

Re: [linux-usb-devel] cleanup of synchronous API

2003-03-20 Thread Alan Stern
On Thu, 20 Mar 2003, Oliver Neukum wrote: > > were doing it, I'd not use the synchronous unlink call; > > "ought not" to matter, but we can be more sure than that. > > That's dangerous. We must have absolute confidence about whether > the message has gone over the wire or not. > Suppose it's a re

Re: [linux-usb-devel] Belkin Compact Flash card reader

2003-03-20 Thread Alan Stern
On Wed, 19 Mar 2003, Dave Turner wrote: > On Wed, 19 Mar 2003 at 10:05am, Alan Stern wrote: > > > Dave: > > > > You didn't say what version of Linux you were running. Try installing > > 2.4.21-current and see if that makes a difference. A couple of changes > > were made to the usb-storage drive

[linux-usb-devel] kernel panic in 2.5.65

2003-03-20 Thread Spang Oliver
Hi All, I get the following log each time I disconnect a hub (had to type it from the display, so its not complete). I do not have the problem with 2.5.64. regards, Oliver ds: 007b es: 007b ss:0068 Process swapper (pid: 0, threadinfo=c02d6000 task=c0275360 Stack: 0082 c10c8520 08048034