[linux-usb-devel] Re: [PATCH] usb/core/hcd-pci.c: don't free_irq() on suspend

2005-09-30 Thread Greg KH
Daniel, are you sure about this patch (the second part specifically)? It directly conflicts with a set of patches in my current tree in this area that fix all of the reported suspend/resume issues with usb host controllers (that patch series written by David Brownell.) Yeah, I see that we should

Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio

2005-09-30 Thread Linus Torvalds
On Fri, 30 Sep 2005, Chris Wright wrote: > > Sorry, I missed the thread up to this, but this looks fundamentally > broken. The kill_proc_info_as_uid() idea is not sufficient because more > than uid/euid are needed for permission check. There's capabilities and > security labels. Not for this

Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio

2005-09-30 Thread Chris Wright
* Linus Torvalds ([EMAIL PROTECTED]) wrote: > Not for this particular USB use, there isn't. Since you can only send a > signal to yourself anyway, the uid/euid check is just testing that you're > still who you were. Ah, I see. thanks, -chris ---

[linux-usb-devel] Re: [Linux-usb-users] Possible bug in usb storage (2.6.11 kernel)

2005-09-30 Thread Ralf Baechle
On Thu, Sep 29, 2005 at 01:27:05AM +0900, Atsushi Nemoto wrote: > > On Tue, 27 Sep 2005 11:38:35 -0400 (EDT), Alan Stern <[EMAIL > > PROTECTED]> said: > > stern> If that is so, it's a bug in linux-mips. ARCH_KMALLOC_MINALIGN > stern> is supposed to be at least as large as a cacheline.

[linux-usb-devel] Re: [PATCH] usb-storage: Readd missing SDDR-05b unusual_devs entry

2005-09-30 Thread Phil Dibowitz
Daniel Drake wrote: > Just noticed that the SDDR-05b entry is missing for the shuttle_usbat > driver. Looking through BK history it was removed in this patch: > > http://linux.bkbits.net:8080/linux-2.6/[EMAIL PROTECTED] > > > However, at merge time, it looks like the duplicate was already remove

Re: [linux-usb-devel] Re: 2.6.13-mm2

2005-09-30 Thread Linus Torvalds
On Wed, 28 Sep 2005, David Brownell wrote: > > You could try adding > > ohci_writel(ohci, OHCI_INTR_MIE, &ohci->regs->intrdisable); > > near the end of ohci_pci_suspend(). Btw, wouldn't this make more sense in ohci_hub_suspend()? That would pair up with the resume, and there seems to

Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio

2005-09-30 Thread Linus Torvalds
On Fri, 30 Sep 2005, Harald Welte wrote: > > I'm probably the person in this thread who understands the least about > the USB stack and the scheduler, but if there is no implementation of > Linus' suggested "PID approach" yet, I'd be willing to write a patch and > test it. Please let me know. H

[linux-usb-devel] Re: [2.4.30] RFCOMM race

2005-09-30 Thread gl
On Thu, 29 Sep 2005, Marcel Holtmann wrote: How: it forks, the child tries to connect to a non-existing peer, at this time the parent issues ioctl(HCIDEVDOWN); ioctl(HCIDEVUP); the DOWN wakes the child up and it dows ioctl(HCIDEVDOWN) too. That's it. On the USB-analyser I see an incomplete HCI R

[linux-usb-devel] [PATCH] usb-storage: Readd missing SDDR-05b unusual_devs entry

2005-09-30 Thread Daniel Drake
Just noticed that the SDDR-05b entry is missing for the shuttle_usbat driver. Looking through BK history it was removed in this patch: http://linux.bkbits.net:8080/linux-2.6/[EMAIL PROTECTED] However, at merge time, it looks like the duplicate was already removed, compare these two revisions:

[linux-usb-devel] [PATCH] usb-storage: Some minor shuttle_usbat cleanups

2005-09-30 Thread Daniel Drake
A while ago, Matthew Dharm wrote: Looks good. Tho, I would like to see a future patch to do two things: 1) Change comments from C++ style to C-style 2) Make sure we're naming consistently everywhere SCM, USBAT, USBAT-02 (most noticably needing fixing is the string used at

Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio

2005-09-30 Thread Harald Welte
On Tue, Sep 27, 2005 at 10:02:16AM -0700, Linus Torvalds wrote: > On Tue, 27 Sep 2005, Sergey Vlasov wrote: > > > > The initial patch added get_task_struct()/put_task_struct() calls to > > fix this - are they forbidden too? > > They are sure as hell not something that a _driver_ is supposed to us

[linux-usb-devel] Flight Sim controllers from CH Products

2005-09-30 Thread Esa Hyytiä
Hi! SUMMARY: It seems that neither 2.4 or 2.6 kernels support usb-joysticks from CH products ('yoke' and 'pedals', sold separately). The patch, http://mail.flightgear.org/pipermail/flightgear-users/2002-November/002571.html has been available for 3 years but for some reason has not made it t

Re: [linux-usb-devel] Re: A easy question hopefully! Is it possible to run OHCI as "device" gagdget ?

2005-09-30 Thread Ian Campbell
On Thu, 2005-09-29 at 08:53 -0700, David Brownell wrote: > But it's got a PCI card slot yes? In which case a net2280 PCI card > can be used... It does have a PCI slot so that's quite a good idea. Thanks. Ian. -- Ian Campbell, Senior Design Engineer Web: h

[linux-usb-devel] [PATCH pd34] Add unusual_devs for iPod Nano

2005-09-30 Thread Phil Dibowitz
This adds US_FL_FIX_CAPACITY for yet _another_ entire block of Apple productIds. They really can't seem to get this right. This one is for the iPod Nano. Reported by Tyson Vinson <[EMAIL PROTECTED]>. Greg, please apply. Signed-off-by: Phil Dibowitz <[EMAIL PROTECTED]> -- Phil Dibowitz

Re: [linux-usb-devel] [PATCH 2.6.14] Support to a new USB Flash Disk

2005-09-30 Thread Phil Dibowitz
Otavio Salvador wrote: > Hello, > > I include the entry to one usb flash disk that had problem here. I > think is really good to include it on 2.6.14 since its very trivial > and worked fine here. I'm not a big fan of doing the entire - range unless you have some idea that lots of devices

Re: [linux-usb-devel] RFC drivers/usb/storage/libusual

2005-09-30 Thread Phil Dibowitz
Pete Zaitcev wrote: > Patch is attached. I would like someone to look it over and challenge it. > The thing looks too complex to me, but I see no other way. Anyone? OK, so I'm not very familiar with a lot of the code affected here, but since it diddles with unusual_devs, I feel I should chime in.