[linux-usb-devel] Re: [usb-storage] MAX_SECTORS_nnn

2006-05-25 Thread Phil Dibowitz
Phil Dibowitz wrote: > Phil Dibowitz wrote: >> It sounds like we have a consensus then. I'll try to get a patch to: >> >> - Add a MAX_SECTORS_64 flag >> - Incorporate Benjamin's device >> - Remove the Genesys logic (this will be the second genesys special-case that >> I've replaced with a flag ;)

[linux-usb-devel] Re: [usb-storage] MAX_SECTORS_nnn

2006-05-25 Thread Phil Dibowitz
Phil Dibowitz wrote: > It sounds like we have a consensus then. I'll try to get a patch to: > > - Add a MAX_SECTORS_64 flag > - Incorporate Benjamin's device > - Remove the Genesys logic (this will be the second genesys special-case that > I've replaced with a flag ;) ) > > Shouldn't take me ve

[linux-usb-devel] ub: atomic add_disk

2006-05-25 Thread Pete Zaitcev
I am taling about this: "if (disk->flags & GENHD_FL_UP) del_gendisk(disk);" If del_gendisk() undoes add_disk() like viro just said, why is it conditional? huh? add_disk() sets the damn flag So, I should not need to check ever so the above is "if I've called add_disk(), call gendisk()" whic

[linux-usb-devel] ub: random cleanups

2006-05-25 Thread Pete Zaitcev
Remove some silly messages and cast in stone "temporary" messages which we keep around. Also, I am hesitant to remove the initialization retries without having the hardware to test (anyone who was at KS04 has a spare?) Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]> --- linux-2.6.17-rc5-gregkh/dr

Re: [linux-usb-devel] resetting high speed usb device

2006-05-25 Thread David Brownell
On Thursday 25 May 2006 7:27 pm, Alan Stern wrote: > > So I guess we close this chapter, I can live with the resets (shouldn't > > look so much into the log files, or?). > > Well, don't be in too big a hurry to give up. If you're having these > problems, the chances are reasonably good that othe

[linux-usb-devel] Re: [linux-pm] [patch/rft 2.6.17-rc2] swsusp resume must not device_suspend()

2006-05-25 Thread David Brownell
On Tuesday 02 May 2006 9:12 am, Patrick Mochel wrote: > On Thu, Apr 27, 2006 at 12:41:28PM -0700, David Brownell wrote: > > > There does seem to be agreement that the current FREEZE invocation is not > > sufficient. I'm looking at a slightly different solution now ... one which > > unfortunately

Re: [linux-usb-devel] resetting high speed usb device

2006-05-25 Thread Alan Stern
On Thu, 25 May 2006, Norbert Preining wrote: > Hi Alan! > > On Don, 25 Mai 2006, Alan Stern wrote: > > I don't know whether such a change would be acceptable in general. > > Perhaps it would, especially if we jump to Handle_Errors only for data-OUT > > transfers. > > Please keep in mind that I

Re: [linux-usb-devel] resetting high speed usb device

2006-05-25 Thread Norbert Preining
Hi Alan! On Don, 25 Mai 2006, Alan Stern wrote: > I don't know whether such a change would be acceptable in general. > Perhaps it would, especially if we jump to Handle_Errors only for data-OUT > transfers. Please keep in mind that I am *NOT* searching for a hand-made solution for me! I just wa

Re: [linux-usb-devel] Re: 2.6.17-rc4-mm2 (hard lockup after resume from disk on AMD64)

2006-05-25 Thread Rafael J. Wysocki
On Thursday 25 May 2006 22:29, Alan Stern wrote: > On Sun, 21 May 2006, Rafael J. Wysocki wrote: > > > On Saturday 20 May 2006 23:30, Andrew Morton wrote: > > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > > > > On Saturday 20 May 2006 14:41, Andrew Morton wrote: > > > > > > > > > >

Re: [linux-usb-devel] Re: 2.6.17-rc4-mm2 (hard lockup after resume from disk on AMD64)

2006-05-25 Thread David Brownell
On Thursday 25 May 2006 1:29 pm, Alan Stern wrote: > On Sun, 21 May 2006, Rafael J. Wysocki wrote: > > > > > Obviously it's this one: > > > > gregkh-usb-usb-ohci-avoids-root-hub-timer-polling.patch > > > > [Well, looks like it hasn't been tested properly before posting ... :-(] > > Did this eve

Re: [linux-usb-devel] resetting high speed usb device

2006-05-25 Thread Alan Stern
On Thu, 25 May 2006, Norbert Preining wrote: > Hi all! > > On Mit, 24 Mai 2006, Alan Stern wrote: > > It might not be a bad idea to follow Pete's advice and use usbmon. > > Done. > > On Mit, 24 Mai 2006, Pete Zaitcev wrote: > > I suggest looking for -104 (unlink). It can be done with grep. Us

Re: [linux-usb-devel] Re: 2.6.17-rc4-mm2 (hard lockup after resume from disk on AMD64)

2006-05-25 Thread Alan Stern
On Sun, 21 May 2006, Rafael J. Wysocki wrote: > On Saturday 20 May 2006 23:30, Andrew Morton wrote: > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > > On Saturday 20 May 2006 14:41, Andrew Morton wrote: > > > > > > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches

Re: [linux-usb-devel] resetting high speed usb device

2006-05-25 Thread Norbert Preining
Hi Alan! On Don, 25 Mai 2006, Alan Stern wrote: > If you want to try an interesting test, go back to the > usb_stor_invoke_transport() routine in transport.c, just above the > Handle_Errors line. Where it says: > > /* Did we transfer less than the minimum amount required? */ > if (sr

Re: [linux-usb-devel] resetting high speed usb device

2006-05-25 Thread Alan Stern
On Thu, 25 May 2006, Norbert Preining wrote: > Hi Alan! > > On Don, 25 Mai 2006, Alan Stern wrote: > > If you want to try an interesting test, go back to the > > usb_stor_invoke_transport() routine in transport.c, just above the > > Handle_Errors line. Where it says: > > > > /* Did we trans

Re: [linux-usb-devel] [RFC] USB port resets for multi-interface devices

2006-05-25 Thread Alan Stern
On Thu, 25 May 2006, Greg KH wrote: > On Wed, May 24, 2006 at 04:04:02PM -0400, Alan Stern wrote: > > Here is a patch that adds a new routine to usbcore: > > usb_reset_composite_device(). The routine is a wrapper around > > usb_reset_device(), but before doing the reset it warns all drivers bou

Re: [linux-usb-devel] resetting high speed usb device

2006-05-25 Thread Alan Stern
On Thu, 25 May 2006, Norbert Preining wrote: > Hi all! > > On Don, 25 Mai 2006, Alan Stern wrote: > > If you want to try an interesting test, go back to the > > usb_stor_invoke_transport() routine in transport.c, just above the > > Handle_Errors line. Where it says: > > Ok, I did this: > > >

Re: [linux-usb-devel] resetting high speed usb device

2006-05-25 Thread Norbert Preining
Hi all! On Don, 25 Mai 2006, Alan Stern wrote: > If you want to try an interesting test, go back to the > usb_stor_invoke_transport() routine in transport.c, just above the > Handle_Errors line. Where it says: Ok, I did this: > /* Did we transfer less than the minimum amount required? */

Re: [linux-usb-devel] [RFC] USB port resets for multi-interface devices

2006-05-25 Thread Greg KH
On Wed, May 24, 2006 at 04:04:02PM -0400, Alan Stern wrote: > Here is a patch that adds a new routine to usbcore: > usb_reset_composite_device(). The routine is a wrapper around > usb_reset_device(), but before doing the reset it warns all drivers bound > to the affected device, and after the r

[linux-usb-devel] [PATCH 2.6.16.18] USB OHCI DRIVER: ohci-hcd.c doesn't compile as module when USB_OHCI_HCD_PPC_SOC and PCI are set

2006-05-25 Thread Jan Capek
Hi, I have come across an issue when compiling the ohci-hcd driver as module when PCI and USB_OHCI_HCD_PPC_SOC are both enabled. The compilation of USB subsystem fails due to the fact that ohci-hcd.c has some of its components(ohci-pci.c, ohci-ppc-soc.c and others) conditionally included via #

Re: [linux-usb-devel] resetting high speed usb device

2006-05-25 Thread Norbert Preining
Hi all! On Mit, 24 Mai 2006, Alan Stern wrote: > It might not be a bad idea to follow Pete's advice and use usbmon. Done. On Mit, 24 Mai 2006, Pete Zaitcev wrote: > I suggest looking for -104 (unlink). It can be done with grep. Use Attached is the region around the first -104, I hope I didn't

[linux-usb-devel] Re: usb: io_edgeport, cleanup to unicode handling

2006-05-25 Thread Pete Zaitcev
On Thu, 25 May 2006 02:15:37 -0500, Al Borchers <[EMAIL PROTECTED]> wrote: > One minor thing, I would prefer "sizeof(string)" to "30", but > it is not crucial. Done in my tree. I'll either send a follow-up to Greg or resend, depending on the acceptance. -- Pete

[linux-usb-devel] Re: usb: io_edgeport, cleanup to unicode handling

2006-05-25 Thread Al Borchers
Pete -- Thanks for checking with us. Looks good to me. One minor thing, I would prefer "sizeof(string)" to "30", but it is not crucial. -- Al Quoting Pete Zaitcev <[EMAIL PROTECTED]>: > Clean up the unicode handling in io_edgeport. Make get_string size-limited. > > Signed-off-by: Pete Zaitcev