sjhill wrote:
> I have hit a bug using a PPC7448 processor with a PCI EHCI USB
> controller. Atomic operations for reference counting are failing
> and I am interested to hear what others have to say on this.
>
> Looking in the MPC7450 RISC Microprocessor Family Reference Manual
> (MPC7450UM, Rev.
and the include of .
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
--- linux-2.6/drivers/usb/host/ohci-ppc-soc.c.old 2005-08-09
10:46:37.0 -0700
+++ linux-2.6/drivers/usb/host/ohci-ppc-soc.c 2005-08-09 11:03:44.0
-0700
@@ -14,8 +14,6 @@
* This file is licenced
[ This patch has been submitted previously, but hasn't been acted upon.
It's a fairly obvious typo. Please apply. ]
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
--- linux-2.6/drivers/usb/host/ohci-ppc-soc.c.old 2005-08-09
10:46:37.0 -0700
+++ linux-2.6/
On Thu, Jun 16, 2005 at 10:18:01AM +, Jochen Karrer wrote:
> Hi,
> I need an OHCI with Register and DMA descriptor byteorder separate
> switchable.
>
> A PCI machine has little endian OHCI registers and little endian Endpoint
> and transfer descriptors. For a non PCI OHCI (Netsilicon NS9750 AR
This patch avoids a null-pointer dereference and fixes a typo.
Signed-off-by: Sylvain Munaut <[EMAIL PROTECTED]>
Acked-by: Dale Farnsworth <[EMAIL PROTECTED]>
---
= drivers/usb/host/ohci-ppc-soc.c 1.2 vs edited =
--- 1.2/drivers/usb/host/ohci-ppc-soc.c 2005-03-08 05:
On Mon, Mar 21, 2005 at 04:56:33PM +, Sylvain Munaut wrote:
> ohci: Small fixes to ohci-ppc-soc.c
>
> This patch avoids a null-pointer dereference and fixes a typo.
I didn't see any responses to this. Is it in the queue?
Thanks,
-Dale
--
le
This patch avoids a null-pointer dereference and fixes a typo.
Acked-by: Dale Farnsworth <[EMAIL PROTECTED]>
= ohci-ppc-soc.c 1.2 vs edited =
--- 1.2/drivers/usb/host/ohci-ppc-soc.c 2005-03-08 05:43:18 +01:00
+++ edited/ohci-ppc-soc.c 2005-03-19 16:06:23 +01:00
@@ -73,7 +
-*/
Diff to create drivers/usb/host/ohci-ppc-soc.c, the USB OHCI glue file
for PPC SOC implementations.
diff -Nru a/drivers/usb/host/ohci-ppc-soc.c b/drivers/usb/host/ohci-ppc-soc.c
--- /dev/null Wed Dec 31 16:00:00 196900
+++ b/drivers/usb/host/ohci-ppc-soc.c 2005-01-25 14:17:10 -07:00
@@ -
e.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
--- a/drivers/usb/host/Kconfig 2004-12-02 15:54:46 -07:00
+++ b/drivers/usb/host/Kconfig 2004-12-02 15:54:46 -07:00
@@ -14,6 +14,8 @@
default y if ARCH_OMAP
d the
PPC-specific OCP driver interface. Here, I have changed to the
platform_device driver interface.
Thanks,
-Dale
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
--- a/drivers/usb/host/Kconfig 2004-12-02 15:54:46 -07:0
; hc16_to_cpu(ohci, v)
le16_to_cpup(v) --> hc16_to_cpup(ohci, v)
le32_to_cpu(v) --> hc32_to_cpu(ohci, v)
le32_to_cpup(v) --> hc32_to_cpup(ohci, v)
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/ohci-dbg.c b/drivers/usb/host/ohci-dbg
hwPSW[2], etc. Since we only use one of the hwPSW array
elements, we need to allocate two because the hardware
accesses hwPSW[1]. I centralized the handling of this
quirk in the ohci_hwPSW function.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
--
hardware uses in this order: hwPSW[1], hwPSW[0], hwPSW[3],
hwPSW[2], etc. Since we only use one of the hwPSW array elements,
we need to allocate two because the hardware accesses hwPSW[1].
I centralized the handling of this quirk in the ohci_hwPSW function.
Signed-off-by: Dale Farnsworth <[EMA
Patch 1 of 3.
Replace little-endian-only constants in ohci.h with cpu-native
constants, so that they can be converted to little-endian or big-endian
depending on the OHCI controller being used.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/ohci-dbg.c b/d
On Thu, Oct 14, 2004 at 05:06:32PM +, David Brownell wrote:
> On Wednesday 13 October 2004 4:45 pm, Dale Farnsworth wrote:
> > I tried to apply them on top of 2.6.9-rc4-mm1, and patch #1 applied
> > with offsets. Patch #2 got lots of rejects. I'll re-gen the patch
On Thu, Oct 14, 2004 at 12:18:06PM +, Stergios Spanos wrote:
> I am having trouble applying the patches posted for
> the Big-Endian OHCI support.
>
> I am using the 2.6.9-rc4 original kernel (kernel.org).
> The patches are applied with just some hunks but what
> happens is that thekernel
hardware uses in this order: hwPSW[1], hwPSW[0], hwPSW[3],
hwPSW[2], etc. Since we only use one of the hwPSW array elements,
we need to allocate two because the hardware accesses hwPSW[1].
I centralized the handling of this quirk in the ohci_hwPSW function.
Signed-off-by: Dale Farnsworth <[EMA
; hc16_to_cpu(ohci, v)
le16_to_cpup(v) --> hc16_to_cpup(ohci, v)
le32_to_cpu(v) --> hc32_to_cpu(ohci, v)
le32_to_cpup(v) --> hc32_to_cpup(ohci, v)
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/ohci-dbg.c b/drivers/usb/host/ohci-dbg
Patch 1 of 3.
Replace little-endian-only constants in ohci.h with cpu-native
constants, so that they can be converted to little-endian or big-endian
depending on the OHCI controller being used.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/ohci-dbg.c b/d
hwPSW[2], etc. Since we only use one of the hwPSW array
elements, we need to allocate two because the hardware
accesses hwPSW[1]. I centralized the handling of this
quirk in the ohci_hwPSW function.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
--
On Wed, Oct 13, 2004 at 09:54:41PM +, David Brownell wrote:
> On Wednesday 13 October 2004 2:23 pm, Dale Farnsworth wrote:
> > The following 3 patches add support big-endian OHCI implementations.
> >
> > This is version 3 of these patches. There are no substantive
>
I posted this before, but didn't see any discussion.
This patch fixes a couple of places where the usb subsystem
DMAs to/from local (stack) variables. This doesn't work on
non-cache-coherent processors. I'm testing on PPC 4xx systems.
Signed-off-by: Dale Farnsworth <[EMAIL
hardware uses in this order: hwPSW[1], hwPSW[0], hwPSW[3],
hwPSW[2], etc. Since we only use one of the hwPSW array elements,
we need to allocate two because the hardware accesses hwPSW[1].
I centralized the handling of this quirk in the ohci_hwPSW function.
Signed-off-by: Dale Farnsworth <[EMA
; hc16_to_cpu(ohci, v)
le16_to_cpup(v) --> hc16_to_cpup(ohci, v)
le32_to_cpu(v) --> hc32_to_cpu(ohci, v)
le32_to_cpup(v) --> hc32_to_cpup(ohci, v)
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/ohci-dbg.c b/drivers/usb/host/oh
Patch 1 of 3.
Replace little-endian-only constants in ohci.h with cpu-native
constants, so that they can be converted to little-endian or big-endian
depending on the OHCI controller being used.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/ohci-dbg.c b/d
W[3],
hwPSW[2], etc. Since we only use one of the hwPSW array
elements, we need to allocate two because the hardware
accesses hwPSW[1]. I centralized the handling of this
quirk in the ohci_hwPSW function.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
---
Subject should have been: Add Big-endian ... oh, well.
On Fri, Aug 20, 2004 at 03:03:34PM +, David Brownell wrote:
> On Thursday 19 August 2004 9:02 pm, Dale Farnsworth wrote:
>
> > I would like to get these patches into the linux-2.6 tree soon.
> > I think they are rea
his order: hwPSW[1], hwPSW[0], hwPSW[3],
hwPSW[2], etc. Since we only use one of the hwPSW array
elements, we need to allocate two because the hardware
accesses hwPSW[1]. I centralized the handling of this
quirk in the ohci_hwPSW function.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]&g
ey take on the beXX forms when only big-endian controllers
are supported.
A bit in the flags field of struct ohci_hcd, OHCI_BIG_ENDIAN,
enables the the transformed functions to support both big-endian
and little-endian controllers at runtime, when needed.
Signed-off-by: Dale Farnsworth <[EMAI
d is needed for both little-endian
and big-endian controllers on non-cache-consistent processors.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
---
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-
Replace little-endian-only constants in ohci.h with
cpu-native constants, so that they can be converted
to little-endian or big-endian depending on the OHCI
controller being used.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/ohci-dbg.c b/drivers/usb/hos
lt is an array of big-endian u16 elements which the OHCI
hardware uses in this order: hwPSW[1], hwPSW[0], hwPSW[3], hwPSW[2], etc.
Below is the patch I'm using on 2.6. It should give you enough
information to get it going on 2.4.
I'll post an update of my full 2.6 big-endian ohci su
On Thu, Aug 12, 2004 at 08:20:41PM +, Oliver Neukum wrote:
> Am Donnerstag, 12. August 2004 20:39 schrieb Dale Farnsworth:
> > diff -Nru a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> > --- a/drivers/usb/core/message.c2004-08-12 11:21:18 -07:00
> &
This patch fixes a couple of places where addresses of variables on
the stack were being used a targets of USB DMA. Stack corruption has
been observed on a PPC 4xx system without this patch.
Please apply.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/class/a
On Tue, Aug 03, 2004 at 02:43:34AM +, David Brownell wrote:
> On Monday 02 August 2004 15:48, Dale Farnsworth wrote:
> > This 3-part patch adds support for the big-endian OHCI implementations
> > found on IBM's stb04xxx and Freescale's MPC52xx processors.
>
>
endian controllers at runtime, if needed.
Patch 3 Adds support for ohci controllers (big-endian) on STB04xxx and MPC52xx
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/Kconfig b/drivers/usb/Kconfig
--- a/drivers/usb/Kconfig 2004-08-02 13:33:46 -07:00
+++ b/dri
endian controllers at runtime, if needed.
Patch 3 Adds support for ohci controllers (big-endian) on STB04xxx and MPC52xx
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h
--- a/drivers/usb/host/ohci.h 2004-08-02 13:31:00 -07:00
endian controllers at runtime, if needed.
Patch 3 Adds support for ohci controllers (big-endian) on STB04xxx and MPC52xx
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h
--- a/drivers/usb/host/ohci.h 2004-08-02 13:30:26 -07:00
38 matches
Mail list logo