Hi,
> When entered, the menu point "USB DSL modem support" in menuconfig, path
> [Device Drivers->USB
> Support] shows no entries but "^@" instead. The following fixes it.
is the problem that there are no entries, or that "^@" is displayed? If there
are no
entries then presumably you didn't tu
Hi Indan,
> So there's a (suspicious) gap of 60 seconds between loading the speedtch
> driver
> and finding the firmware. With 2.6.20 this used to be 10 seconds.
>
> Just booted different kernel versions to verify, so it can't be a user space
> issue.
> The kernel config may have changed slight
On Thursday 10 May 2007 14:12:47 Indan Zupancic wrote:
> Hello,
>
> On Thu, May 10, 2007 03:38, Jeff Garzik wrote:
> >
> > This was ACK'd by Greg, as you see in the sign-offs. See the commit
> > below for rationale.
> >
> > USB is now treated like other buses, for network drivers:
> > * USB netwo
On Friday 23 February 2007 17:16:24 Alan Stern wrote:
> On Fri, 23 Feb 2007, Duncan Sands wrote:
>
> > if you get ESHUTDOWN, does that mean that you are about to be disconnected,
> > i.e. the disconnect method is about to be called? Or is it possible for the
> > device to
Hi Pete,
On Friday 23 February 2007 00:53:18 Pete Zaitcev wrote:
> On Thu, 22 Feb 2007 11:43:38 +0100, Duncan Sands <[EMAIL PROTECTED]> wrote:
> > > + /* the module/device has probably been removed */
> > > + if (urb->status == -ESHUTDOWN)
> > I personally think that loading firmware in the probe routine is okay
> > and I fully agree with you that the less complexity in the driver the
> > better. Loading the firmware will almost always have to block since the
> > device can't be used before the firmware loading has been finished.
>
> > So to my mind the importance of this patch is in improving correctness
> > (lack of
> > deadlocks) and responsiveness (newly plugged USB devices turn up at once,
> > even
> > if some other device is doing a long wait in its probe method), rather than
> > performance.
>
> Would it be better t
On Tuesday 5 December 2006 18:02, Oliver Neukum wrote:
> Am Dienstag, 5. Dezember 2006 16:54 schrieb Duncan Sands:
>
> > it is helpful for devices that want to upload firmware in their probe
> > method. Getting the firmware from the firmware subsystem can take a long
> &g
Hi Alan,
> > > By the way, have you observed any significant improvements in peformance
> > > from this patch? I don't have any experience with systems having lots of
> > > USB devices attached. For that matter, does speeding up khubd make any
> > > significant change to the overall boot time
> On third look, why does this driver submit an URB for data
> it never reads? There's something fishy. It even more or less ignores
> the status.
The speedtouch driver does the same thing: at strategic moments it
reads a bunch of bytes from the modem, without doing anything with
them, not even lo
Hi Ilyes, you won't be able to allocate that much *contiguous* memory,
but you should be able to allocate enough non-contiguous memory (e.g.
by calling __get_free_page 256 times; not the same as calling
__get_free_pages(8) !). To use that memory, you can try using the usb
scatter/gather support (s
On Wednesday 8 November 2006 21:17, David Brownell wrote:
> > I don't know what fxload does exactly,
>
> You can then read its manpage ... :)
>
> Or see the section on the topic at
>
> http://linux-hotplug.sourceforge.net/?selected=usb
>
> which gives complete examples of:
>
> >
On Wednesday 8 November 2006 19:49, David Brownell wrote:
> > > Use fxload. Keeping your driver as simple as possible is a good reason.
> >
> > May be, but fxload doesn't seem really maintained/used anymore.
>
> It certainly gets used, and ISTR every patch submitted in the past
> several years has
> Ok, I managed to run the tests today and got surprised a bit.
> ...
> Then, if my tests aren't wrong and if I'm not missing anything important
> I say Duncan is right and we have no benefits of having these functions
> as functions. :)
It's not that surprising! Have a look at usb_endpoint_di
On Thursday 26 October 2006 18:02, Luiz Fernando N.Capitulino wrote:
> Signed-off-by: Luiz Fernando N. Capitulino <[EMAIL PROTECTED]>
Acked-by: Duncan Sands <[EMAIL PROTECTED]>
-
Using Tomcat but need to d
> This patch series ports almost all the code in the USB tree to use the
> endpoint info functions. The only missing directory is the gadget one.
Why aren't these endpoint info functions given as inlined functions
in usb.h? They all seem to be one-liners, so having them inlined
should be a win.
On Wednesday 11 October 2006 22:43, Pete Zaitcev wrote:
> On Wed, 11 Oct 2006 19:44:43 +, Pavel Machek <[EMAIL PROTECTED]> wrote:
>
> > Does it mean text interface is now deprecated? Or perhaps ioctl should
> > be added to text interface too? Or maybe we do not need binary
> > interface if we
> does anybody have trouble with 2.6.19-rc1?
Not here.
Ciao,
Duncan.
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
> Maybe UEAGLE can do something a little more sensible...
What is the modem supposed to do if it receives a packet to
transmit after it has been told to suspend? This is a real
question, I'm not pretending! I've never thought about or
read about suspend/resume and have no idea how it is supposed
>From http://doc.ubuntu-fr.org/materiel/zxdsl852.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
index 04631dc..3034ec7 100644
--- a/drivers/usb/atm/cxacru.c
+++ b/drivers/usb/atm/cxacru.c
@@ -793,6 +793,9 @@ static con
oyo, who noticed the relationship
between these magic numbers and the entries in Phonebook.ini.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
diff --git a/drivers/usb/atm/speedtch.c b/drivers/usb/atm/speedtch.c
index 956b7a1..353a84e 100644
--- a/drivers/usb/atm/speedtch.c
+++ b/drivers/usb/atm
If usbatm_do_heavy_init finishes before usbatm_heavy_init
writes the pid, the disconnect method could shoot down the
wrong process if the pid has been recycled.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c
index a38701c..d
Hi Pavel,
> > Signed-off-by: matthieu castet <[EMAIL PROTECTED]>
> > Index: linux/drivers/usb/atm/ueagle-atm.c
> > ===
> > --- linux.orig/drivers/usb/atm/ueagle-atm.c 2006-09-22 21:39:56.0
> > +0200
> > +++ linux/drivers/usb/
> No, this patch won't apply to 2.6.17 -- it's 2.6.18 only. There was a
> separate patch (as753) already submitted for 2.6.17-stable.
OK, then that means that yet another patch is needed for 2.6.17! Here's
a summary of the situation. This patch for 2.6.17
http://bugzilla.kernel.org/atta
> This patch should be sent to Linus before 2.6.18 is released, since it
> fixes a bug that was introduced in 2.6.18-rc1.
It would be good if it went into the next 2.6.17-stable too, since it fixes
a regression in 2.6.17 (hanging internet connection with speedtouch modems).
Ciao,
Duncan.
-
> Recently people have reported a bug affecting ADSL modems in the UHCI
> driver for 2.6.17. Perhaps it is related to your problem.
This is likely a different problem, since it seems to be about isochronous
urbs unlike the speedtouch modem problem.
> The driver in 2.6.18-rc2 seems to work better
Hi Alan, I've been getting reports of problems with speedtouch modems in 2.6.17,
and the problems seem to come from your patch (as623) "UHCI: use one QH per
endpoint,
not per URB".
Here are the problem descriptions:
Antonello: "I just downloaded linux kernel 2.6.17.1 and compiled as usual.
Afte
On Saturday 3 June 2006 08:31, Dan Lenski wrote:
> Hi all,
> I'm a USB driver noob trying my hand at getting a Keyspan IR receiver
> to work. I thought I'd try the usbfs_snoop patch which I read about
> in Greg Kroah's article.
>
> I've enabled usbfs_snoop at runtime with echo 1 >
> /sys/module/u
Hi Alan,
> So here's the question: Is it better to remove the Get-Device-Status
> request, and along with it, the commented-out test for self-powered
> configs on a bus-powered device, or should I keep the request and
> reinstate the test (thereby making that MP3 player and my USB keyboard
> d
We #include only because
needed it, but didn't #include it itself. But that's been fixed now.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/xusbatm.c
===
--- Linux.orig/drivers/u
Remove pointless inline.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/usbatm.c
===
--- Linux.orig/drivers/usb/atm/usbatm.c 2006-04-28 18:30:35.0 +0200
+++ Linux/drivers/usb/atm/us
Because of the way stringify works, using an expression
like 64 * 1024 for UDSL_MAX_BUF_SIZE results in 64 * 1024
turning up in the modinfo output instead of 65536. So use
65536 directly (this was the only way I found of fixing this).
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index:
urbs. It would be nice to base the altsetting
on the detected line speed, but that's hard given the current design.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/speedtch.c
===
--- Linux.orig/
Hi Sergey,
>...
>> Looks like a problem which was fixed in 2.6.16.1:
>
> http://kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=commitdiff;h=048eb7e760ef41bcfef09bbd223f18379d260c2c
>
> (and you are apparently looking at the source where this bug is already
> fixed).
it looks li
Hi Pete,
> This looks like something may be of interest for you. In the fresh kernel
> we shipped (2.6.15 with no relevant patches), modem cannot get its firmware,
> and eventually ends with this:
>
> EIP is at firmware_data_write+0xfe/0x152
> Process nash-hotplug (pid: 307, threadinfo=c1678000 t
> > My computer always freezes after a few minutes with the following
> > workload:
> > - watching TV with xawtv
bttv? overlay or grabdisplay? What motherboard?
Ciao,
D.
---
This SF.Net email is sponsored by xPML, a groundbreaking scriptin
de Ven <[EMAIL PROTECTED]>
Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/cxacru.c
===
--- Linux.orig/drivers/usb/atm/cxacru.c 2006-01-13 09:35:07.0
> Hi Greg, this is the usbatm part of the Arjan, Jes and Info
Too much star trek! Sorry about that Ingo.
Best wishes,
Duncan.
---
This SF.net email is sponsored by: Splunk Inc. Do
Hi Greg, this is the usbatm part of the Arjan, Jes and Info
mass semaphore to mutex conversion, reworked to apply on top
of the patches I just sent to you.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/cx
> I only got 2 of these, is my mail just being slow (which it does at odd
> times), or did you stop sending them based on some problems on your end?
Hi Greg, I stopped because I noticed that part of patch 2 had slipped
into patch 3 (the bit that slipped was exactly the tweak I made to patch 2
to h
Don't throttle on -EILSEQ urb status if requested by a minidriver.
It seems the ueagle modems are buggy, giving -EILSEQ when they
have no data to send. The ueagle change will be sent separately
by the ueagle guys. Patch by Matthieu Castet.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/speedtch.c
===
--- Linux.orig/drivers/usb/atm/speedtch.c 2006-01-13 09:23:12.0 +0100
+++ Linux/drivers/usb/atm/speedtch.c 2006-01-13
The receive logic has always assumed that urbs contain an integral
number of ATM cells, which is a bit naughty, though it never caused
any problems with bulk transfers. Isochronous urbs spank us soundly
for this. Fixed thanks to this patch, mostly by Stanislaw Gruszka.
Signed-off-by: Duncan
transfer by setting the new
UDSL_USE_ISOC flag. The speedtch minidriver gets a new module
parameter enable_isoc (defaults to false), plus some logic that
checks for the existence of an isoc receive endpoint (not all
speedtouch modems have one).
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
need to set the correct alternate setting
for the interface in their bind routine. This is the reason for
the speedtch changes.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/usbatm.c
===
---
In one spot (usbatm_cancel_send) we were calling dev_kfree_skb with irqs
disabled. This mistake is just too easy to make, so systematically use
dev_kfree_skb_any rather than dev_kfree_skb.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/us
We weren't always returning -ENOMEM.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/usbatm.c
===
--- Linux.orig/drivers/usb/atm/usbatm.c 2006-01-13 08:57:48.0 +0100
+++ Linux/driv
cted. Users with a buggy atmarpd can simply restart
it after disconnecting the modem.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/usbatm.c
===
--- Linux.orig/drivers/usb/atm/usbatm.c 2006
borked. Here is a rewrite that works.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/xusbatm.c
===
--- Linux.orig/drivers/usb/atm/xusbatm.c 2006-01-13 08:48:09.0 +0100
+++ Linux/drivers/u
Convert kmalloc + memset to kzalloc.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/cxacru.c
===
--- Linux.orig/drivers/usb/atm/cxacru.c 2006-01-13 08:48:09.0 +0100
+++ Linux/drivers/u
Remove the unused .owner field in struct usbatm_driver.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/cxacru.c
===
--- Linux.orig/drivers/usb/atm/cxacru.c 2006-01-13 08:46:17.0 +0100
+++
> I only got 2 of these, is my mail just being slow (which it does at odd
> times), or did you stop sending them based on some problems on your end?
I stopped sending them based on problems on my end. I'll send the rest
tomorrow.
Ciao,
Duncan.
-
Have minidrivers and the core signal special requirements
using a flags field in struct usbatm_data. For the moment
this is only used to replace the need_heavy_init bind
parameter, but there'll be new flags in later patches.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
diff -x
Sorry, it wasn't a -p1 patch (I should really automate this).
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
diff -x '*.orig' -x '*.base' -u -r Linux/drivers/usb/atm.orig/cxacru.c Linux/drivers/usb/atm/cxacru.c
--- Linux/drivers/usb/atm.orig/cxacru.c 2006
Formatting, changes to variable names, comments, log level changes,
printk rate limiting.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: kernel/cxacru.c
===
--- kernel.orig/cxacru.c 2006-01-10 08:42:02.0
Hi Greg, here are some fixes and improvements to the USB ATM
modem drivers, in thirteen patches:
01: trivial modifications (formatting, changes to variable names,
comments, log level changes, printk rate limiting).
02: have minidrivers tell the core about special requirements
using a flags field.
On Wednesday 30 November 2005 23:30, Greg KH wrote:
> On Wed, Nov 30, 2005 at 09:09:06AM +0100, Duncan Sands wrote:
> > > diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
> > > index 79861ee..9d59dc6 100644
> > > --- a/drivers/usb/atm/cxacru.c
> &
cked up, and a closing bracket is missing after Well
PTI-800...
Try this:
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: cxacru.c
===
RCS file: /home/cvs/speedtch/cxacru.c,v
retrieving revision 1.39
retrieving revision
Hi Mitch,
On Thursday 17 November 2005 14:59, Mitchell Blank Jr wrote:
> Duncan Sands wrote:
> > > Or we can just ressurect the patch I made 2 years ago that just kills
> > > ATM_ITF_ANY since it's a really bad idea and always was:
> > > http://sourceforge
Hi Alan,
On Wednesday 16 November 2005 21:07, Alan Stern wrote:
> On Wed, 16 Nov 2005, Duncan Sands wrote:
>
> > The problem here is the way ATM connections are opened: you specify
> > a device number, called the interface number, as well as some other info.
> > Altern
Hi Pete,
On Thursday 17 November 2005 00:35, Pete Zaitcev wrote:
> On Wed, 16 Nov 2005 17:12:52 +0100, Duncan Sands <[EMAIL PROTECTED]> wrote:
>
> > With the speedtouch USB modems, the problem people usually see is:
>
> > (C) at some point the modem spontaneously
Hi Alan, thanks for taking the time to reply.
> > I think it's safe to assume that if a USB device is disconnected and
> > reconnected
> > then the old USB device will have called shutdown_atm_dev (this is called
> > in the
> > disconnect method) before the new USB device creates an ATM device (
Hi Mitch,
> Or we can just ressurect the patch I made 2 years ago that just kills
> ATM_ITF_ANY since it's a really bad idea and always was:
> http://sourceforge.net/mailarchive/message.php?msg_id=6032218
> (Note: that patch also adds auto-loading of devices)
why is it a bad idea?
> The real p
Hi Roman, glad to see you're still alive!
On Wednesday 2 November 2005 11:46, Roman Kagan wrote:
> On Tue, Nov 01, 2005 at 01:04:02PM +, David Woodhouse wrote:
> > On Tue, 2005-11-01 at 13:40 +0100, Duncan Sands wrote:
> > > this code looks like a 'orrible hack to
On Wednesday 2 November 2005 09:45, Oliver Neukum wrote:
> Am Mittwoch, 2. November 2005 09:03 schrieb Greg KH:
> > On Wed, Nov 02, 2005 at 08:54:22AM +0100, Duncan Sands wrote:
> > > > > + * sometime hotplug don't have time to give the firmware the
>
On Wednesday 2 November 2005 08:45, David Woodhouse wrote:
> On Wed, 2005-11-02 at 08:42 +0100, Duncan Sands wrote:
> > we could do this for the speedtouch - in fact we used to do this: when
> > someone tried to open a connection, we loaded the firmware if it
> > hadn&#x
> > + * sometime hotplug don't have time to give the firmware the
> > + * first time, retry it.
> > + */
> > +static int sleepy_request_firmware(const struct firmware **fw,
> > + const char *name, struct device *dev)
> > +{
> > + if (request_firmware(fw, name, dev) == 0)
> > +
> > People get shouted at for adding /proc handlers. Greg may have thoughts...
> >
> Ok, we may be convert some values to sysfs. It would be nice if usbatm
> allow us to export some common value (margin, ...).
Yes it would be nice. Patches welcome :)
D.
-
> > this code looks like a 'orrible hack to work around a common problem
> > with USB modem's of this type: if the modem is plugged in while the
> > system boots, the driver may look for firmware before the filesystem
>
> No, it wasn't the problem, even when loading with insmod/modprobe the
> tim
Hi David,
On Tuesday 1 November 2005 14:04, David Woodhouse wrote:
> On Tue, 2005-11-01 at 13:40 +0100, Duncan Sands wrote:
> > this code looks like a 'orrible hack to work around a common problem
> > with USB modem's of this type: if the modem is plugged in while the
>
Hi Andrew,
> > +/*
> > + * sometime hotplug don't have time to give the firmware the
> > + * first time, retry it.
> > + */
> > +static int sleepy_request_firmware(const struct firmware **fw,
> > + const char *name, struct device *dev)
> > +{
> > + if (request_firmware(fw, name, dev)
Hi Alan, thanks for your clear answer.
> > The max packet size of the iso in endpoint is 640 bytes.
> > The data comes in as successive 53 byte long "ATM cells".
> > So I set the iso packet length to 636 bytes, which is
> > a multiple of 53. However I regularly see iso packets
> > with actual len
The max packet size of the iso in endpoint is 640 bytes.
The data comes in as successive 53 byte long "ATM cells".
So I set the iso packet length to 636 bytes, which is
a multiple of 53. However I regularly see iso packets
with actual length 636 and status -EOVERFLOW (uhci host
controller). Presu
> > What's more, in the particular case of urb completion callbacks there is
> > no guarantee that the callback is even called from an interrupt.
>
> Right, although there is a guarantee that local interrupts will be
> disabled when the completion handler is called. That guarantee may be
> remo
> > A driver using spin_lock_irq() in a tasklet is buggy. You can always use
> > irqsave. It will just be slower. But in a tasklet or interrupt handler
> > spin_lock() will do. Basically these locks differ in whether they shut down
> > irq processing on the local CPU. In interrupt it is down and mu
> > A driver using spin_lock_irq() in a tasklet is buggy. You can always use
> > irqsave. It will just be slower. But in a tasklet or interrupt handler
> > spin_lock() will do. Basically these locks differ in whether they shut down
> > irq processing on the local CPU. In interrupt it is down and mu
> When i connect my device (ethernet gadget) into the host. i get the message
>
>when i do dmesg on host.
>
> usbcore: registered new driver usbnet
> usb 2-2: new full speed USB device using address 6
> usb 2-2: device not accepting address 6, error -71
> usb 2-2: new full speed USB device
> > > I wonder why the invocations of kmalloc are needed in these functions.
> >
> > Because some architectures can't do DMA to/from the stack.
>
> doing dma to/from kmalloc also isn't too nice... should be using
> dma_alloc_*() API I guess
The USB core applies dma_map_single to the buffer, so i
> I wonder why the invocations of kmalloc are needed in these functions.
Because some architectures can't do DMA to/from the stack.
All the best,
Duncan.
---
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Fin
As the subject says: why is there no usb_fill_iso_urb
helper routine? I was looking around to see how various
drivers handle iso urb initialisation, and I noticed (for
example) that some of them don't initialise urb->lock...
Well, maybe it doesn't need to be initialised for iso urbs,
or maybe it d
Hi Alan,
> ? You sound confused.
seems so :)
> Configurations aren't changed as easily as altsettings. They can't be
> changed at all by drivers, normally. Remember, each configuration
> contains a set of interfaces, and drivers bind to interfaces. Change the
> config and you've got a com
> > but do we want to guarantee that the altsetting is always zero
> > when probe is called (likewise for configuration)? After all, drivers
> > can be responsible for setting the values they want.
>
> I think we do. Drivers should find their devices initially in the
> default state. That's wh
Hi Alan,
> > Suppose my driver's probe method is called for a device,
> > some initialisation is done (eg: I change the altsetting),
> > but finally the probe fails. Will the device state be
> > reset in any way before other drivers are probed?
>
> No. Do you think selecting altsetting 0 will r
Suppose my driver's probe method is called for a device,
some initialisation is done (eg: I change the altsetting),
but finally the probe fails. Will the device state be
reset in any way before other drivers are probed?
Thanks a lot,
Duncan.
> I see. Yes, you should use the serial number to identify which device
> corresponds to which parameter value. I don't know of any examples of
> drivers doing that, but it should be easy enough to write. And it will be
> reliable, no matter what the order of probing is -- even if devices are
> No way the difference is explained only by the step from 1.1 to 2.0
Why not?
All the best,
Duncan.
---
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles
the state didn't change, and (2) keeping
track of
the last state, not just the flag. We do (2) as well as (1) in order to get
better log
messages.
This is a tweaked version of the original patch by Aurelio Arroyo.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/driv
No functional change, but less likely to break in the future.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/speedtch.c
===
--- Linux.orig/drivers/usb/atm/speedtch.c 2005-06-23 09:02:45.508
Spotted by David Woodhouse.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
Index: Linux/drivers/usb/atm/cxacru.c
===
--- Linux.orig/drivers/usb/atm/cxacru.c 2005-06-20 22:42:35.0 +0200
+++ Linux/drivers/usb/atm/cx
Zero the entire instance, not just the struct usbatm_data head.
Make sure the just allocated urb is freed if we fail to allocate
a buffer. Based on a patch by Stanislaw W. Gruszka.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
--- Linux/drivers/usb/atm/usbatm.c.orig 2005-05-27
Reduce the number of "unknown vpi/vci" debug messages to (usually) at most
one per-urb, rather than one per-cell. This is only an issue when (a) many
packets come in but no connection is open; and (b) CONFIG_USB_DEBUG is set.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
--- L
On Fri, 2005-05-13 at 00:51 +0400, Roman Kagan wrote:
> On Thu, May 12, 2005 at 06:56:34PM +0200, Oliver Neukum wrote:
> > static inline int usbatm_submit_urb(struct urb *urb)
> >
> > You'll enter this with irqs off and will leave it with irqs on.
>
> Mind elaborating a bit? I can see that we ma
> Hm, no Signed-off-by: lines :(
>
> Also, can you put the patch descriptions in the individual emails? That
> way when they are applied it shows up properly.
Yeah, I'm out of practice. Let me try again...
D.
---
This SF.Net email is spons
Port the speedtch driver to the new usbatm core. The code is much
the same as before, just reorganized, though I threw in some minor
improvements (a new module parameter for choosing the altsetting,
more robust urb failure handling, ...) while I was there.
Signed-off-by: Duncan Sands <[EM
Driver for modems based on the Conexant AccessRunner chipset.
Original patch by Josep Comas, much reworked by Roman Kagan.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
--- Linux/drivers/usb/atm/cxacru.c.orig 1970-01-01 01:00:00.0 +0100
+++ Linux/drivers/usb/atm/cxacru.c 2005-05
Doesn't do any firmware loading etc, just transmission and reception.
The user needs to take care of modem initialization, and load the
module with parameters giving the endpoints to use and so forth.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
--- Linux/drivers/usb/atm/xusbatm.c.o
Makefile and Kconfig entries for the new drivers.
Signed-off-by: Duncan Sands <[EMAIL PROTECTED]>
--- Linux/drivers/usb/atm/Makefile.orig 2004-12-24 22:35:24.0 +0100
+++ Linux/drivers/usb/atm/Makefile 2005-05-11 17:04:24.0 +0200
@@ -1,7 +1,8 @@
#
-# Makefile for the rest
modems initialized in userspace
+ *
+ * Copyright (C) 2005 Duncan Sands, Roman Kagan (rkagan % mail ! ru)
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the Free
+ * Software Foundation; either
Otherwise known as Makefile and Kconfig updates.
--- Linux/drivers/usb/atm/Makefile.orig 2004-12-24 22:35:24.0 +0100
+++ Linux/drivers/usb/atm/Makefile 2005-05-11 17:04:24.0 +0200
@@ -1,7 +1,8 @@
#
-# Makefile for the rest of the USB drivers
-# (the ones that don't fit into any oth
on
+ * Conexant AccessRunner chipset
+ *
+ * Copyright (C) 2004 David Woodhouse, Duncan Sands, Roman Kagan
+ * Copyright (C) 2005 Duncan Sands, Roman Kagan (rkagan % mail ! ru)
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of
1 - 100 of 676 matches
Mail list logo
