Re: [linux-usb-devel] [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-28 Thread Jesper Juhl
On 29/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > Hi, > > On 7/29/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > > Hello, > > > > This patch makes sure we don't dereference a NULL pointer in > > drivers/net/usb/pegasus.c::write_bulk_ca

[linux-usb-devel] [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-28 Thread Jesper Juhl
that pointer until after that check. Please consider merging. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/net/usb/pegasus.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index a05fd97..04cb

Re: [linux-usb-devel] Problem: irq 217: nobody cared + backtrace

2006-08-04 Thread Jesper Juhl
On 04/08/06, Alan Stern <[EMAIL PROTECTED]> wrote: > On Fri, 4 Aug 2006, Jesper Juhl wrote: > > > On 03/08/06, Alan Stern <[EMAIL PROTECTED]> wrote: > > > > > > Has this happened more than once? > > > > Seems to happen consistently after ~

Re: [linux-usb-devel] Problem: irq 217: nobody cared + backtrace

2006-08-04 Thread Jesper Juhl
0x173/0x19d [] 0xc0100210 DWARF2 unwinder stuck at 0xc0100210 Leftover inexact backtrace: === handlers: [] (usb_hcd_irq+0x0/0x53) Disabling IRQ #217 -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.

[linux-usb-devel] Problem: irq 217: nobody cared + backtrace

2006-08-03 Thread Jesper Juhl
:usb4 209: 0 0 IO-APIC-level ehci_hcd:usb1 217: 99932 68 IO-APIC-level uhci_hcd:usb3 NMI: 178992 178964 LOC: 178936 178936 ERR: 0 MIS: 0 -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon

[linux-usb-devel] [PATCH] Resource leak fix for whiteheat driver

2006-04-23 Thread Jesper Juhl
We may return from drivers/usb/serial/whiteheat.c::whiteheat_attach() without freeing `result' if we leave via the no_firmware: label. Spotted by the coverity checker as #670 Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/usb/serial/whiteheat.c |1 + 1 files

[linux-usb-devel] Re: [PATCH] reduce syslog clutter (take 2)

2006-03-09 Thread Jesper Juhl
o not provide any useful information for that clientele. They just push The filename may not be useful to the user, but the instant the user decides to submit a bugreport to LKML or elsewhere it becomes useful. > the actual interesting information farther to the right, in this case > even ca

[linux-usb-devel] 2.6.15-mm2 allyesconfig build failure in drivers/usb/ip/

2006-01-10 Thread Jesper Juhl
of `setnodelay' drivers/usb/ip/vhci-hcd.o(.text+0x53b):drivers/usb/ip/usbip_common.c:484: first defined here make[3]: *** [drivers/usb/ip/built-in.o] Error 1 make[2]: *** [drivers/usb/ip] Error 2 make[1]: *** [drivers/usb] Error 2 make: *** [drivers] Error 2 -- Jesper Juhl <[EMAIL PROTECTED]> Don

[linux-usb-devel] [PATCH] usb: kfree cleanup for drivers/usb/* - no need to check for NULL

2005-04-12 Thread Jesper Juhl
Get rid of a bunch of redundant NULL pointer checks in drivers/usb/*, there's no need to check a pointer for NULL before calling kfree() on it. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- class/audio.c | 48 +++--- clas

[linux-usb-devel] Re: [PATCH] usb: kfree() cleanups in drivers/usb/core/devio.c

2005-04-12 Thread Jesper Juhl
On Tue, 12 Apr 2005, Greg KH wrote: > Date: Tue, 12 Apr 2005 00:40:56 -0700 > From: Greg KH <[EMAIL PROTECTED]> > To: Jesper Juhl <[EMAIL PROTECTED]> > Cc: linux-kernel@vger.kernel.org, Thomas Sailer <[EMAIL PROTECTED]>, > Greg Kroah-Hartman <[E

[linux-usb-devel] [PATCH] usb: kfree() cleanups in drivers/usb/core/devio.c

2005-04-11 Thread Jesper Juhl
Checking for NULL before calling kfree() is redundant. This patch removes these redundant checks and also makes a few tiny whitespace changes. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- devio.c | 32 1 files changed, 12 insertions(+), 20 del

[linux-usb-devel] Re: [PATCH] fix shared key auth in zd1201

2005-03-28 Thread Jesper Juhl
needs testing stuff in -mm for a while to shake out the bugs, but at the same time let the rest migrate onwards to Linus fairly quickly... If it's currently in -mm I'd just relax and wait for it to hit mainline in 2.6.12 or 2.6.13... -- Jesper Juhl ---

[linux-usb-devel] [PATCH][Doc][Trivial] Small fixups to the EHCI Kconfig help text

2004-10-26 Thread Jesper Juhl
Here's a small patch with a few tiny fixups for the EHCI Kconfig help text. Please consider applying. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> diff -u linux-2.6.10-rc1-bk5-orig/drivers/usb/host/Kconfig linux-2.6.10-rc1-bk5/drivers/usb/host/Kconfig --- linux-2.6.10-rc1-bk5-o

[linux-usb-devel] Re: Summarizing the PWC driver questions/answers

2004-08-27 Thread Jesper Juhl
pen drivers. You purchased a piece of hardware that depended on a closed source driver, no open source developer has any resonable commitment to support that. If you want to be constructive instead of just bitch and moan, then go talk to Philips and get them to release code or specs so we can ge