Re: [linux-usb-devel] [PATCH] usb-serial regression fix

2007-03-13 Thread Jim Radford
On Tue, Mar 13, 2007 at 09:55:41AM -0400, Mark Lord wrote: > Jim Radford wrote: > >On Mon, Mar 12, 2007 at 09:55:14PM -0400, Mark Lord wrote: > > > >>So where does the memory get freed -- the structure pointed at > >>by the serial->port[i] thingie ? It's

Re: [linux-usb-devel] [PATCH] usb-serial regression fix

2007-03-13 Thread Jim Radford
On Mon, Mar 12, 2007 at 09:55:14PM -0400, Mark Lord wrote: > Jim Radford wrote: > >On Mon, Mar 12, 2007 at 05:18:19PM -0700, Greg KH wrote: > >>On Mon, Mar 12, 2007 at 03:59:22PM -0700, Jim Radford wrote: > >>>On Mon, Mar 12, 2007 at 03:42:35PM -0700, Jim Radford wro

Re: [linux-usb-devel] [PATCH] usb-serial regression fix

2007-03-12 Thread Jim Radford
On Mon, Mar 12, 2007 at 05:18:19PM -0700, Greg KH wrote: > On Mon, Mar 12, 2007 at 03:59:22PM -0700, Jim Radford wrote: > > On Mon, Mar 12, 2007 at 03:42:35PM -0700, Jim Radford wrote: > > > On Mon, Mar 12, 2007 at 01:33:31PM -0700, Greg KH wrote: > > > > On Mon, Ma

[linux-usb-devel] [PATCH] usb-serial regression fix

2007-03-12 Thread Jim Radford
On Mon, Mar 12, 2007 at 03:42:35PM -0700, Jim Radford wrote: > On Mon, Mar 12, 2007 at 01:33:31PM -0700, Greg KH wrote: > > On Mon, Mar 12, 2007 at 04:22:22PM -0400, Mark Lord wrote: > > > Oliver Neukum wrote: > > > >>Mark Lord wrote: > > > >>>O

Re: [linux-usb-devel] [PATCH] usb-serial regression (Oops) in 2.6.21-rc*

2007-03-12 Thread Jim Radford
Works. > > This patch fixes the Oops that otherwise occurs whenever > > a USB serial adapter is unplugged from a system, as well > > the Oops seen when one is in use before resume (to RAM). > Argh, no, this change was done to help the ftdi drivers out. > Look at changes

Re: [linux-usb-devel] 2.6.21-rc3-mm2: oops in pl2303_shutdown

2007-03-08 Thread Jim Radford
On Thu, Mar 08, 2007 at 08:34:23PM -0800, Jim Radford wrote: > I get the following oopses when unplugging my Prolific PL2303 serial > adaptor. Sometimes I get one, sometimes the other. I think I've > seen something similar with the ftdi_sio driver as well, so I don't >

[linux-usb-devel] 2.6.21-rc3-mm2: oops in pl2303_shutdown

2007-03-08 Thread Jim Radford
I get the following oopses when unplugging my Prolific PL2303 serial adaptor. Sometimes I get one, sometimes the other. I think I've seen something similar with the ftdi_sio driver as well, so I don't think it started with 2.6.21-rc3-mm2. -Jim pl2303 ttyUSB0: pl2303 converter now disconnected f

[linux-usb-devel] [PATCH] ftdi_sio: use port_probe / port_remove thereby fixing access to the latency_timer

2007-02-28 Thread Jim Radford
time and to the serial port device itself, instead of to the unadorned usb device, avoiding a NULL dereference. Signed-Off: Jim Radford <[EMAIL PROTECTED]> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 4695952..abc4355 100644 --- a/drivers/usb/serial/ftdi

[linux-usb-devel] [PATCH] usb-serial: fix shutdown / device_unregister order

2007-02-28 Thread Jim Radford
On Thu, Feb 22, 2007 at 04:06:55PM -0800, Greg KH wrote: > On Thu, Feb 22, 2007 at 01:59:58PM -0800, Jim Radford wrote: > > One problem with this is that ->shutdown(), which cleans up my > > pointer, is called before device_unregister(). So now we have: > > ->attac

Re: [linux-usb-devel] [PATCH] ftdi_sio: fix access to the latency_timer and other attributes

2007-02-22 Thread Jim Radford
On Thu, Feb 22, 2007 at 01:29:19PM -0800, Jim Radford wrote: > On Thu, Feb 22, 2007 at 11:40:33AM -0800, Greg KH wrote: > > On Wed, Feb 21, 2007 at 03:28:51PM -0800, Jim Radford wrote: > > > Allow usb-serial driver's attach callback to create sysfs attributes, > >

[linux-usb-devel] [PATCH] ftdi_sio: fix access to the latency_timer and other attributes

2007-02-22 Thread Jim Radford
On Thu, Feb 22, 2007 at 11:40:33AM -0800, Greg KH wrote: > On Wed, Feb 21, 2007 at 03:28:51PM -0800, Jim Radford wrote: > > Allow usb-serial driver's attach callback to create sysfs attributes, > > by calling device_register, before calling ->attach(). > No, if you want

[linux-usb-devel] [PATCH 2/3] ftdi_sio: move the sysfs files to the usb_serial_port

2007-02-21 Thread Jim Radford
Move the sys files like the latency_timer to the more natural usb_serial_port instead of the usb_device. Signed-Off: Jim Radford <[EMAIL PROTECTED]> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 4695952..179cc53 100644 --- a/drivers/usb/serial/ftdi_sio.c

[linux-usb-devel] [PATCH 2/3] ftdi_sio: move the sysfs files to the usb_serial_port

2007-02-21 Thread Jim Radford
Move the sys files like the latency_timer to the more natural usb_serial_port instead of the usb_device. Signed-Off: Jim Radford <[EMAIL PROTECTED]> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 4695952..179cc53 100644 --- a/drivers/usb/serial/ftdi_sio.c

[linux-usb-devel] [PATCH 3/3] ftdi_sio: fix a NULL deference in the latency_timer show/store callbacks

2007-02-21 Thread Jim Radford
Fix a NULL deference in the latency_timer show/store callbacks. Signed-Off: Jim Radford <[EMAIL PROTECTED]> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -1023,12 +1023,10 @@ static s

[linux-usb-devel] [PATCH 1/3] usb-serial: device_register before calling attach

2007-02-21 Thread Jim Radford
Allow usb-serial driver's attach callback to create sysfs attributes, by calling device_register, before calling ->attach(). Signed-Off: Jim Radford <[EMAIL PROTECTED]> diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c --- a/drivers/usb/serial/usb-

[linux-usb-devel] [PATCH 0/3] ftdi_sio: fix oops on access to the latency_timer

2007-02-21 Thread Jim Radford
Hi Greg, This series of patches fixes a NULL pointer deference that occurs when accessing ftdi_sio driver's sysfs latency_timer. The latency_timer is currently created on the usb_device. I couldn't figure out how to easily "get" from the usb_device to the usb_serial_port in the callback, and it

[linux-usb-devel] keyspan oops on unplug/removal

2004-02-25 Thread Jim Radford
When I unplug my four port keyspan USB serial converter or remove the keyspan module I get a consistent oops. I'm running linux-2.6.3. Thanks for any help with this, -Jim Unable to handle kernel NULL pointer dereference at virtual address printing eip: e0e084b1 *pde = Oops: 00

[linux-usb-devel] [PATCH] New Pegasus Adaptor (Hawking UF100)

2002-01-27 Thread Jim Radford
I'm not sure about the DEFAULT_GPIO_RESET bit. Most if the others devices had it. It works for me. -Jim --- linux-2.4.17/drivers/usb/pegasus.h Sun Jan 27 11:34:07 2002 +++ linux/drivers/usb/pegasus.h Mon Jan 21 20:10:05 2002 @@ -145,6 +145,7 @@ #defineVENDOR_SMARTBRIDGES 0x08d1