[linux-usb-devel] [PATCH] default input core support to y

2003-10-11 Thread John Levon
It's quite easy to accidentally miss this option out. I think it makes sense to default it to yes if HID support is enabled. comments ? regards john Index: linux-cvs/drivers/usb/input/Kconfig === RCS file: /home/cvs/linux-2.5/driv

Re: [linux-usb-devel] Re: [PATCH 2.5] USB speedtouch: neater sanity check

2003-09-11 Thread John Levon
On Thu, Sep 11, 2003 at 03:06:24PM +0200, Duncan Sands wrote: > > I will gladly take patches to remove the other calls to BUG_ON() in this > > driver (hint...) > > What is the right thing to do when an assertion fails? > i.e. some condition that should never occur occurs. > In such cases it is no

[linux-usb-devel] BKL and usb_probe_interface

2003-09-09 Thread John Levon
I'm probably labouring under some fundamental misunderstanding here, but I'll plow on regardless. 83 /* needs to be called with BKL held */ 84 int usb_probe_interface(struct device *dev) is exposed to the driver model. Whilst I've not yet dis-entangled the call stack that gets here, I

Re: [linux-usb-devel] Speedtouch USB userspace driver fails after 2.6.0-test1

2003-08-22 Thread John Levon
On Fri, Aug 22, 2003 at 10:17:09AM -0400, Alan Stern wrote: > Has this been brought to the attention of the maintainers of the > Speedtouch or ppp drivers? I've brought it up on #speedtouch, but unfortunately the developer I spoke to cannot use USB on 2.6 at all yet, as it hangs for some reason.

Re: [linux-usb-devel] Speedtouch USB userspace driver fails after 2.6.0-test1

2003-08-22 Thread John Levon
On Wed, Aug 20, 2003 at 12:01:31PM -0400, Alan Stern wrote: > > + usb_set_interface(interface_to_usbdev(iface), > > + iface->altsetting[0].desc.bInterfaceNumber, > > + 0); > > If a program is trying to use an interface after a driver has released it, > this

Re: [linux-usb-devel] Speedtouch USB userspace driver fails after 2.6.0-test1

2003-08-19 Thread John Levon
On Tue, Aug 19, 2003 at 01:45:18PM -0700, David Brownell wrote: > On the other hand, I can imagine some of Alan's updates might > turn up bugs with drivers accessing endpoints that don't exist This could well be it; adding the hunk below causes a change from success to failure. An strace -f of th

Re: [linux-usb-devel] Speedtouch USB userspace driver fails after 2.6.0-test1

2003-08-19 Thread John Levon
On Tue, Aug 19, 2003 at 10:06:09AM -0700, David Brownell wrote: > No bright ideas beyond trying on non-UHCI hardware, sorry. Here : http://movementarian.org/usbhunks.diff is the diff I have got so far from binary searching starting from test2. Applying that diff to my tree -> failure; without

Re: [linux-usb-devel] Speedtouch USB userspace driver fails after 2.6.0-test1

2003-08-18 Thread John Levon
On Mon, Aug 18, 2003 at 06:43:39PM -0700, David Brownell wrote: > >The user-space driver is attempting to read from the device, and > >apparently failing on its first attempt with an -EPIPE. The previous run > >of "modem_run" seems to succeed though. > > Nothing you sent suggests EPIPE ... I acc

[linux-usb-devel] Speedtouch USB userspace driver fails after 2.6.0-test1

2003-08-18 Thread John Levon
Some time after 2.6.0-test1, and current Linus CVS, attempts to use pppd with my Alcatel Speedtouch USB modem fail. Greg KH suggested to me this was a ppp problem; however it does not seem so, as they only patches to any ppp code is in ppp_async, which isn't even loaded on my system. The user-spa

[linux-usb-devel] [PATCH] usbcld typo

2003-02-26 Thread John Levon
Against 2.5.63. I believe && is meant here, not &. regards john --- linux-linus/drivers/usb/misc/usblcd.c 2003-01-03 03:06:44.0 + +++ linux/drivers/usb/misc/usblcd.c 2003-02-26 18:36:59.0 + @@ -153,7 +153,7 @@ }

[linux-usb-devel] [PATCH] rio500 typo

2003-02-26 Thread John Levon
I believe && is meant here, but I cannot test it. This is against 2.5.63 regards john --- linux-linus/drivers/usb/misc/rio500.c 2003-01-10 21:12:07.0 + +++ linux/drivers/usb/misc/rio500.c 2003-02-26 18:36:34.0 + @@ -332,7 +332,7 @@