[linux-usb-devel] [PATCH] USB: In init_endpoint_class, use PTR_ERR to obtain an errno value, not IS_ERR

2007-01-25 Thread Josh Triplett
init_endpoint_class calls class_create, and checks the result for an error with IS_ERR; however, if true, it then returns the result of IS_ERR (a boolean) rather than PTR_ERR (the actual errno). Signed-off-by: Josh Triplett <[EMAIL PROTECTED]> --- drivers/usb/core/endpoint.c |2 +- 1

Re: [linux-usb-devel] [USB-hacking] [PATCH] usbfs2: bulk read and write

2007-01-21 Thread Josh Triplett
(k_buff); > +exit: > + return retval; > +} This also looks good to me. [...] > @@ -39,9 +149,11 @@ struct file_operations usb_endpoint_control_fops = { > struct file_operations usb_endpoint_in_fops = { > .owner =THIS_MODULE, > .open = endp

Re: [linux-usb-devel] [USB-hacking] [PATCH] usbfs2: added fops to endpoint character devices

2007-01-21 Thread Josh Triplett
int file operations */ > +extern struct file_operations usb_endpoint_control_fops; > +extern struct file_operations usb_endpoint_in_fops; > +extern struct file_operations usb_endpoint_out_fops; If you create the usb_endpoint_create_cdev function in endpoint_fops.c, you could remove these exte