Re: [linux-usb-devel] __FILE__ returns full path now?

2005-04-22 Thread Michael Tokarev
Randy.Dunlap wrote: On Mon, 18 Apr 2005 14:51:38 -0500 Stephen Morgan wrote: [] | Thanks Randy. So, is __FILE__ deprecated usage now? I know it was | used extensively at least in 2.4 (As in the usb-skeleton.c dbg macro.) I don't know that __FILE__ is deprecated and I didn't say that. It works, it

Re: [linux-usb-devel] __FILE__ returns full path now?

2005-04-22 Thread Michael Tokarev
Randy.Dunlap wrote: On Mon, 18 Apr 2005 11:15:50 -0500 Stephen Morgan wrote: | Hello all, | | I'm converting a USB driver for Linux 2.4.20-8 to 2.6.9-1.667 and have found | that the __FILE__ macro is now giving me the full path of the driver source. | In 2.4, I was just getting the file name. Lik

Re: [linux-usb-devel] [PATCH] hid-core: possible buffer overflow in hid-core.c

2005-01-30 Thread Michael Tokarev
Pete Zaitcev wrote: On Sun, 30 Jan 2005 15:28:23 +0300, Michael Tokarev <[EMAIL PROTECTED]> wrote: We have sizeof(), don't we? Ie, why snprintf(hid->name, 128, "%s", buf); instead of snprintf(hid->name, sizeof(hid->name), "%s", buf); I always fight this

Re: [linux-usb-devel] [PATCH] hid-core: possible buffer overflow in hid-core.c

2005-01-30 Thread Michael Tokarev
Randy.Dunlap wrote: [] diff -Naurp ./drivers/usb/input/hid-core.c~hid_buf_over ./drivers/usb/input/hid-core.c --- ./drivers/usb/input/hid-core.c~hid_buf_over 2005-01-22 17:11:12.0 -0800 +++ ./drivers/usb/input/hid-core.c 2005-01-29 19:04:18.0 -0800 @@ -1727,7 +1727,7 @@ static struc

Re: [linux-usb-devel] [RFC] Conexant AccessRunner ADSL USB modem driver

2004-12-22 Thread Michael Tokarev
Roman Kagan wrote: Hi, Attached is the driver for USB ADSL modems based on the Conexant AccessRunner chipset using the recently introduced usb_atm infrastructure. [] Not to say anything about this particular driver, but: isn't it better to implement this sort of stuff in userspace? USB driver does

Re: [linux-usb-devel] Minolta DImage 7i

2004-12-05 Thread Michael Tokarev
Stéphane EVAIN wrote: When I plug my Minolta Dimage 7i, linux don't "see" the disk, i have this message in /var/log/messages. I use Mandrake 10.1 with a regular kernel 2.6.8.1-12mdk I think this has been fixed in 2.6.9 already, both of the problems -- the camera indeed didn't work in 2.6.8 due to

Re: [linux-usb-devel] Minolta Dimage again, and US_FL_SINGLE_LUN with US_PR_BULK bug

2004-10-12 Thread Michael Tokarev
Alan Stern wrote: On Tue, 12 Oct 2004, Michael Tokarev wrote: [] The real purpose of the SINGLE_LUN flag is to prevent scanning for more than one LUN when the device only has one but has no way to tell us that. Especially when the device doesn't fail commands with LUN > 0. Aha.

Re: [linux-usb-devel] Minolta Dimage again, and US_FL_SINGLE_LUN with US_PR_BULK bug

2004-10-11 Thread Michael Tokarev
Alan Stern wrote: [] The fix was posted here: Aha, I see. Thank you very much, Alan! http://marc.theaimsgroup.com/?l=linux-usb-devel&m=109623013027142&w=2 BTW, this change is a bit strange still (only a bit, really - mostly cosmetic). I'd remove us->iobuf[0] = 0 initialization and restore "result

Re: [linux-usb-devel] Minolta Dimage again, and US_FL_SINGLE_LUN with US_PR_BULK bug

2004-10-10 Thread Michael Tokarev
Matthew Dharm wrote: This has already been fixed in a later kernel. Thanks for the info Matthew, it sounds promising. It'd be very helpful however if you point me to the relevant discussion or a changelog entry and diff or at least a (pre-)release number.. I lost my whole day today googling and a

[linux-usb-devel] Minolta Dimage again, and US_FL_SINGLE_LUN with US_PR_BULK bug

2004-10-10 Thread Michael Tokarev
I noticied my minolta dimage 7hi digital camera stopped working again in 2.6.8. I'm not alone -- see this http://sourcefrog.net/weblog/software/linux-kernel/usb/dimage7-patch.html page, at the bottom of it -- looks like Martin also isn't happy with it. While digging into the issue, I found several

Re: [linux-usb-devel] Minolta Dimage 7Hi digital camera again (unusual_devs.h)

2004-04-14 Thread Michael Tokarev
Alan Stern wrote: [] Judging from the original submissions http://marc.theaimsgroup.com/?l=linux-usb-devel&m=105439522917617&w=2 http://marc.theaimsgroup.com/?l=linux-usb-devel&m=107273801806294&w=2 and reports from other users http://marc.theaimsgroup.com/?l=linux-usb-devel&m=107306490916803&w=2

Re: [linux-usb-devel] Minolta Dimage 7Hi digital camera again (unusual_devs.h)

2004-04-14 Thread Michael Tokarev
Michael Tokarev wrote: Alan Stern wrote: On Tue, 13 Apr 2004, Michael Tokarev wrote: usb-storage: This device (0686,400f,0001 S 06 P 50) has an unneeded SubClass entry in unusual_devs.h Some time ago I posted a patch for this [EMAIL PROTECTED] kernel for this device, because it did not work

Re: [linux-usb-devel] Minolta Dimage 7Hi digital camera again (unusual_devs.h)

2004-04-14 Thread Michael Tokarev
Alan Stern wrote: On Tue, 13 Apr 2004, Michael Tokarev wrote: usb-storage: This device (0686,400f,0001 S 06 P 50) has an unneeded SubClass entry in unusual_devs.h [] Some time ago I posted a patch for this [EMAIL PROTECTED] kernel for this device, because it did not work. Now, it seems, the

[linux-usb-devel] Minolta Dimage 7Hi digital camera again (unusual_devs.h)

2004-04-12 Thread Michael Tokarev
usb-storage: This device (0686,400f,0001 S 06 P 50) has an unneeded SubClass entry in unusual_devs.h Please send a copy of this message to <[EMAIL PROTECTED]> scsi0 : SCSI emulation for USB Mass Storage devices Vendor: MINOLTA Model: DIMAGE CAMERARev: 1.00 Type: Direct-Access