ther your diff is toast, or your editor adds trailing space
> and THEN your mailer strips it. It's a pure luck that your patch
> is still usable.
Fixed.
Thanks for the help Pete! Here is the updated patch:
Signed-off-by: Sam King <[EMAIL PROTECTED]>
--- linux-2.4.27-base/drivers/
Done. I also took 8 bytes off of the POST_BSIZE to account for the
extra int (assuming int's are 8 bytes on 64 bit CPUs).
--Sam
Signed-off-by: Sam King <[EMAIL PROTECTED]>
--- drivers/usb/serial/usbserial.orig 2004-09-28 10:21:54.0 -0400
+++ drivers/usb/serial/usbseria
.
As a side effect, it also fixes the problem of io_ti.c making a call
to schedule when handling a throttle function call.
Below is a patch against the 2.4.27 kernel.
--Sam
-
Sam King
Ph.D. Student
Computer Science Department
University of Michigan, Ann Arbor
Hi Pete,
> > I found a bug where the io_ti.c driver calls schedule while in an
> > interrupt. The problem stems from usbserial.c allowing a
> > serial_throttle call proceed while in an interrupt, which results in
> > sending a urb to clear the CTS bit of the usb serial port, and thus a
> > call t
I am using (they are very similar)?
--Sam
-----
Sam King
Ph.D. Student
Computer Science Department
University of Michigan, Ann Arbor
--- /usr/src/linux-2.4/drivers/usb/serial/usbserial.c 2004-08-18 20:30:12.0
-0400
+++ usbserial.c 2004-09-20 12:10:13.
Hi Al,
> Another potential problem is that usbserial throttle can also sleep
> when it calls down(). You will have to fix that some other way.
My previous patch should take care of this for the 2.4 version of
usbserial.c, that is part of the reason I implemented the fix there
rather than in io_t
evice attached to ttyUSB0.
--Sam
-----
Sam King
Ph.D. Student
Computer Science Department
University of Michigan, Ann Arbor
On Tue, 14 Sep 2004, Pete Zaitcev wrote:
> On Tue, 14 Sep 2004 10:58:48 -0400 (EDT)
> Sam King <[EMAIL PROTECTED]> wrote:
>
> > I found a b
Here is an updated patch that should work. It is similar to the
previous patch except for a one line mistake correction from my
previous post.
--Sam
-
Sam King
Ph.D. Student
Computer Science Department
University of Michigan, Ann Arbor
--- /usr/src/linux-2.4
After looking more into the problem, it appears that my previous patch
did not actually fix the problem. I will post again when I have a new
patch, any ideas are welcome.
--Sam
-
Sam King
Ph.D. Student
Computer Science Department
University of Michigan, Ann Arbor
on a RedHat
Workstation 3.0 host running the 2.4.21-20.EL kernel.
I am using the usb-uhci.c driver and the io_ti.c usb serial port
device. The patch is based on the redhat 2.4.21-20 source tree.
This is my first patch, so please be gentle.
--Sam
-
Sam King
Ph.D
10 matches
Mail list logo
