Re: [linux-usb-devel] Kingsun KS-959 USB IrDA dongle - release candidate for submission (try 1)

2007-07-19 Thread Domen Puncer
On 19/07/07 11:36 -0500, Alex Villací­s Lasso wrote: > At last I managed to fix the problem with transfers with the dongle. It > happens that this dongle does not support payloads larger than 256 > bytes, so the driver has to manually fragment anything bigger. > > The version attached in the tar

Re: [linux-usb-devel] [PATCH] USB: removed a unbalanced #endif from ohci-au1xxx.c

2006-07-14 Thread Domen Puncer
> -#endif > } > > static void au1xxx_stop_ohc(struct platform_device *dev) Looks right to me. It looks like something went wrong with this patch http://www.linux-mips.org/git?p=linux.git;a=commitdiff;h=d14feb5ee4a46218f

[linux-usb-devel] [patch 1/1] drivers/usb/input/ati_remote.c : Use of time_after and time_before macros

2005-07-14 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after and time_before macros, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[

[linux-usb-devel] [patch 1/1] drivers/serial/usb-serial: Remove unneeded void casts

2005-07-07 Thread domen
From: Tobias Klauser <[EMAIL PROTECTED]> The following patch removes unneeded casts for the following (void *) pointers: - tty_struct->driver_data - void *private argument of usb_serial_port_softint() Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> Signed-off-b

[linux-usb-devel] [patch 1/1] (2/2) - trailing, 80th and similar things

2005-06-30 Thread domen
From: Carlo Perassi <[EMAIL PROTECTED]> Reading this driver I noticed some trailing whitespaces and tabs so I removed them with some 80th column fitting and a few more similar things. Signed-off-by: Carlo Perassi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[

[linux-usb-devel] [patch 1/1] dma-mask : drivers/usb/host/ehci-hcd.c

2005-06-20 Thread domen
() See http://marc.theaimsgroup.com/?t=10800199301&r=1&w=2 for details Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- ehci-hcd.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: qu

[linux-usb-devel] [patch] usblp: 2x up() in usblp_read

2005-06-05 Thread Domen Puncer
up(&usblp->sem) was called twice in a row in this code path. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- c/drivers/usb/class/usblp.c 2005-05-25 13:34:54.0 +0200 +++ a/drivers/usb/class/usblp.c 2005-06-05 14:38:39.0 +0200 @@ -751,6 +751,7 @@ static ssize

[linux-usb-devel] [patch 1/1] usb/digi_acceleport: correct wait-queue state

2005-04-08 Thread domen
patch was merged into 2.6.11-rc2. Incremental patch for 2.6.11-rc2 attached. First patch incorrectly changed state of the wait-queue usage to TASK_UNINTERRUPTIBLE. Reverted to TASK_INTERRUPTIBLE. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL P

[linux-usb-devel] [patch 1/1] dma-mask : drivers/usb/host/ehci-hcd.c

2005-04-08 Thread domen
1&r=1&w=2 for details Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/usb/host/ehci-hcd.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/usb/host/ehci-hcd.c~dma_mask-

[linux-usb-devel] [patch 1/2] class/usblp: cleanup usblp_write()

2005-03-06 Thread domen
The while-loop seemed excessively blocked with conditionals. By reorganizing the code so timeout is the condition for the loop and changing the checks within the loop, several lines of code were removed. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer &

[linux-usb-devel] [patch 3/4] usb/digi_acceleport: remove interruptible_sleep_on_timeout() usage

2005-03-06 Thread domen
in the current code). Patch is compile-tested. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/usb/serial/digi_acceleport.c | 32 +++--- 1 files changed, 14 insertions(+), 18 deletions(-

[linux-usb-devel] [patch 4/4] drivers/usb/image/* - compile warning cleanup

2005-03-06 Thread domen
compile warning cleanup - handle error return from scsi_add_host Signed-off-by: Stephen Biggs <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/usb/image/microtek.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff -puN

[linux-usb-devel] [patch 2/2] usb/usblp: use wait_event_interruptible_timeout()

2005-03-06 Thread domen
Use wait_event_timeout() instead of custom wait-queue code. Remove now unused variables. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/usb/class/usblp.c | 24 +++- 1 file

[linux-usb-devel] [patch 2/4] usb/rio500: remove interruptible_sleep_on_timeout() usage

2005-03-06 Thread domen
Replace deprecated interruptible_sleep_on_timeout() with direct wait-queue usage. Patch is compile-tested. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/usb/misc/rio500.c | 12 +--- 1 file

[linux-usb-devel] [patch 1/4] usb/usb-midi: remove interruptible_sleep_on_timeout() usage

2005-03-06 Thread domen
Replace direct wait-queue usage with wait_event_timeout(). Removed some local variables which help determine loop time, but which are now compressed into the wait_event_timeout() macro. Patch is compile-tested. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Domen

[linux-usb-devel] [patch 1/1] ov511.c - vfree() checking cleanups

2005-01-10 Thread domen
ov511.c vfree() checking cleanups. Signed-off by: James Lamanna <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/usb/media/ov511.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff -puN drivers/usb/media/o

[linux-usb-devel] [patch 1/1] class/usblp: cleanup usblp_write()

2004-12-25 Thread domen
 } > > > > The order of checking wcomplete and setting the state must be reversed. > > OK, thanks for the pointer. Please find the corrected patch below. Sorry, I missed a reassignment of the state to TASK_RUNNING in this patch. Thanks, Domen, for cathing thi

[linux-usb-devel] Re: list_for_each_entry: drivers-usb-host-uhci-hcd.c

2004-09-10 Thread Domen Puncer
On 10/09/04 15:47 -0400, Alan Stern wrote: > On Wed, 1 Sep 2004 [EMAIL PROTECTED] wrote: > > > Make code more readable with list_for_each_entry. > > Compile tested. > > > > Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> > > Signed-off-by: Maximilian

[linux-usb-devel] [patch 2.6.7] usbfs honors mount options again

2004-07-14 Thread Domen Puncer
thing wierd. I moved parse_options from usb_fill_super (called on first mount, which is simple_pin_fs) to usb_get_sb. Also reorganized usbfs_init a bit, but i can drop that, if it seems unnecessary/too ugly to someone. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> diff -pruNX dontdiff c/

[linux-usb-devel] [patch 2.6.4] removing sleep_on from drivers/usb/serial/whiteheat.c

2004-03-20 Thread Domen Puncer
Hi. Only compile tested. Any feedback welcome. --- c/drivers/usb/serial/whiteheat.c2004-02-04 10:06:59.0 +0100 +++ a/drivers/usb/serial/whiteheat.c2004-03-21 02:09:15.0 +0100 @@ -1132,6 +1132,7 @@ static int firm_send_command (struct usb __u8 *transfer_buffer;

[linux-usb-devel] Re: [Kernel-janitors] [patch 2.6.4] removing sleep_on in drivers/usb/media/usbvideo.c v2

2004-03-20 Thread Domen Puncer
On Saturday 20 of March 2004 23:13, Domen Puncer wrote: > On Saturday 20 of March 2004 22:48, Greg KH wrote: > > On Sat, Mar 20, 2004 at 10:33:36PM +0100, Domen Puncer wrote: > > > Hi. > > > > > > This is my first patch on sleep_on, so i'd really like so

[linux-usb-devel] Re: [Kernel-janitors] [patch 2.6.4] removing sleep_on in drivers/usb/media/usbvideo.c

2004-03-20 Thread Domen Puncer
On Saturday 20 of March 2004 22:48, Greg KH wrote: > On Sat, Mar 20, 2004 at 10:33:36PM +0100, Domen Puncer wrote: > > Hi. > > > > This is my first patch on sleep_on, so i'd really like some comments. > > Please cc the linux-usb-devel list, they will help you ou