Re: [linux-usb-devel] please, revert 786dc1d3d7333f269e17d742886eac2188a2d9cc

2006-06-24 Thread Al Viro
On Sat, Jun 24, 2006 at 06:07:36PM -0400, Alan Stern wrote: > Isn't it obvious what inspired the original report? > > If you don't look very closely at the structure definition you won't > realize that iso_frame_desc is an array. If it were a scalar field then > the patch would have been correc

Re: [linux-usb-devel] please, revert 786dc1d3d7333f269e17d742886eac2188a2d9cc

2006-06-24 Thread Al Viro
On Sat, Jun 24, 2006 at 10:38:37AM -0700, Greg KH wrote: > Ugh, ok, I went back and forth with Andrew on this, before I took it. > Andrew, any objections to reverting this now? Also spelled as "Andrew, could you please RTFS?" When we have struct foo { struct bar array[0]; }; str

[linux-usb-devel] please, revert 786dc1d3d7333f269e17d742886eac2188a2d9cc

2006-06-24 Thread Al Viro
commit 786dc1d3d7333f269e17d742886eac2188a2d9cc Author: Philippe Retornaz <[EMAIL PROTECTED]> Date: Thu Jun 1 20:48:46 2006 -0700 [PATCH] usb: drivers/usb/core/devio.c dereferences a userspace pointer See http://bugzilla.kernel.org/show_bug.cgi?id=6617. This function derefe

[linux-usb-devel] Re: Summarizing the PWC driver questions/answers

2004-08-30 Thread viro
On Mon, Aug 30, 2004 at 10:31:57AM -0700, Brian Litzinger wrote: > I do not believe he "had no choice". The guards at Auswitchs made the > same argument at Nuremberg. The tribunal determined they did have a > choice. I doubt we can consider the conditions here more extreme > then there. *PLONK

Re: [linux-usb-devel] Re: Finding user/kernel pointer bugs [no html]

2004-06-10 Thread viro
On Fri, Jun 11, 2004 at 06:31:07AM +0200, Luca Risolia wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > >unsigned int cmd, void* arg) > > { > > struct w9968cf_device* cam; > > + void __user *user_arg = (void __user *)arg; > > The right place to apply this pa

[linux-usb-devel] Re: Finding user/kernel pointer bugs [no html]

2004-06-10 Thread viro
On Thu, Jun 10, 2004 at 11:34:42AM -0700, Greg KH wrote: > struct usb_mixerdev *ms = (struct usb_mixerdev *)file->private_data; > int i, j, val; > + int __user *int_user_arg = (int __user *)arg; Egads... How about changing the name to something that would not be so scary? --

[linux-usb-devel] Re: [RFC] device_initialize()

2002-10-15 Thread Alexander Viro
add() and make device_register() call device_initialize() followed by device_add()... BTW, my variant of the same beast is on ftp.math.psu.edu/pub/viro/O/O142-device_add-C42 with uses in O14[3-6]* in the same place... --- This sf.net emai