Re: [PATCH][linux-usb-devel] Early USB handoff

2004-09-01 Thread David Brownell
> Attached for 2.6. Not easy to switch from one project to another :-) > Let's see how it goes and patch for 2.4 will follow. Hmm, this duplicates code that's already in the three HCDs. In this case, duplication seems unwise. Could you re-factor this code so that it's part of those HCDs, in driv

RE: [PATCH][linux-usb-devel] Early USB handoff

2004-08-20 Thread Aleksey Gorelov
>This looks good, however I'd like you to make spacing more kernel-like, >for example here: > >> +writel( 0x3f, op_reg_base + EHCI_USBSTS); >> +udelay( delta); > >Also, the double star has to go: > > /** > * foo > */ Attached for 2.6. Not easy to switch f

Re: [PATCH][linux-usb-devel] Early USB handoff

2004-08-18 Thread Pete Zaitcev
On Mon, 16 Aug 2004 19:09:53 -0700 "Aleksey Gorelov" <[EMAIL PROTECTED]> wrote: > Attached is a patch for 2.6.8.1 This looks good, however I'd like you to make spacing more kernel-like, for example here: > + writel( 0x3f, op_reg_base + EHCI_USBSTS); > + ud

RE: [PATCH][linux-usb-devel] Early USB handoff

2004-08-17 Thread Aleksey Gorelov
>You could reorder and simplify slightly the code for handing off a UHCI >controller. It's safer to disable PIRQD, SMI#, and legacy >support first >and then turn off the interrupt enable bits, all before stopping the >controller. You could even reset the controller rather than >just stopping

Re: [PATCH][linux-usb-devel] Early USB handoff

2004-08-17 Thread Alan Stern
On Mon, 16 Aug 2004, Aleksey Gorelov wrote: > >> Here is slightly improved early USB legacy handoff patch for 2.4.27 > > > >The usual caveat is how we all wait for this to go into 2.6. > > Attached is a patch for 2.6.8.1 You could reorder and simplify slightly the code for handing off a UHCI c

Re: [PATCH][linux-usb-devel] Early USB handoff

2004-08-16 Thread Aleksey Gorelov
>> Here is slightly improved early USB legacy handoff patch for 2.4.27 > >The usual caveat is how we all wait for this to go into 2.6. Attached is a patch for 2.6.8.1 >> Handoff is under no-usb-legacy option. >> +int disable_legacy_usb __initdata = 0; > >I think it's an unfortunate naming. Wh

Re: [PATCH][linux-usb-devel] Early USB handoff

2004-08-16 Thread Pete Zaitcev
On Mon, 16 Aug 2004 13:06:17 -0700 "Aleksey Gorelov" <[EMAIL PROTECTED]> wrote: > Here is slightly improved early USB legacy handoff patch for 2.4.27 The usual caveat is how we all wait for this to go into 2.6. > I've tested it on a number of machines (mostly laptops) for UHCI & > OHCI, but

[PATCH][linux-usb-devel] Early USB handoff

2004-08-16 Thread Aleksey Gorelov
Hello everybody, Here is slightly improved early USB legacy handoff patch for 2.4.27 (original patch is here: http://www.mail-archive.com/linux-usb-devel%40lists.sourceforge.net/msg2 6803.html). Patch includes support for EHCI handoff, and not only hands off legacy support, but also helps avo