Re: [linux-usb-devel] [PATCH/RFC] EHCI and OHCI big endian registers only support

2006-11-07 Thread Benjamin Herrenschmidt
On Tue, 2006-11-07 at 10:17 -0500, Alan Stern wrote: > On Tue, 7 Nov 2006, Benjamin Herrenschmidt wrote: > > > > > > Just so that you know -- I'm in the middle of submitting one or more > > > patches that do MMIO in ehci-hcd. Once Greg has accepted them you will > > > have to update your patch t

Re: [linux-usb-devel] [PATCH/RFC] EHCI and OHCI big endian registers only support

2006-11-07 Thread Alan Stern
On Tue, 7 Nov 2006, Benjamin Herrenschmidt wrote: > > > Just so that you know -- I'm in the middle of submitting one or more > > patches that do MMIO in ehci-hcd. Once Greg has accepted them you will > > have to update your patch to change my patch's readl() and writel() calls > > to ehci_readl(

Re: [linux-usb-devel] [PATCH/RFC] EHCI and OHCI big endian registers only support

2006-11-06 Thread Benjamin Herrenschmidt
> Just so that you know -- I'm in the middle of submitting one or more > patches that do MMIO in ehci-hcd. Once Greg has accepted them you will > have to update your patch to change my patch's readl() and writel() calls > to ehci_readl() and ehci_writel(). No big deal. > > There doesn't seem to

Re: [linux-usb-devel] [PATCH/RFC] EHCI and OHCI big endian registers only support

2006-11-06 Thread David Brownell
On Monday 06 November 2006 12:29 pm, Benjamin Herrenschmidt wrote: > > But you'd make Andrew Morton a bit happier if you were switching > > > > readl (...) > > to > > ehci_readl(ehci, ...) > > > > That is, remove whitespace-for-readability in the "new" code. > > Hrm... you want me to re

Re: [linux-usb-devel] [PATCH/RFC] EHCI and OHCI big endian registers only support

2006-11-06 Thread Benjamin Herrenschmidt
On Mon, 2006-11-06 at 10:58 -0800, David Brownell wrote: > On Saturday 04 November 2006 10:42 pm, Benjamin Herrenschmidt wrote: > > > The issue is that those have an EHCI/OHCI pair which has big endian > > registers but little manipulates DMA data structures in little endian > > form (some would s

Re: [linux-usb-devel] [PATCH/RFC] EHCI and OHCI big endian registers only support

2006-11-06 Thread David Brownell
On Saturday 04 November 2006 10:42 pm, Benjamin Herrenschmidt wrote: > The issue is that those have an EHCI/OHCI pair which has big endian > registers but little manipulates DMA data structures in little endian > form (some would say they are only half broken :-) I don't actually understand why c

Re: [linux-usb-devel] [PATCH/RFC] EHCI and OHCI big endian registers only support

2006-11-05 Thread Benjamin Herrenschmidt
On Sun, 2006-11-05 at 12:25 -0500, Alan Stern wrote: > On Sun, 5 Nov 2006, Benjamin Herrenschmidt wrote: > > > Hi ! > > > > I'm sending this patch on behalf of Toshiba. This version of the patch > > is mostly for comments, I'll forward a more "final" one as soon as I get > > it from them, possibl

Re: [linux-usb-devel] [PATCH/RFC] EHCI and OHCI big endian registers only support

2006-11-05 Thread Alan Stern
On Sun, 5 Nov 2006, Benjamin Herrenschmidt wrote: > Hi ! > > I'm sending this patch on behalf of Toshiba. This version of the patch > is mostly for comments, I'll forward a more "final" one as soon as I get > it from them, possibly addressing comments you guys might have. > > The goal is to have

[linux-usb-devel] [PATCH/RFC] EHCI and OHCI big endian registers only support

2006-11-04 Thread Benjamin Herrenschmidt
Hi ! I'm sending this patch on behalf of Toshiba. This version of the patch is mostly for comments, I'll forward a more "final" one as soon as I get it from them, possibly addressing comments you guys might have. The goal is to have that in 2.6.20 along with the support for the platforms that nee