Re: [linux-usb-devel] [PATCH] gadgetfs: fix AIO interface

2007-01-17 Thread Alan Stern
On Wed, 17 Jan 2007, David Brownell wrote: > > Okay, thanks. (But weren't those Burma-Shave ads before your time? I > > don't remember ever seeing any of them.) > > They featured in the MAD magazine parts of a misspent youth, and > I liked that bit of Americana. Plus, I was too lazy to come u

Re: [linux-usb-devel] [PATCH] gadgetfs: fix AIO interface

2007-01-17 Thread David Brownell
On Wednesday 17 January 2007 8:02 am, Alan Stern wrote: > On Tue, 16 Jan 2007, David Brownell wrote: > > > On Tuesday 16 January 2007 8:52 am, Alan Stern wrote: > > > > > + /* if this was a write or a read returning no data then we > > > + * don't need to copy anything to userspace, so we can >

Re: [linux-usb-devel] [PATCH] gadgetfs: fix AIO interface

2007-01-17 Thread Alan Stern
On Tue, 16 Jan 2007, David Brownell wrote: > On Tuesday 16 January 2007 8:52 am, Alan Stern wrote: > > > + /* if this was a write or a read returning no data then we > > +* don't need to copy anything to userspace, so we can > > +* complete the aio request immediately. */ > > I forward

Re: [linux-usb-devel] [PATCH] gadgetfs: fix AIO interface

2007-01-16 Thread David Brownell
On Tuesday 16 January 2007 8:52 am, Alan Stern wrote: > + /* if this was a write or a read returning no data then we > + * don't need to copy anything to userspace, so we can > + * complete the aio request immediately. */ I forwarded this to Greg after refreshing it to go on top of

Re: [linux-usb-devel] [PATCH] gadgetfs: fix AIO interface

2007-01-16 Thread Alan Stern
On Tue, 16 Jan 2007, David Brownell wrote: > > The ki_retry method is not supposed to do a put on the kiocb. > > The extra call to aio_put_req() causes memory corruption. > > (Note: This call was removed before, by patch as691, and then > > mysteriously re-introduced later.) > > I

Re: [linux-usb-devel] [PATCH] gadgetfs: fix AIO interface

2007-01-16 Thread David Brownell
> The ki_retry method is not supposed to do a put on the kiocb. > The extra call to aio_put_req() causes memory corruption. > (Note: This call was removed before, by patch as691, and then > mysteriously re-introduced later.) I'm still not convinced on this one; I'll get bac

[linux-usb-devel] [PATCH] gadgetfs: fix AIO interface

2007-01-16 Thread Alan Stern
This patch (as837) fixes several mistakes in the AIO interface of the gadgetfs driver: The ki_retry method is not supposed to do a put on the kiocb. The extra call to aio_put_req() causes memory corruption. (Note: This call was removed before, by patch as691, and then

[linux-usb-devel] [PATCH] gadgetfs: fix AIO interface bugs

2006-05-22 Thread Alan Stern
Greg: This patch (as691) fixes a few errors in the AIO interface for the gadgetfs driver. Now requests will complete properly instead of hanging. Alan Stern Signed-off-by: Alan Stern <[EMAIL PROTECTED]> --- Index: usb-2.6/drivers/usb/gadget/inode.c ==